Passed
Pull Request — master (#109)
by Marco
05:58 queued 03:28
created
src/SourceLocator/StubClassSourceLocator.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
      */
35 35
     protected function createLocatedSource(Identifier $identifier) : ?LocatedSource
36 36
     {
37
-        if (! $identifier->isClass()) {
37
+        if (!$identifier->isClass()) {
38 38
             return null;
39 39
         }
40 40
 
Please login to merge, or discard this patch.
test/e2e/Command/AssertBackwardsCompatibleTest.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -120,7 +120,7 @@
 block discarded – undo
120 120
             (new Process('git add -A', $this->sourcesRepository))->mustRun();
121 121
             (new Process(sprintf('git commit -am "Class sources v%d"', $key + 1), $this->sourcesRepository))->mustRun();
122 122
             $this->versions[$key] = trim((new Process('git rev-parse HEAD', $this->sourcesRepository))->mustRun()
123
-                                                                                                      ->getOutput());
123
+                                                                                                        ->getOutput());
124 124
         }
125 125
     }
126 126
 
Please login to merge, or discard this patch.
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -105,20 +105,20 @@  discard block
 block discarded – undo
105 105
 
106 106
         unlink($this->sourcesRepository);
107 107
         mkdir($this->sourcesRepository);
108
-        mkdir($this->sourcesRepository . '/src');
108
+        mkdir($this->sourcesRepository.'/src');
109 109
 
110 110
         self::assertDirectoryExists($this->sourcesRepository);
111
-        self::assertDirectoryExists($this->sourcesRepository . '/src');
111
+        self::assertDirectoryExists($this->sourcesRepository.'/src');
112 112
 
113 113
         (new Process('git init', $this->sourcesRepository))->mustRun();
114 114
 
115
-        file_put_contents($this->sourcesRepository . '/composer.json', self::COMPOSER_MANIFEST);
115
+        file_put_contents($this->sourcesRepository.'/composer.json', self::COMPOSER_MANIFEST);
116 116
 
117 117
         (new Process('git add -A', $this->sourcesRepository))->mustRun();
118 118
         (new Process('git commit -am "Initial commit with composer manifest"', $this->sourcesRepository))->mustRun();
119 119
 
120 120
         foreach (self::CLASS_VERSIONS as $key => $classCode) {
121
-            file_put_contents($this->sourcesRepository . '/src/TheClass.php', $classCode);
121
+            file_put_contents($this->sourcesRepository.'/src/TheClass.php', $classCode);
122 122
 
123 123
             (new Process('git add -A', $this->sourcesRepository))->mustRun();
124 124
             (new Process(sprintf('git commit -am "Class sources v%d"', $key + 1), $this->sourcesRepository))->mustRun();
@@ -143,9 +143,9 @@  discard block
 block discarded – undo
143 143
     {
144 144
         $check = new Process(
145 145
             [
146
-                __DIR__ . '/../../../bin/roave-backward-compatibility-check',
147
-                '--from=' . $this->versions[0],
148
-                '--to=' . $this->versions[1],
146
+                __DIR__.'/../../../bin/roave-backward-compatibility-check',
147
+                '--from='.$this->versions[0],
148
+                '--to='.$this->versions[1],
149 149
             ],
150 150
             $this->sourcesRepository
151 151
         );
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
     public function testWillNotRunWithoutTagsNorSpecifiedVersions() : void
166 166
     {
167 167
         $check = new Process(
168
-            __DIR__ . '/../../../bin/roave-backward-compatibility-check',
168
+            __DIR__.'/../../../bin/roave-backward-compatibility-check',
169 169
             $this->sourcesRepository
170 170
         );
171 171
 
@@ -180,9 +180,9 @@  discard block
 block discarded – undo
180 180
     {
181 181
         $check = new Process(
182 182
             [
183
-                __DIR__ . '/../../../bin/roave-backward-compatibility-check',
184
-                '--from=' . $this->versions[0],
185
-                '--to=' . $this->versions[3],
183
+                __DIR__.'/../../../bin/roave-backward-compatibility-check',
184
+                '--from='.$this->versions[0],
185
+                '--to='.$this->versions[3],
186 186
             ],
187 187
             $this->sourcesRepository
188 188
         );
@@ -200,8 +200,8 @@  discard block
 block discarded – undo
200 200
 
201 201
         $check = new Process(
202 202
             [
203
-                __DIR__ . '/../../../bin/roave-backward-compatibility-check',
204
-                '--to=' . $this->versions[2],
203
+                __DIR__.'/../../../bin/roave-backward-compatibility-check',
204
+                '--to='.$this->versions[2],
205 205
             ],
206 206
             $this->sourcesRepository
207 207
         );
@@ -229,8 +229,8 @@  discard block
 block discarded – undo
229 229
 
230 230
         $check = new Process(
231 231
             [
232
-                __DIR__ . '/../../../bin/roave-backward-compatibility-check',
233
-                '--to=' . $this->versions[2],
232
+                __DIR__.'/../../../bin/roave-backward-compatibility-check',
233
+                '--to='.$this->versions[2],
234 234
             ],
235 235
             $this->sourcesRepository
236 236
         );
@@ -268,7 +268,7 @@  discard block
 block discarded – undo
268 268
                 'tag',
269 269
                 $tagName,
270 270
                 '-m',
271
-                'A tag for version ' . $version,
271
+                'A tag for version '.$version,
272 272
             ],
273 273
             $this->sourcesRepository
274 274
         ))->mustRun();
Please login to merge, or discard this patch.
test/unit/ChangeTest.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
     {
19 19
         $changeText = uniqid('changeText', true);
20 20
         $change     = Change::added($changeText, false);
21
-        self::assertSame('     ADDED: ' . $changeText, (string) $change);
21
+        self::assertSame('     ADDED: '.$changeText, (string) $change);
22 22
         self::assertTrue($change->isAdded());
23 23
         self::assertFalse($change->isChanged());
24 24
         self::assertFalse($change->isRemoved());
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
     {
30 30
         $changeText = uniqid('changeText', true);
31 31
         $change     = Change::added($changeText, true);
32
-        self::assertSame('[BC] ADDED: ' . $changeText, (string) $change);
32
+        self::assertSame('[BC] ADDED: '.$changeText, (string) $change);
33 33
         self::assertTrue($change->isAdded());
34 34
         self::assertFalse($change->isChanged());
35 35
         self::assertFalse($change->isRemoved());
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
     {
41 41
         $changeText = uniqid('changeText', true);
42 42
         $change     = Change::changed($changeText, false);
43
-        self::assertSame('     CHANGED: ' . $changeText, (string) $change);
43
+        self::assertSame('     CHANGED: '.$changeText, (string) $change);
44 44
         self::assertFalse($change->isAdded());
45 45
         self::assertTrue($change->isChanged());
46 46
         self::assertFalse($change->isRemoved());
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
     {
51 51
         $changeText = uniqid('changeText', true);
52 52
         $change     = Change::changed($changeText, true);
53
-        self::assertSame('[BC] CHANGED: ' . $changeText, (string) $change);
53
+        self::assertSame('[BC] CHANGED: '.$changeText, (string) $change);
54 54
         self::assertFalse($change->isAdded());
55 55
         self::assertTrue($change->isChanged());
56 56
         self::assertFalse($change->isRemoved());
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
     {
62 62
         $changeText = uniqid('changeText', true);
63 63
         $change     = Change::removed($changeText, false);
64
-        self::assertSame('     REMOVED: ' . $changeText, (string) $change);
64
+        self::assertSame('     REMOVED: '.$changeText, (string) $change);
65 65
         self::assertFalse($change->isAdded());
66 66
         self::assertFalse($change->isChanged());
67 67
         self::assertTrue($change->isRemoved());
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
     {
73 73
         $changeText = uniqid('changeText', true);
74 74
         $change     = Change::removed($changeText, true);
75
-        self::assertSame('[BC] REMOVED: ' . $changeText, (string) $change);
75
+        self::assertSame('[BC] REMOVED: '.$changeText, (string) $change);
76 76
         self::assertFalse($change->isAdded());
77 77
         self::assertFalse($change->isChanged());
78 78
         self::assertTrue($change->isRemoved());
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
     {
84 84
         $failure = new Exception('changeText');
85 85
         $change  = Change::skippedDueToFailure($failure);
86
-        self::assertSame('[BC] SKIPPED: ' . $failure->getMessage(), (string) $change);
86
+        self::assertSame('[BC] SKIPPED: '.$failure->getMessage(), (string) $change);
87 87
         self::assertFalse($change->isAdded());
88 88
         self::assertFalse($change->isChanged());
89 89
         self::assertFalse($change->isRemoved());
Please login to merge, or discard this patch.
bin/roave-backward-compatibility-check.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -31,11 +31,11 @@  discard block
 block discarded – undo
31 31
 use Symfony\Component\Console\Output\ConsoleOutput;
32 32
 use function file_exists;
33 33
 
34
-(function () : void {
35
-    (function () : void {
34
+(function() : void {
35
+    (function() : void {
36 36
         $autoloaderLocations = [
37
-            __DIR__ . '/../vendor/autoload.php', // Installed by cloning the project and running `composer install`
38
-            __DIR__ . '/../../../autoload.php',  // Installed via `composer require`
37
+            __DIR__.'/../vendor/autoload.php', // Installed by cloning the project and running `composer install`
38
+            __DIR__.'/../../../autoload.php', // Installed via `composer require`
39 39
         ];
40 40
 
41 41
         foreach ($autoloaderLocations as $autoload) {
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
         new GetVersionCollectionFromGitRepository(),
65 65
         new PickLastMinorVersionFromCollection(),
66 66
         new LocateDependenciesViaComposer(
67
-            function (string $installationPath) use ($composerIo) : Installer {
67
+            function(string $installationPath) use ($composerIo) : Installer {
68 68
                 return Installer::create(
69 69
                     $composerIo,
70 70
                     (new Factory())->createComposer(
Please login to merge, or discard this patch.
test/unit/Command/AssertBackwardsCompatibleTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
 
76 76
     public function setUp() : void
77 77
     {
78
-        $repositoryPath = realpath(__DIR__ . '/../../../');
78
+        $repositoryPath = realpath(__DIR__.'/../../../');
79 79
 
80 80
         self::assertInternalType('string', $repositoryPath);
81 81
 
@@ -274,7 +274,7 @@  discard block
 block discarded – undo
274 274
 
275 275
         $this->output->expects(self::any())
276 276
             ->method('writeln')
277
-            ->willReturnCallback(function (string $output) use ($changeToExpect) : void {
277
+            ->willReturnCallback(function(string $output) use ($changeToExpect) : void {
278 278
                 self::assertContains($changeToExpect, $output);
279 279
             });
280 280
     }
@@ -358,7 +358,7 @@  discard block
 block discarded – undo
358 358
 
359 359
         $this->getVersions->expects(self::once())
360 360
             ->method('fromRepository')
361
-            ->with(self::callback(function (CheckedOutRepository $checkedOutRepository) : bool {
361
+            ->with(self::callback(function(CheckedOutRepository $checkedOutRepository) : bool {
362 362
                 self::assertEquals($this->sourceRepository, $checkedOutRepository);
363 363
                 return true;
364 364
             }))
Please login to merge, or discard this patch.
test/unit/Git/GitCheckoutRevisionToTemporaryPathTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
 
48 48
     public function testExceptionIsThrownWhenTwoPathsCollide() : void
49 49
     {
50
-        $git              = new GitCheckoutRevisionToTemporaryPath(function () : string {
50
+        $git              = new GitCheckoutRevisionToTemporaryPath(function() : string {
51 51
             return 'foo';
52 52
         });
53 53
         $sourceRepository = $this->sourceRepository();
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
 
76 76
     private function sourceRepository() : CheckedOutRepository
77 77
     {
78
-        $repositoryPath = realpath(__DIR__ . '/../../..');
78
+        $repositoryPath = realpath(__DIR__.'/../../..');
79 79
 
80 80
         self::assertInternalType('string', $repositoryPath);
81 81
 
Please login to merge, or discard this patch.
test/unit/LocateDependencies/LocateDependenciesViaComposerTest.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
         $this->originalCwd       = $originalCwd;
54 54
         $this->composerInstaller = $this->createMock(Installer::class);
55 55
         $this->astLocator        = (new BetterReflection())->astLocator();
56
-        $this->makeInstaller     = function (string $installationPath) : Installer {
56
+        $this->makeInstaller     = function(string $installationPath) : Installer {
57 57
             self::assertSame($this->expectedInstallatonPath, $installationPath);
58 58
 
59 59
             return $this->composerInstaller;
@@ -102,13 +102,13 @@  discard block
 block discarded – undo
102 102
 
103 103
     public function testWillLocateDependencies() : void
104 104
     {
105
-        $this->expectedInstallatonPath = $this->realpath(__DIR__ . '/../../asset/composer-installation-structure');
105
+        $this->expectedInstallatonPath = $this->realpath(__DIR__.'/../../asset/composer-installation-structure');
106 106
 
107 107
         $this
108 108
             ->composerInstaller
109 109
             ->expects(self::once())
110 110
             ->method('run')
111
-            ->willReturnCallback(function () : void {
111
+            ->willReturnCallback(function() : void {
112 112
                 self::assertSame($this->expectedInstallatonPath, getcwd());
113 113
             });
114 114
 
@@ -128,8 +128,8 @@  discard block
 block discarded – undo
128 128
         self::assertEquals(
129 129
             new StaticClassMapSourceLocator(
130 130
                 [
131
-                    'A\\ClassName' => $this->realpath(__DIR__ . '/../../asset/composer-installation-structure/AClassName.php'),
132
-                    'B\\ClassName' => $this->realpath(__DIR__ . '/../../asset/composer-installation-structure/BClassName.php'),
131
+                    'A\\ClassName' => $this->realpath(__DIR__.'/../../asset/composer-installation-structure/AClassName.php'),
132
+                    'B\\ClassName' => $this->realpath(__DIR__.'/../../asset/composer-installation-structure/BClassName.php'),
133 133
                 ],
134 134
                 $this->astLocator
135 135
             ),
@@ -138,11 +138,11 @@  discard block
 block discarded – undo
138 138
         self::assertEquals(
139 139
             new AggregateSourceLocator([
140 140
                 new SingleFileSourceLocator(
141
-                    $this->realpath(__DIR__ . '/../../asset/composer-installation-structure/included-file-1.php'),
141
+                    $this->realpath(__DIR__.'/../../asset/composer-installation-structure/included-file-1.php'),
142 142
                     $this->astLocator
143 143
                 ),
144 144
                 new SingleFileSourceLocator(
145
-                    $this->realpath(__DIR__ . '/../../asset/composer-installation-structure/included-file-2.php'),
145
+                    $this->realpath(__DIR__.'/../../asset/composer-installation-structure/included-file-2.php'),
146 146
                     $this->astLocator
147 147
                 ),
148 148
             ]),
@@ -154,13 +154,13 @@  discard block
 block discarded – undo
154 154
 
155 155
     public function testWillLocateDependenciesEvenWithoutAutoloadFiles() : void
156 156
     {
157
-        $this->expectedInstallatonPath = $this->realpath(__DIR__ . '/../../asset/composer-installation-structure-without-autoload-files');
157
+        $this->expectedInstallatonPath = $this->realpath(__DIR__.'/../../asset/composer-installation-structure-without-autoload-files');
158 158
 
159 159
         $this
160 160
             ->composerInstaller
161 161
             ->expects(self::once())
162 162
             ->method('run')
163
-            ->willReturnCallback(function () : void {
163
+            ->willReturnCallback(function() : void {
164 164
                 self::assertSame($this->expectedInstallatonPath, getcwd());
165 165
             });
166 166
 
@@ -180,8 +180,8 @@  discard block
 block discarded – undo
180 180
         self::assertEquals(
181 181
             new StaticClassMapSourceLocator(
182 182
                 [
183
-                    'A\\ClassName' => $this->realpath(__DIR__ . '/../../asset/composer-installation-structure-without-autoload-files/AClassName.php'),
184
-                    'B\\ClassName' => $this->realpath(__DIR__ . '/../../asset/composer-installation-structure-without-autoload-files/BClassName.php'),
183
+                    'A\\ClassName' => $this->realpath(__DIR__.'/../../asset/composer-installation-structure-without-autoload-files/AClassName.php'),
184
+                    'B\\ClassName' => $this->realpath(__DIR__.'/../../asset/composer-installation-structure-without-autoload-files/BClassName.php'),
185 185
                 ],
186 186
                 $this->astLocator
187 187
             ),
Please login to merge, or discard this patch.
src/Git/PickLastMinorVersionFromCollection.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
                 new ComparisonConstraint(ComparisonConstraint::OPERATOR_LTE, $lastVersion),
38 38
                 new ComparisonConstraint(
39 39
                     ComparisonConstraint::OPERATOR_GTE,
40
-                    Version::fromString($lastVersion->getMajor() . '.' . $lastVersion->getMinor() . '.0')
40
+                    Version::fromString($lastVersion->getMajor().'.'.$lastVersion->getMinor().'.0')
41 41
                 )
42 42
             ))
43 43
             ->sortedAscending();
Please login to merge, or discard this patch.
test/unit/LocateSources/LocateSourcesViaComposerJsonTest.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -45,37 +45,37 @@
 block discarded – undo
45 45
     {
46 46
         return [
47 47
             'empty composer definition' => [
48
-                __DIR__ . '/../../asset/located-sources/empty',
48
+                __DIR__.'/../../asset/located-sources/empty',
49 49
                 new AggregateSourceLocator([
50 50
                     new DirectoriesSourceLocator([], $this->astLocator()),
51 51
                 ]),
52 52
             ],
53 53
             'composer definition with everything' => [
54
-                __DIR__ . '/../../asset/located-sources/composer-definition-with-everything',
54
+                __DIR__.'/../../asset/located-sources/composer-definition-with-everything',
55 55
                 new AggregateSourceLocator([
56 56
                     new DirectoriesSourceLocator(
57 57
                         [
58
-                            $this->realPath(__DIR__ . '/../../asset/located-sources/composer-definition-with-everything/foo0'),
59
-                            $this->realPath(__DIR__ . '/../../asset/located-sources/composer-definition-with-everything/bar4'),
60
-                            $this->realPath(__DIR__ . '/../../asset/located-sources/composer-definition-with-everything/baz4_0'),
61
-                            $this->realPath(__DIR__ . '/../../asset/located-sources/composer-definition-with-everything/baz4_1'),
62
-                            $this->realPath(__DIR__ . '/../../asset/located-sources/composer-definition-with-everything/baz4_2'),
63
-                            $this->realPath(__DIR__ . '/../../asset/located-sources/composer-definition-with-everything/baz4_3'),
64
-                            $this->realPath(__DIR__ . '/../../asset/located-sources/composer-definition-with-everything/classmap0'),
65
-                            $this->realPath(__DIR__ . '/../../asset/located-sources/composer-definition-with-everything/classmap1'),
58
+                            $this->realPath(__DIR__.'/../../asset/located-sources/composer-definition-with-everything/foo0'),
59
+                            $this->realPath(__DIR__.'/../../asset/located-sources/composer-definition-with-everything/bar4'),
60
+                            $this->realPath(__DIR__.'/../../asset/located-sources/composer-definition-with-everything/baz4_0'),
61
+                            $this->realPath(__DIR__.'/../../asset/located-sources/composer-definition-with-everything/baz4_1'),
62
+                            $this->realPath(__DIR__.'/../../asset/located-sources/composer-definition-with-everything/baz4_2'),
63
+                            $this->realPath(__DIR__.'/../../asset/located-sources/composer-definition-with-everything/baz4_3'),
64
+                            $this->realPath(__DIR__.'/../../asset/located-sources/composer-definition-with-everything/classmap0'),
65
+                            $this->realPath(__DIR__.'/../../asset/located-sources/composer-definition-with-everything/classmap1'),
66 66
                         ],
67 67
                         $this->astLocator()
68 68
                     ),
69 69
                     new SingleFileSourceLocator(
70
-                        $this->realPath(__DIR__ . '/../../asset/located-sources/composer-definition-with-everything/classmap2/file.php'),
70
+                        $this->realPath(__DIR__.'/../../asset/located-sources/composer-definition-with-everything/classmap2/file.php'),
71 71
                         $this->astLocator()
72 72
                     ),
73 73
                     new SingleFileSourceLocator(
74
-                        $this->realPath(__DIR__ . '/../../asset/located-sources/composer-definition-with-everything/files/foo.php'),
74
+                        $this->realPath(__DIR__.'/../../asset/located-sources/composer-definition-with-everything/files/foo.php'),
75 75
                         $this->astLocator()
76 76
                     ),
77 77
                     new SingleFileSourceLocator(
78
-                        $this->realPath(__DIR__ . '/../../asset/located-sources/composer-definition-with-everything/files/bar.php'),
78
+                        $this->realPath(__DIR__.'/../../asset/located-sources/composer-definition-with-everything/files/bar.php'),
79 79
                         $this->astLocator()
80 80
                     ),
81 81
                 ]),
Please login to merge, or discard this patch.