AncestorRemovedTest::classesToBeTested() - Code Metrics - Inspection of "Added BC checkers to verify that no ancestors of a..." - Roave/BackwardCompatibilityCheck - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#109)

by Marco

created 2018-09-02 19:00 UTC

AncestorRemovedTest::classesToBeTested() A

↳ Parent: AncestorRemovedTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	95
Code Lines	42

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	42
nc	1
nop	0
dl	0
loc	95
rs	9.248
c	0
b	0
f	0

How to fix Long Method

<?php

declare(strict_types=1);

namespace RoaveTest\BackwardCompatibility\DetectChanges\BCBreak\ClassBased;

use PHPUnit\Framework\TestCase;
use Roave\BackwardCompatibility\Change;
use Roave\BackwardCompatibility\DetectChanges\BCBreak\ClassBased\AncestorRemoved;
use Roave\BetterReflection\BetterReflection;
use Roave\BetterReflection\Reflection\ReflectionClass;
use Roave\BetterReflection\Reflector\ClassReflector;
use Roave\BetterReflection\SourceLocator\Type\StringSourceLocator;
use function array_combine;
use function array_keys;
use function array_map;
use function iterator_to_array;

/**
 * @covers \Roave\BackwardCompatibility\DetectChanges\BCBreak\ClassBased\AncestorRemoved
 */
final class AncestorRemovedTest extends TestCase
{
    /**
     * @dataProvider classesToBeTested
     *
     * @param string[] $expectedMessages
     */
    public function testDiffs(
        ReflectionClass $fromClass,
        ReflectionClass $toClass,
        array $expectedMessages
    ) : void {
        $changes = (new AncestorRemoved())
            ->__invoke($fromClass, $toClass);

        self::assertSame(
            $expectedMessages,
            array_map(function (Change $change) : string {
                return $change->__toString();
            }, iterator_to_array($changes))
        );
    }

    /** @return (string[]|ReflectionClass)[][] */
    public function classesToBeTested() : array
    {
        $locator       = (new BetterReflection())->astLocator();
        $fromReflector = new ClassReflector(new StringSourceLocator(
            <<<'PHP'
<?php

class A {}
class B extends A {}
class C extends A {}
class D extends C {}
interface IA {}
interface IB extends IA {}
interface IC extends IA {}
interface ID extends IB, IE {}
interface IE {}
interface IG {}
class ClassWithNoAncestors {}
class ClassWithAddedAncestors {}
class ClassWithAddedInterface {}
class ClassWithRemovedAncestor extends A {}
class ClassWithRemovedIndirectAncestor extends B {}
class ClassWithRemovedVeryIndirectAncestor extends D {}
class ClassWithRemovedInterface implements IA {}
class ClassWithRemovedIndirectInterface implements IB {}
class ClassWithRemovedVeryIndirectInterface implements ID {}
class ClassWithInvertedInterfaceNames implements IE, IG {}
PHP
            ,
            $locator
        ));
        $toReflector   = new ClassReflector(new StringSourceLocator(
            <<<'PHP'
<?php

class A {}
class B {}
class C {}
class D extends C {}
interface IA {}
interface IB {}
interface IC extends IA {}
interface ID extends IB, IE {}
interface IE {}
interface IG {}
class ClassWithNoAncestors {}
class ClassWithAddedAncestors extends A {}
class ClassWithAddedInterface implements IA {}
class ClassWithRemovedAncestor {}
class ClassWithRemovedIndirectAncestor extends B {}
class ClassWithRemovedVeryIndirectAncestor extends D {}
class ClassWithRemovedInterface {}
class ClassWithRemovedIndirectInterface implements IB {}
class ClassWithRemovedVeryIndirectInterface implements ID {}
class ClassWithInvertedInterfaceNames implements IG, IE {}
PHP
            ,
            $locator
        ));

        $classes = [
            'A' => [],
            'B' => ['[BC] REMOVED: These ancestors of B have been removed: ["A"]'],
            'C' => ['[BC] REMOVED: These ancestors of C have been removed: ["A"]'],
            'D' => ['[BC] REMOVED: These ancestors of D have been removed: ["A"]'],
            'IA' => [],
            'IB' => ['[BC] REMOVED: These ancestors of IB have been removed: ["IA"]'],
            'IC' => [],
            'ID' => ['[BC] REMOVED: These ancestors of ID have been removed: ["IA"]'],
            'IE' => [],
            'IG' => [],
            'ClassWithNoAncestors' => [],
            'ClassWithAddedAncestors' => [],
            'ClassWithAddedInterface' => [],
            'ClassWithRemovedAncestor' => ['[BC] REMOVED: These ancestors of ClassWithRemovedAncestor have been removed: ["A"]'],
            'ClassWithRemovedIndirectAncestor' => ['[BC] REMOVED: These ancestors of ClassWithRemovedIndirectAncestor have been removed: ["A"]'],
            'ClassWithRemovedVeryIndirectAncestor' => ['[BC] REMOVED: These ancestors of ClassWithRemovedVeryIndirectAncestor have been removed: ["A"]'],
            'ClassWithRemovedInterface' => ['[BC] REMOVED: These ancestors of ClassWithRemovedInterface have been removed: ["IA"]'],
            'ClassWithRemovedIndirectInterface' => ['[BC] REMOVED: These ancestors of ClassWithRemovedIndirectInterface have been removed: ["IA"]'],
            'ClassWithRemovedVeryIndirectInterface' => ['[BC] REMOVED: These ancestors of ClassWithRemovedVeryIndirectInterface have been removed: ["IA"]'],
            'ClassWithInvertedInterfaceNames' => [],
        ];

        return array_combine(
            array_keys($classes),
            array_map(
                function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
                    return [
                        $fromReflector->reflect($className),
                        $toReflector->reflect($className),
                        $errors,
                    ];
                },
                array_keys($classes),
                $classes
            )
        );
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace RoaveTest\BackwardCompatibility\DetectChanges\BCBreak\ClassBased;
6
7			use PHPUnit\Framework\TestCase;
8			use Roave\BackwardCompatibility\Change;
9			use Roave\BackwardCompatibility\DetectChanges\BCBreak\ClassBased\AncestorRemoved;
10			use Roave\BetterReflection\BetterReflection;
11			use Roave\BetterReflection\Reflection\ReflectionClass;
12			use Roave\BetterReflection\Reflector\ClassReflector;
13			use Roave\BetterReflection\SourceLocator\Type\StringSourceLocator;
14			use function array_combine;
15			use function array_keys;
16			use function array_map;
17			use function iterator_to_array;
18
19			/**
20			* @covers \Roave\BackwardCompatibility\DetectChanges\BCBreak\ClassBased\AncestorRemoved
21			*/
22			final class AncestorRemovedTest extends TestCase
23			{
24			/**
25			* @dataProvider classesToBeTested
26			*
27			* @param string[] $expectedMessages
28			*/
29			public function testDiffs(
30			ReflectionClass $fromClass,
31			ReflectionClass $toClass,
32			array $expectedMessages
33			) : void {
34			$changes = (new AncestorRemoved())
35			->__invoke($fromClass, $toClass);
36
37			self::assertSame(
38			$expectedMessages,
39			array_map(function (Change $change) : string {
40			return $change->__toString();
41			}, iterator_to_array($changes))
42			);
43			}
44
45			/** @return (string[]\|ReflectionClass)[][] */
46			public function classesToBeTested() : array
47			{
48			$locator = (new BetterReflection())->astLocator();
49			$fromReflector = new ClassReflector(new StringSourceLocator(
50			<<<'PHP'
51			<?php
52
53			class A {}
54			class B extends A {}
55			class C extends A {}
56			class D extends C {}
57			interface IA {}
58			interface IB extends IA {}
59			interface IC extends IA {}
60			interface ID extends IB, IE {}
61			interface IE {}
62			interface IG {}
63			class ClassWithNoAncestors {}
64			class ClassWithAddedAncestors {}
65			class ClassWithAddedInterface {}
66			class ClassWithRemovedAncestor extends A {}
67			class ClassWithRemovedIndirectAncestor extends B {}
68			class ClassWithRemovedVeryIndirectAncestor extends D {}
69			class ClassWithRemovedInterface implements IA {}
70			class ClassWithRemovedIndirectInterface implements IB {}
71			class ClassWithRemovedVeryIndirectInterface implements ID {}
72			class ClassWithInvertedInterfaceNames implements IE, IG {}
73			PHP
74			,
75			$locator
76			));
77			$toReflector = new ClassReflector(new StringSourceLocator(
78			<<<'PHP'
79			<?php
80
81			class A {}
82			class B {}
83			class C {}
84			class D extends C {}
85			interface IA {}
86			interface IB {}
87			interface IC extends IA {}
88			interface ID extends IB, IE {}
89			interface IE {}
90			interface IG {}
91			class ClassWithNoAncestors {}
92			class ClassWithAddedAncestors extends A {}
93			class ClassWithAddedInterface implements IA {}
94			class ClassWithRemovedAncestor {}
95			class ClassWithRemovedIndirectAncestor extends B {}
96			class ClassWithRemovedVeryIndirectAncestor extends D {}
97			class ClassWithRemovedInterface {}
98			class ClassWithRemovedIndirectInterface implements IB {}
99			class ClassWithRemovedVeryIndirectInterface implements ID {}
100			class ClassWithInvertedInterfaceNames implements IG, IE {}
101			PHP
102			,
103			$locator
104			));
105
106			$classes = [
107			'A' => [],
108			'B' => ['[BC] REMOVED: These ancestors of B have been removed: ["A"]'],
109			'C' => ['[BC] REMOVED: These ancestors of C have been removed: ["A"]'],
110			'D' => ['[BC] REMOVED: These ancestors of D have been removed: ["A"]'],
111			'IA' => [],
112			'IB' => ['[BC] REMOVED: These ancestors of IB have been removed: ["IA"]'],
113			'IC' => [],
114			'ID' => ['[BC] REMOVED: These ancestors of ID have been removed: ["IA"]'],
115			'IE' => [],
116			'IG' => [],
117			'ClassWithNoAncestors' => [],
118			'ClassWithAddedAncestors' => [],
119			'ClassWithAddedInterface' => [],
120			'ClassWithRemovedAncestor' => ['[BC] REMOVED: These ancestors of ClassWithRemovedAncestor have been removed: ["A"]'],
121			'ClassWithRemovedIndirectAncestor' => ['[BC] REMOVED: These ancestors of ClassWithRemovedIndirectAncestor have been removed: ["A"]'],
122			'ClassWithRemovedVeryIndirectAncestor' => ['[BC] REMOVED: These ancestors of ClassWithRemovedVeryIndirectAncestor have been removed: ["A"]'],
123			'ClassWithRemovedInterface' => ['[BC] REMOVED: These ancestors of ClassWithRemovedInterface have been removed: ["IA"]'],
124			'ClassWithRemovedIndirectInterface' => ['[BC] REMOVED: These ancestors of ClassWithRemovedIndirectInterface have been removed: ["IA"]'],
125			'ClassWithRemovedVeryIndirectInterface' => ['[BC] REMOVED: These ancestors of ClassWithRemovedVeryIndirectInterface have been removed: ["IA"]'],
126			'ClassWithInvertedInterfaceNames' => [],
127			];
128
129			return array_combine(
130			array_keys($classes),
131			array_map(
132			function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
133			return [
134			$fromReflector->reflect($className),
135			$toReflector->reflect($className),
136			$errors,
137			];
138			},
139			array_keys($classes),
140			$classes
141			)
142			);
143			}
144			}
145

Roave / BackwardCompatibilityCheck

Pull Request — master (#109)

AncestorRemovedTest::classesToBeTested() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like