Inspection of "#98 remove `StubClassSourceLocator` from default s..." - Roave/BackwardCompatibilityCheck - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#100)

by Marco

created 2018-08-21 17:46 UTC

Status

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -34,7 +34,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(function (Change $change) : string {
+            array_map(function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($properties),
             array_map(
-                function (string $constant, array $errorMessages) use ($fromClass, $toClass) : array {
+                function(string $constant, array $errorMessages) use ($fromClass, $toClass) : array {
                     return [
                         $fromClass->getReflectionConstant($constant),
                         $toClass->getReflectionConstant($constant),

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/ClassBased/ClassBecameFinalTest.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -31,7 +31,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(function (Change $change) : string {
+            array_map(function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
             ,
             $locator
         ));
-        $toReflector   = new ClassReflector(new StringSourceLocator(
+        $toReflector = new ClassReflector(new StringSourceLocator(
             <<<'PHP'
 <?php
 

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/ClassBased/ConstantRemovedTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -29,7 +29,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(function (Change $change) : string {
+            array_map(function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -43,11 +43,11 @@  discard block
 block discarded – undo
         return [
             'RoaveTestAsset\\ClassWithConstantsBeingRemoved' => [
                 (new ClassReflector(new SingleFileSourceLocator(
-                    __DIR__ . '/../../../../asset/api/old/ClassWithConstantsBeingRemoved.php',
+                    __DIR__.'/../../../../asset/api/old/ClassWithConstantsBeingRemoved.php',
                     $locator
                 )))->reflect('RoaveTestAsset\\ClassWithConstantsBeingRemoved'),
                 (new ClassReflector(new SingleFileSourceLocator(
-                    __DIR__ . '/../../../../asset/api/new/ClassWithConstantsBeingRemoved.php',
+                    __DIR__.'/../../../../asset/api/new/ClassWithConstantsBeingRemoved.php',
                     $locator
                 )))->reflect('RoaveTestAsset\\ClassWithConstantsBeingRemoved'),
                 [

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/ClassBased/PropertyRemovedTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -31,7 +31,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(function (Change $change) : string {
+            array_map(function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -45,11 +45,11 @@  discard block
 block discarded – undo
         return [
             'RoaveTestAsset\\ClassWithPropertiesBeingRemoved' => [
                 (new ClassReflector(new SingleFileSourceLocator(
-                    __DIR__ . '/../../../../asset/api/old/ClassWithPropertiesBeingRemoved.php',
+                    __DIR__.'/../../../../asset/api/old/ClassWithPropertiesBeingRemoved.php',
                     $locator
                 )))->reflect('RoaveTestAsset\\ClassWithPropertiesBeingRemoved'),
                 (new ClassReflector(new SingleFileSourceLocator(
-                    __DIR__ . '/../../../../asset/api/new/ClassWithPropertiesBeingRemoved.php',
+                    __DIR__.'/../../../../asset/api/new/ClassWithPropertiesBeingRemoved.php',
                     $locator
                 )))->reflect('RoaveTestAsset\\ClassWithPropertiesBeingRemoved'),
                 [

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/ClassBased/MethodRemovedTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -31,7 +31,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(function (Change $change) : string {
+            array_map(function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -45,11 +45,11 @@  discard block
 block discarded – undo
         return [
             'RoaveTestAsset\\ClassWithMethodsBeingRemoved' => [
                 (new ClassReflector(new SingleFileSourceLocator(
-                    __DIR__ . '/../../../../asset/api/old/ClassWithMethodsBeingRemoved.php',
+                    __DIR__.'/../../../../asset/api/old/ClassWithMethodsBeingRemoved.php',
                     $locator
                 )))->reflect('RoaveTestAsset\\ClassWithMethodsBeingRemoved'),
                 (new ClassReflector(new SingleFileSourceLocator(
-                    __DIR__ . '/../../../../asset/api/new/ClassWithMethodsBeingRemoved.php',
+                    __DIR__.'/../../../../asset/api/new/ClassWithMethodsBeingRemoved.php',
                     $locator
                 )))->reflect('RoaveTestAsset\\ClassWithMethodsBeingRemoved'),
                 [

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/ClassBased/ConstantChangedTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -60,7 +60,7 @@
 block discarded – undo
         $comparator
             ->expects(self::exactly(2))
             ->method('__invoke')
-            ->willReturnCallback(function (ReflectionClassConstant $from, ReflectionClassConstant $to) : Changes {
+            ->willReturnCallback(function(ReflectionClassConstant $from, ReflectionClassConstant $to) : Changes {
                 $propertyName = $from->getName();
 
                 self::assertSame($propertyName, $to->getName());

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/ClassBased/PropertyChangedTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -60,7 +60,7 @@
 block discarded – undo
         $comparator
             ->expects(self::exactly(2))
             ->method('__invoke')
-            ->willReturnCallback(function (ReflectionProperty $from, ReflectionProperty $to) : Changes {
+            ->willReturnCallback(function(ReflectionProperty $from, ReflectionProperty $to) : Changes {
                 $propertyName = $from->getName();
 
                 self::assertSame($propertyName, $to->getName());

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/ClassBased/ClassBecameAbstractTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(function (Change $change) : string {
+            array_map(function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
             ,
             $locator
         ));
-        $toReflector   = new ClassReflector(new StringSourceLocator(
+        $toReflector = new ClassReflector(new StringSourceLocator(
             <<<'PHP'
 <?php
 
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($classes),
             array_map(
-                function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
+                function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
                     return [
                         $fromReflector->reflect($className),
                         $toReflector->reflect($className),

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/ClassBased/ClassBecameInterfaceTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(function (Change $change) : string {
+            array_map(function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
             ,
             $locator
         ));
-        $toReflector   = new ClassReflector(new StringSourceLocator(
+        $toReflector = new ClassReflector(new StringSourceLocator(
             <<<'PHP'
 <?php
 
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($classes),
             array_map(
-                function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
+                function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
                     return [
                         $fromReflector->reflect($className),
                         $toReflector->reflect($className),

Please login to merge, or discard this patch.

		@@ -34,7 +34,7 @@ discard block
		block discarded – undo
34	34
35	35	self::assertSame(
36	36	$expectedMessages,
37		- array_map(function (Change $change) : string {
	37	+ array_map(function(Change $change) : string {
38	38	return $change->__toString();
39	39	}, iterator_to_array($changes))
40	40	);
		@@ -112,7 +112,7 @@ discard block
		block discarded – undo
112	112	return array_combine(
113	113	array_keys($properties),
114	114	array_map(
115		- function (string $constant, array $errorMessages) use ($fromClass, $toClass) : array {
	115	+ function(string $constant, array $errorMessages) use ($fromClass, $toClass) : array {
116	116	return [
117	117	$fromClass->getReflectionConstant($constant),
118	118	$toClass->getReflectionConstant($constant),

		@@ -31,7 +31,7 @@ discard block
		block discarded – undo
31	31
32	32	self::assertSame(
33	33	$expectedMessages,
34		- array_map(function (Change $change) : string {
	34	+ array_map(function(Change $change) : string {
35	35	return $change->__toString();
36	36	}, iterator_to_array($changes))
37	37	);
		@@ -53,7 +53,7 @@ discard block
		block discarded – undo
53	53	,
54	54	$locator
55	55	));
56		- $toReflector = new ClassReflector(new StringSourceLocator(
	56	+ $toReflector = new ClassReflector(new StringSourceLocator(
57	57	<<<'PHP'
58	58	<?php
59	59

		@@ -29,7 +29,7 @@ discard block
		block discarded – undo
29	29
30	30	self::assertSame(
31	31	$expectedMessages,
32		- array_map(function (Change $change) : string {
	32	+ array_map(function(Change $change) : string {
33	33	return $change->__toString();
34	34	}, iterator_to_array($changes))
35	35	);
		@@ -43,11 +43,11 @@ discard block
		block discarded – undo
43	43	return [
44	44	'RoaveTestAsset\\ClassWithConstantsBeingRemoved' => [
45	45	(new ClassReflector(new SingleFileSourceLocator(
46		- __DIR__ . '/../../../../asset/api/old/ClassWithConstantsBeingRemoved.php',
	46	+ __DIR__.'/../../../../asset/api/old/ClassWithConstantsBeingRemoved.php',
47	47	$locator
48	48	)))->reflect('RoaveTestAsset\\ClassWithConstantsBeingRemoved'),
49	49	(new ClassReflector(new SingleFileSourceLocator(
50		- __DIR__ . '/../../../../asset/api/new/ClassWithConstantsBeingRemoved.php',
	50	+ __DIR__.'/../../../../asset/api/new/ClassWithConstantsBeingRemoved.php',
51	51	$locator
52	52	)))->reflect('RoaveTestAsset\\ClassWithConstantsBeingRemoved'),
53	53	[

		@@ -60,7 +60,7 @@
		block discarded – undo
60	60	$comparator
61	61	->expects(self::exactly(2))
62	62	->method('__invoke')
63		- ->willReturnCallback(function (ReflectionClassConstant $from, ReflectionClassConstant $to) : Changes {
	63	+ ->willReturnCallback(function(ReflectionClassConstant $from, ReflectionClassConstant $to) : Changes {
64	64	$propertyName = $from->getName();
65	65
66	66	self::assertSame($propertyName, $to->getName());

		@@ -33,7 +33,7 @@ discard block
		block discarded – undo
33	33
34	34	self::assertSame(
35	35	$expectedMessages,
36		- array_map(function (Change $change) : string {
	36	+ array_map(function(Change $change) : string {
37	37	return $change->__toString();
38	38	}, iterator_to_array($changes))
39	39	);
		@@ -63,7 +63,7 @@ discard block
		block discarded – undo
63	63	,
64	64	$locator
65	65	));
66		- $toReflector = new ClassReflector(new StringSourceLocator(
	66	+ $toReflector = new ClassReflector(new StringSourceLocator(
67	67	<<<'PHP'
68	68	<?php
69	69
		@@ -102,7 +102,7 @@ discard block
		block discarded – undo
102	102	return array_combine(
103	103	array_keys($classes),
104	104	array_map(
105		- function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
	105	+ function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
106	106	return [
107	107	$fromReflector->reflect($className),
108	108	$toReflector->reflect($className),

Roave / BackwardCompatibilityCheck

Pull Request — master (#100)

Status

Category

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch