Inspection of "Merge pull request #120 from Roave/feature/experim..." - Roave/BackwardCompatibilityCheck - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0e78db...3af8bc )

by Marco

created 2019-04-23 11:58 UTC

Status

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -50,7 +50,7 @@  discard block
 block discarded – undo
         $this->originalCwd       = $originalCwd;
         $this->composerInstaller = $this->createMock(Installer::class);
         $this->astLocator        = (new BetterReflection())->astLocator();
-        $this->makeInstaller     = function (string $installationPath) : Installer {
+        $this->makeInstaller     = function(string $installationPath) : Installer {
             self::assertSame($this->expectedInstallatonPath, $installationPath);
 
             return $this->composerInstaller;
@@ -89,13 +89,13 @@  discard block
 block discarded – undo
 
     public function testWillLocateDependencies() : void
     {
-        $this->expectedInstallatonPath = $this->realpath(__DIR__ . '/../../asset/composer-installation-structure');
+        $this->expectedInstallatonPath = $this->realpath(__DIR__.'/../../asset/composer-installation-structure');
 
         $this
             ->composerInstaller
             ->expects(self::once())
             ->method('run')
-            ->willReturnCallback(function () : void {
+            ->willReturnCallback(function() : void {
                 self::assertSame($this->expectedInstallatonPath, getcwd());
             });
 

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/PropertyBased/PropertyScopeChangedTest.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -36,7 +36,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(static function (Change $change) : string {
+            array_map(static function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($properties),
             array_map(
-                static function (string $property, array $errorMessages) use ($fromClass, $toClass) : array {
+                static function(string $property, array $errorMessages) use ($fromClass, $toClass) : array {
                     return [
                         $fromClass->getProperty($property),
                         $toClass->getProperty($property),

Please login to merge, or discard this patch.

DetectChanges/BCBreak/PropertyBased/PropertyDefaultValueChangedTest.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -36,7 +36,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(static function (Change $change) : string {
+            array_map(static function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($properties),
             array_map(
-                static function (string $property, array $errorMessages) use ($fromClass, $toClass) : array {
+                static function(string $property, array $errorMessages) use ($fromClass, $toClass) : array {
                     return [
                         $fromClass->getProperty($property),
                         $toClass->getProperty($property),

Please login to merge, or discard this patch.

DetectChanges/BCBreak/PropertyBased/PropertyDocumentedTypeChangedTest.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -36,7 +36,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(static function (Change $change) : string {
+            array_map(static function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($properties),
             array_map(
-                static function (string $property, array $errorMessages) use ($fromClass, $toClass) : array {
+                static function(string $property, array $errorMessages) use ($fromClass, $toClass) : array {
                     return [
                         $fromClass->getProperty($property),
                         $toClass->getProperty($property),

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/ClassBased/ClassBecameTraitTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(static function (Change $change) : string {
+            array_map(static function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
             ,
             $locator
         ));
-        $toReflector   = new ClassReflector(new StringSourceLocator(
+        $toReflector = new ClassReflector(new StringSourceLocator(
             <<<'PHP'
 <?php
 
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($classes),
             array_map(
-                static function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
+                static function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
                     return [
                         $fromReflector->reflect($className),
                         $toReflector->reflect($className),

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/ClassBased/ClassBecameAbstractTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(static function (Change $change) : string {
+            array_map(static function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
             ,
             $locator
         ));
-        $toReflector   = new ClassReflector(new StringSourceLocator(
+        $toReflector = new ClassReflector(new StringSourceLocator(
             <<<'PHP'
 <?php
 
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($classes),
             array_map(
-                static function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
+                static function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
                     return [
                         $fromReflector->reflect($className),
                         $toReflector->reflect($className),

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/ClassBased/AncestorRemovedTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(static function (Change $change) : string {
+            array_map(static function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
             ,
             $locator
         ));
-        $toReflector   = new ClassReflector(new StringSourceLocator(
+        $toReflector = new ClassReflector(new StringSourceLocator(
             <<<'PHP'
 <?php
 
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($classes),
             array_map(
-                static function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
+                static function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
                     return [
                         $fromReflector->reflect($className),
                         $toReflector->reflect($className),

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/InterfaceBased/InterfaceBecameClassTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(static function (Change $change) : string {
+            array_map(static function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
             ,
             $locator
         ));
-        $toReflector   = new ClassReflector(new StringSourceLocator(
+        $toReflector = new ClassReflector(new StringSourceLocator(
             <<<'PHP'
 <?php
 
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($classes),
             array_map(
-                static function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
+                static function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
                     return [
                         $fromReflector->reflect($className),
                         $toReflector->reflect($className),

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/InterfaceBased/InterfaceBecameTraitTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(static function (Change $change) : string {
+            array_map(static function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
             ,
             $locator
         ));
-        $toReflector   = new ClassReflector(new StringSourceLocator(
+        $toReflector = new ClassReflector(new StringSourceLocator(
             <<<'PHP'
 <?php
 
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($classes),
             array_map(
-                static function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
+                static function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
                     return [
                         $fromReflector->reflect($className),
                         $toReflector->reflect($className),

Please login to merge, or discard this patch.

		@@ -50,7 +50,7 @@ discard block
		block discarded – undo
50	50	$this->originalCwd = $originalCwd;
51	51	$this->composerInstaller = $this->createMock(Installer::class);
52	52	$this->astLocator = (new BetterReflection())->astLocator();
53		- $this->makeInstaller = function (string $installationPath) : Installer {
	53	+ $this->makeInstaller = function(string $installationPath) : Installer {
54	54	self::assertSame($this->expectedInstallatonPath, $installationPath);
55	55
56	56	return $this->composerInstaller;
		@@ -89,13 +89,13 @@ discard block
		block discarded – undo
89	89
90	90	public function testWillLocateDependencies() : void
91	91	{
92		- $this->expectedInstallatonPath = $this->realpath(__DIR__ . '/../../asset/composer-installation-structure');
	92	+ $this->expectedInstallatonPath = $this->realpath(__DIR__.'/../../asset/composer-installation-structure');
93	93
94	94	$this
95	95	->composerInstaller
96	96	->expects(self::once())
97	97	->method('run')
98		- ->willReturnCallback(function () : void {
	98	+ ->willReturnCallback(function() : void {
99	99	self::assertSame($this->expectedInstallatonPath, getcwd());
100	100	});
101	101

		@@ -36,7 +36,7 @@ discard block
		block discarded – undo
36	36
37	37	self::assertSame(
38	38	$expectedMessages,
39		- array_map(static function (Change $change) : string {
	39	+ array_map(static function(Change $change) : string {
40	40	return $change->__toString();
41	41	}, iterator_to_array($changes))
42	42	);
		@@ -108,7 +108,7 @@ discard block
		block discarded – undo
108	108	return array_combine(
109	109	array_keys($properties),
110	110	array_map(
111		- static function (string $property, array $errorMessages) use ($fromClass, $toClass) : array {
	111	+ static function(string $property, array $errorMessages) use ($fromClass, $toClass) : array {
112	112	return [
113	113	$fromClass->getProperty($property),
114	114	$toClass->getProperty($property),

		@@ -36,7 +36,7 @@ discard block
		block discarded – undo
36	36
37	37	self::assertSame(
38	38	$expectedMessages,
39		- array_map(static function (Change $change) : string {
	39	+ array_map(static function(Change $change) : string {
40	40	return $change->__toString();
41	41	}, iterator_to_array($changes))
42	42	);
		@@ -108,7 +108,7 @@ discard block
		block discarded – undo
108	108	return array_combine(
109	109	array_keys($properties),
110	110	array_map(
111		- static function (string $property, array $errorMessages) use ($fromClass, $toClass) : array {
	111	+ static function(string $property, array $errorMessages) use ($fromClass, $toClass) : array {
112	112	return [
113	113	$fromClass->getProperty($property),
114	114	$toClass->getProperty($property),

		@@ -36,7 +36,7 @@ discard block
		block discarded – undo
36	36
37	37	self::assertSame(
38	38	$expectedMessages,
39		- array_map(static function (Change $change) : string {
	39	+ array_map(static function(Change $change) : string {
40	40	return $change->__toString();
41	41	}, iterator_to_array($changes))
42	42	);
		@@ -108,7 +108,7 @@ discard block
		block discarded – undo
108	108	return array_combine(
109	109	array_keys($properties),
110	110	array_map(
111		- static function (string $property, array $errorMessages) use ($fromClass, $toClass) : array {
	111	+ static function(string $property, array $errorMessages) use ($fromClass, $toClass) : array {
112	112	return [
113	113	$fromClass->getProperty($property),
114	114	$toClass->getProperty($property),

		@@ -33,7 +33,7 @@ discard block
		block discarded – undo
33	33
34	34	self::assertSame(
35	35	$expectedMessages,
36		- array_map(static function (Change $change) : string {
	36	+ array_map(static function(Change $change) : string {
37	37	return $change->__toString();
38	38	}, iterator_to_array($changes))
39	39	);
		@@ -63,7 +63,7 @@ discard block
		block discarded – undo
63	63	,
64	64	$locator
65	65	));
66		- $toReflector = new ClassReflector(new StringSourceLocator(
	66	+ $toReflector = new ClassReflector(new StringSourceLocator(
67	67	<<<'PHP'
68	68	<?php
69	69
		@@ -102,7 +102,7 @@ discard block
		block discarded – undo
102	102	return array_combine(
103	103	array_keys($classes),
104	104	array_map(
105		- static function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
	105	+ static function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
106	106	return [
107	107	$fromReflector->reflect($className),
108	108	$toReflector->reflect($className),

Roave / BackwardCompatibilityCheck

Push — master ( 0e78db...3af8bc )

Status

Category

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch