Completed
Pull Request — master (#38)
by Marco
03:08
created
src/Comparator/Variance/TypeIsContravariant.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Roave\ApiCompare\Comparator\Variance;
6 6
 
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
             return false;
33 33
         }
34 34
 
35
-        if ($type->allowsNull() && ! $comparedType->allowsNull()) {
35
+        if ($type->allowsNull() && !$comparedType->allowsNull()) {
36 36
             return false;
37 37
         }
38 38
 
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
             return true;
49 49
         }
50 50
 
51
-        if (strtolower($comparedTypeAsString) === 'object' && ! $type->isBuiltin()) {
51
+        if (strtolower($comparedTypeAsString) === 'object' && !$type->isBuiltin()) {
52 52
             // `object` is always contravariant to any object type
53 53
             return true;
54 54
         }
Please login to merge, or discard this patch.
test/unit/Comparator/Variance/TypeIsCovariantTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace RoaveTest\ApiCompare\Comparator\BackwardsCompatibility\ClassBased;
6 6
 
@@ -211,7 +211,7 @@  discard block
 block discarded – undo
211 211
         return array_merge(
212 212
             [[null]],
213 213
             array_merge(...array_map(
214
-                function (string $type) use ($reflector) : array {
214
+                function(string $type) use ($reflector) : array {
215 215
                     return [
216 216
                         [ReflectionType::createFromTypeAndReflector($type, false, $reflector)],
217 217
                         [ReflectionType::createFromTypeAndReflector($type, true, $reflector)],
Please login to merge, or discard this patch.
BackwardsCompatibility/ClassConstantBased/ConstantVisibilityReducedTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace RoaveTest\ApiCompare\Comparator\BackwardsCompatibility\ClassConstantBased;
6 6
 
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
 
35 35
         self::assertSame(
36 36
             $expectedMessages,
37
-            array_map(function (Change $change) : string {
37
+            array_map(function(Change $change) : string {
38 38
                 return $change->__toString();
39 39
             }, iterator_to_array($changes))
40 40
         );
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
         return array_combine(
113 113
             array_keys($properties),
114 114
             array_map(
115
-                function (string $constant, array $errorMessages) use ($fromClass, $toClass) : array {
115
+                function(string $constant, array $errorMessages) use ($fromClass, $toClass) : array {
116 116
                     return [
117 117
                         $fromClass->getReflectionConstant($constant),
118 118
                         $toClass->getReflectionConstant($constant),
Please login to merge, or discard this patch.
BackwardsCompatibility/ClassConstantBased/MultiConstantBasedTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace RoaveTest\ApiCompare\Comparator\BackwardsCompatibility\ClassConstantBased;
6 6
 
Please login to merge, or discard this patch.
BackwardsCompatibility/FunctionBased/ParameterDefaultValueChangedTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace RoaveTest\ApiCompare\Comparator\BackwardsCompatibility\FunctionBased;
6 6
 
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
 
36 36
         self::assertSame(
37 37
             $expectedMessages,
38
-            array_map(function (Change $change) : string {
38
+            array_map(function(Change $change) : string {
39 39
                 return $change->__toString();
40 40
             }, iterator_to_array($changes))
41 41
         );
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
             array_combine(
117 117
                 array_keys($functions),
118 118
                 array_map(
119
-                    function (string $function, array $errorMessages) use ($fromReflector, $toReflector) : array {
119
+                    function(string $function, array $errorMessages) use ($fromReflector, $toReflector) : array {
120 120
                         return [
121 121
                             $fromReflector->reflect($function),
122 122
                             $toReflector->reflect($function),
Please login to merge, or discard this patch.
Comparator/BackwardsCompatibility/FunctionBased/MultiFunctionBasedTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace RoaveTest\ApiCompare\Comparator\BackwardsCompatibility\FunctionBased;
6 6
 
Please login to merge, or discard this patch.
unit/Comparator/BackwardsCompatibility/InterfaceBased/MethodAddedTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace RoaveTest\ApiCompare\Comparator\BackwardsCompatibility\InterfaceBased;
6 6
 
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
 
32 32
         self::assertSame(
33 33
             $expectedMessages,
34
-            array_map(function (Change $change) : string {
34
+            array_map(function(Change $change) : string {
35 35
                 return $change->__toString();
36 36
             }, iterator_to_array($changes))
37 37
         );
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
         return array_combine(
105 105
             array_keys($properties),
106 106
             array_map(
107
-                function (string $className, array $errorMessages) use ($fromClassReflector, $toClassReflector
107
+                function(string $className, array $errorMessages) use ($fromClassReflector, $toClassReflector
108 108
                 ) : array {
109 109
                     return [
110 110
                         $fromClassReflector->reflect($className),
Please login to merge, or discard this patch.
BackwardsCompatibility/PropertyBased/PropertyDefaultValueChangedTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace RoaveTest\ApiCompare\Comparator\BackwardsCompatibility\PropertyBased;
6 6
 
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
 
35 35
         self::assertSame(
36 36
             $expectedMessages,
37
-            array_map(function (Change $change) : string {
37
+            array_map(function(Change $change) : string {
38 38
                 return $change->__toString();
39 39
             }, iterator_to_array($changes))
40 40
         );
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
         return array_combine(
145 145
             array_keys($properties),
146 146
             array_map(
147
-                function (string $property, array $errorMessages) use ($fromClass, $toClass) : array {
147
+                function(string $property, array $errorMessages) use ($fromClass, $toClass) : array {
148 148
                     return [
149 149
                         $fromClass->getProperty($property),
150 150
                         $toClass->getProperty($property),
Please login to merge, or discard this patch.
Comparator/BackwardsCompatibility/PropertyBased/MultiPropertyBasedTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace RoaveTest\ApiCompare\Comparator\BackwardsCompatibility\PropertyBased;
6 6
 
Please login to merge, or discard this patch.