InterfaceBecameClassTest::classesToBeTested() - Code Metrics - Inspection of "Verify method, function, property, constant and in..." - Roave/BackwardCompatibilityCheck - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#38)

by Marco

created 2018-04-22 12:23 UTC

InterfaceBecameClassTest::classesToBeTested() A

↳ Parent: InterfaceBecameClassTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	71
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	71
rs	9.1369
c	0
b	0
f	0
cc	1
eloc	34
nc	1
nop	0

How to fix Long Method

<?php

declare(strict_types=1);

namespace RoaveTest\ApiCompare\Comparator\BackwardsCompatibility\InterfaceBased;

use PHPUnit\Framework\TestCase;
use Roave\ApiCompare\Change;
use Roave\ApiCompare\Comparator\BackwardsCompatibility\InterfaceBased\InterfaceBecameClass;
use Roave\BetterReflection\BetterReflection;
use Roave\BetterReflection\Reflection\ReflectionClass;
use Roave\BetterReflection\Reflector\ClassReflector;
use Roave\BetterReflection\SourceLocator\Type\StringSourceLocator;
use function array_combine;
use function array_keys;
use function array_map;
use function iterator_to_array;

final class InterfaceBecameClassTest extends TestCase
{
    /**
     * @dataProvider classesToBeTested
     *
     * @param string[] $expectedMessages
     */
    public function testDiffs(
        ReflectionClass $fromClass,
        ReflectionClass $toClass,
        array $expectedMessages
    ) : void {
        $changes = (new InterfaceBecameClass())
            ->compare($fromClass, $toClass);

        self::assertSame(
            $expectedMessages,
            array_map(function (Change $change) : string {
                return $change->__toString();
            }, iterator_to_array($changes))
        );
    }

    /** @return (string[]|ReflectionClass)[][] */
    public function classesToBeTested() : array
    {
        $locator       = (new BetterReflection())->astLocator();
        $fromReflector = new ClassReflector(new StringSourceLocator(
            <<<'PHP'
<?php

class ConcreteToAbstract {}
abstract class AbstractToConcrete {}
class ConcreteToConcrete {}
abstract class AbstractToAbstract {}
class ConcreteToInterface {}
interface InterfaceToConcrete {}
interface InterfaceToInterface {}
interface InterfaceToAbstract {}
abstract class AbstractToInterface {}
interface InterfaceToTrait {}
trait TraitToInterface {}
trait TraitToTrait {}
PHP
            ,
            $locator
        ));
        $toReflector   = new ClassReflector(new StringSourceLocator(
            <<<'PHP'
<?php

abstract class ConcreteToAbstract {}
class AbstractToConcrete {}
class ConcreteToConcrete {}
abstract class AbstractToAbstract {}
interface ConcreteToInterface {}
class InterfaceToConcrete {}
interface InterfaceToInterface {}
abstract class InterfaceToAbstract {}
interface AbstractToInterface {}
trait InterfaceToTrait {}
interface TraitToInterface {}
trait TraitToTrait {}
PHP
            ,
            $locator
        ));

        $classes = [
            'ConcreteToAbstract'   => [],
            'AbstractToConcrete'   => [],
            'ConcreteToConcrete'   => [],
            'AbstractToAbstract'   => [],
            'ConcreteToInterface'  => [],
            'InterfaceToConcrete'  => ['[BC] CHANGED: Interface InterfaceToConcrete became a class'],
            'InterfaceToInterface' => [],
            'InterfaceToAbstract'  => ['[BC] CHANGED: Interface InterfaceToAbstract became a class'],
            'AbstractToInterface'  => [],
            'InterfaceToTrait'     => [],
            'TraitToInterface'     => [],
            'TraitToTrait'         => [],
        ];

        return array_combine(
            array_keys($classes),
            array_map(
                function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
                    return [
                        $fromReflector->reflect($className),
                        $toReflector->reflect($className),
                        $errors,
                    ];
                },
                array_keys($classes),
                $classes
            )
        );
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace RoaveTest\ApiCompare\Comparator\BackwardsCompatibility\InterfaceBased;
6
7			use PHPUnit\Framework\TestCase;
8			use Roave\ApiCompare\Change;
9			use Roave\ApiCompare\Comparator\BackwardsCompatibility\InterfaceBased\InterfaceBecameClass;
10			use Roave\BetterReflection\BetterReflection;
11			use Roave\BetterReflection\Reflection\ReflectionClass;
12			use Roave\BetterReflection\Reflector\ClassReflector;
13			use Roave\BetterReflection\SourceLocator\Type\StringSourceLocator;
14			use function array_combine;
15			use function array_keys;
16			use function array_map;
17			use function iterator_to_array;
18
19			final class InterfaceBecameClassTest extends TestCase
20			{
21			/**
22			* @dataProvider classesToBeTested
23			*
24			* @param string[] $expectedMessages
25			*/
26			public function testDiffs(
27			ReflectionClass $fromClass,
28			ReflectionClass $toClass,
29			array $expectedMessages
30			) : void {
31			$changes = (new InterfaceBecameClass())
32			->compare($fromClass, $toClass);
33
34			self::assertSame(
35			$expectedMessages,
36			array_map(function (Change $change) : string {
37			return $change->__toString();
38			}, iterator_to_array($changes))
39			);
40			}
41
42			/** @return (string[]\|ReflectionClass)[][] */
43			public function classesToBeTested() : array
44			{
45			$locator = (new BetterReflection())->astLocator();
46			$fromReflector = new ClassReflector(new StringSourceLocator(
47			<<<'PHP'
48			<?php
49
50			class ConcreteToAbstract {}
51			abstract class AbstractToConcrete {}
52			class ConcreteToConcrete {}
53			abstract class AbstractToAbstract {}
54			class ConcreteToInterface {}
55			interface InterfaceToConcrete {}
56			interface InterfaceToInterface {}
57			interface InterfaceToAbstract {}
58			abstract class AbstractToInterface {}
59			interface InterfaceToTrait {}
60			trait TraitToInterface {}
61			trait TraitToTrait {}
62			PHP
63			,
64			$locator
65			));
66			$toReflector = new ClassReflector(new StringSourceLocator(
67			<<<'PHP'
68			<?php
69
70			abstract class ConcreteToAbstract {}
71			class AbstractToConcrete {}
72			class ConcreteToConcrete {}
73			abstract class AbstractToAbstract {}
74			interface ConcreteToInterface {}
75			class InterfaceToConcrete {}
76			interface InterfaceToInterface {}
77			abstract class InterfaceToAbstract {}
78			interface AbstractToInterface {}
79			trait InterfaceToTrait {}
80			interface TraitToInterface {}
81			trait TraitToTrait {}
82			PHP
83			,
84			$locator
85			));
86
87			$classes = [
88			'ConcreteToAbstract' => [],
89			'AbstractToConcrete' => [],
90			'ConcreteToConcrete' => [],
91			'AbstractToAbstract' => [],
92			'ConcreteToInterface' => [],
93			'InterfaceToConcrete' => ['[BC] CHANGED: Interface InterfaceToConcrete became a class'],
94			'InterfaceToInterface' => [],
95			'InterfaceToAbstract' => ['[BC] CHANGED: Interface InterfaceToAbstract became a class'],
96			'AbstractToInterface' => [],
97			'InterfaceToTrait' => [],
98			'TraitToInterface' => [],
99			'TraitToTrait' => [],
100			];
101
102			return array_combine(
103			array_keys($classes),
104			array_map(
105			function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
106			return [
107			$fromReflector->reflect($className),
108			$toReflector->reflect($className),
109			$errors,
110			];
111			},
112			array_keys($classes),
113			$classes
114			)
115			);
116			}
117			}
118

Roave / BackwardCompatibilityCheck

Pull Request — master (#38)

InterfaceBecameClassTest::classesToBeTested() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like