View GitHub Repository BackwardCompatibilityCheck

Schedule Inspection
Subscribe
Passed
Pull Request — master (#38)
by Marco
02:40
created
Status
Category
Toggle Patches
unit/Comparator/BackwardsCompatibility/ClassBased/ClassBecameFinalTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -31,7 +31,7 @@  discard block
 
 block discarded – undo
31 31
32 32 
         self::assertSame(
33 33 
             $expectedMessages,
34 
-            array_map(function (Change $change) : string {
34 
+            array_map(function(Change $change) : string {
35 35 
                 return $change->__toString();
36 36 
             }, iterator_to_array($changes))
37 37 
         );
 
@@ -53,7 +53,7 @@  discard block
 
 block discarded – undo
53 53 
             ,
54 54 
             $locator
55 55 
         ));
56 
-        $toReflector   = new ClassReflector(new StringSourceLocator(
56 
+        $toReflector = new ClassReflector(new StringSourceLocator(
57 57 
             <<<'PHP'
58 58 
 <?php
59 59
Please login to merge, or discard this patch.
unit/Comparator/BackwardsCompatibility/ClassBased/ClassBecameTraitTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -36,7 +36,7 @@  discard block
 
 block discarded – undo
36 36
37 37 
         self::assertSame(
38 38 
             $expectedMessages,
39 
-            array_map(function (Change $change) : string {
39 
+            array_map(function(Change $change) : string {
40 40 
                 return $change->__toString();
41 41 
             }, iterator_to_array($changes))
42 42 
         );
 
@@ -66,7 +66,7 @@  discard block
 
 block discarded – undo
66 66 
             ,
67 67 
             $locator
68 68 
         ));
69 
-        $toReflector   = new ClassReflector(new StringSourceLocator(
69 
+        $toReflector = new ClassReflector(new StringSourceLocator(
70 70 
             <<<'PHP'
71 71 
 <?php
72 72 
 
@@ -105,7 +105,7 @@  discard block
 
 block discarded – undo
105 105 
         return array_combine(
106 106 
             array_keys($classes),
107 107 
             array_map(
108 
-                function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
108 
+                function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
109 109 
                     return [
110 110 
                         $fromReflector->reflect($className),
111 111 
                         $toReflector->reflect($className),
Please login to merge, or discard this patch.
Comparator/BackwardsCompatibility/MethodBased/MethodScopeChangedTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -36,7 +36,7 @@  discard block
 
 block discarded – undo
36 36
37 37 
         self::assertSame(
38 38 
             $expectedMessages,
39 
-            array_map(function (Change $change) : string {
39 
+            array_map(function(Change $change) : string {
40 40 
                 return $change->__toString();
41 41 
             }, iterator_to_array($changes))
42 42 
         );
 
@@ -122,7 +122,7 @@  discard block
 
 block discarded – undo
122 122 
         return array_combine(
123 123 
             array_keys($properties),
124 124 
             array_map(
125 
-                function (string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
125 
+                function(string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
126 126 
                     return [
127 127 
                         $fromClass->getMethod($methodName),
128 128 
                         $toClass->getMethod($methodName),
Please login to merge, or discard this patch.
Comparator/BackwardsCompatibility/MethodBased/MethodBecameFinalTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -36,7 +36,7 @@  discard block
 
 block discarded – undo
36 36
37 37 
         self::assertSame(
38 38 
             $expectedMessages,
39 
-            array_map(function (Change $change) : string {
39 
+            array_map(function(Change $change) : string {
40 40 
                 return $change->__toString();
41 41 
             }, iterator_to_array($changes))
42 42 
         );
 
@@ -122,7 +122,7 @@  discard block
 
 block discarded – undo
122 122 
         return array_combine(
123 123 
             array_keys($properties),
124 124 
             array_map(
125 
-                function (string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
125 
+                function(string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
126 126 
                     return [
127 127 
                         $fromClass->getMethod($methodName),
128 128 
                         $toClass->getMethod($methodName),
Please login to merge, or discard this patch.
BackwardsCompatibility/MethodBased/MethodConcretenessChangedTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -36,7 +36,7 @@  discard block
 
 block discarded – undo
36 36
37 37 
         self::assertSame(
38 38 
             $expectedMessages,
39 
-            array_map(function (Change $change) : string {
39 
+            array_map(function(Change $change) : string {
40 40 
                 return $change->__toString();
41 41 
             }, iterator_to_array($changes))
42 42 
         );
 
@@ -122,7 +122,7 @@  discard block
 
 block discarded – undo
122 122 
         return array_combine(
123 123 
             array_keys($properties),
124 124 
             array_map(
125 
-                function (string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
125 
+                function(string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
126 126 
                     return [
127 127 
                         $fromClass->getMethod($methodName),
128 128 
                         $toClass->getMethod($methodName),
Please login to merge, or discard this patch.
BackwardsCompatibility/MethodBased/MethodVisibilityReducedTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -36,7 +36,7 @@  discard block
 
 block discarded – undo
36 36
37 37 
         self::assertSame(
38 38 
             $expectedMessages,
39 
-            array_map(function (Change $change) : string {
39 
+            array_map(function(Change $change) : string {
40 40 
                 return $change->__toString();
41 41 
             }, iterator_to_array($changes))
42 42 
         );
 
@@ -108,7 +108,7 @@  discard block
 
 block discarded – undo
108 108 
         return array_combine(
109 109 
             array_keys($properties),
110 110 
             array_map(
111 
-                function (string $method, array $errorMessages) use ($fromClass, $toClass) : array {
111 
+                function(string $method, array $errorMessages) use ($fromClass, $toClass) : array {
112 112 
                     return [
113 113 
                         $fromClass->getMethod($method),
114 114 
                         $toClass->getMethod($method),
Please login to merge, or discard this patch.
test/unit/Formatter/ReflectionPropertyNameTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -63,7 +63,7 @@
 
 block discarded – undo
63 63 
         return array_combine(
64 64 
             array_keys($properties),
65 65 
             array_map(
66 
-                function (string $expectedMessage, ReflectionProperty $property) : array {
66 
+                function(string $expectedMessage, ReflectionProperty $property) : array {
67 67 
                     return [$property, $expectedMessage];
68 68 
                 },
69 69 
                 array_keys($properties),
Please login to merge, or discard this patch.
test/unit/Formatter/MarkdownPipedToSymfonyConsoleFormatterTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -36,7 +36,7 @@
 
 block discarded – undo
36 36
37 37 
         $output->expects(self::any())
38 38 
             ->method('writeln')
39 
-            ->willReturnCallback(function (string $output) use ($changeToExpect) : void {
39 
+            ->willReturnCallback(function(string $output) use ($changeToExpect) : void {
40 40 
                 self::assertContains($changeToExpect, $output);
41 41 
             });
42 42
Please login to merge, or discard this patch.
src/Command/ApiCompare.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -113,15 +113,15 @@
 
 block discarded – undo
113 113 
         $toPath   = $this->git->checkout($sourceRepo, $toRevision);
114 114
115 115 
         try {
116 
-            $fromSources = $fromPath . '/' . $sourcesPath;
117 
-            $toSources   = $toPath . '/' . $sourcesPath;
116 
+            $fromSources = $fromPath.'/'.$sourcesPath;
117 
+            $toSources   = $toPath.'/'.$sourcesPath;
118 118
119 119 
             Assert::that($fromSources)->directory();
120 120 
             Assert::that($toSources)->directory();
121 121
122 122 
             $changes = $this->comparator->compare(
123 
-                $this->reflectorFactory->__invoke((string) $fromPath . '/' . $sourcesPath),
124 
-                $this->reflectorFactory->__invoke((string) $toPath . '/' . $sourcesPath)
123 
+                $this->reflectorFactory->__invoke((string) $fromPath.'/'.$sourcesPath),
124 
+                $this->reflectorFactory->__invoke((string) $toPath.'/'.$sourcesPath)
125 125 
             );
126 126
127 127 
             (new SymfonyConsoleTextFormatter($stdErr))->write($changes);
Please login to merge, or discard this patch.