Inspection of "Verify method, function, property, constant and in..." - Roave/BackwardCompatibilityCheck - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#38)

by Marco

created 2018-04-25 19:45 UTC

Status

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -61,7 +61,7 @@
 block discarded – undo
         $comparator
             ->expects(self::exactly(3))
             ->method('compare')
-            ->willReturnCallback(function (ReflectionMethod $from, ReflectionMethod $to) : Changes {
+            ->willReturnCallback(function(ReflectionMethod $from, ReflectionMethod $to) : Changes {
                 $methodName = $from->getName();
 
                 self::assertSame(strtolower($methodName), strtolower($to->getName()));

Please login to merge, or discard this patch.

Comparator/BackwardsCompatibility/ClassBased/ClassBecameAbstractTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(function (Change $change) : string {
+            array_map(function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
             ,
             $locator
         ));
-        $toReflector   = new ClassReflector(new StringSourceLocator(
+        $toReflector = new ClassReflector(new StringSourceLocator(
             <<<'PHP'
 <?php
 
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($classes),
             array_map(
-                function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
+                function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
                     return [
                         $fromReflector->reflect($className),
                         $toReflector->reflect($className),

Please login to merge, or discard this patch.

unit/Comparator/BackwardsCompatibility/ClassBased/ClassBecameFinalTest.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -31,7 +31,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(function (Change $change) : string {
+            array_map(function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
             ,
             $locator
         ));
-        $toReflector   = new ClassReflector(new StringSourceLocator(
+        $toReflector = new ClassReflector(new StringSourceLocator(
             <<<'PHP'
 <?php
 

Please login to merge, or discard this patch.

unit/Comparator/BackwardsCompatibility/ClassBased/ClassBecameTraitTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -36,7 +36,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(function (Change $change) : string {
+            array_map(function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
             ,
             $locator
         ));
-        $toReflector   = new ClassReflector(new StringSourceLocator(
+        $toReflector = new ClassReflector(new StringSourceLocator(
             <<<'PHP'
 <?php
 
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($classes),
             array_map(
-                function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
+                function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
                     return [
                         $fromReflector->reflect($className),
                         $toReflector->reflect($className),

Please login to merge, or discard this patch.

Comparator/BackwardsCompatibility/MethodBased/MethodScopeChangedTest.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -36,7 +36,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(function (Change $change) : string {
+            array_map(function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($properties),
             array_map(
-                function (string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
+                function(string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
                     return [
                         $fromClass->getMethod($methodName),
                         $toClass->getMethod($methodName),

Please login to merge, or discard this patch.

Comparator/BackwardsCompatibility/MethodBased/MethodBecameFinalTest.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -36,7 +36,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(function (Change $change) : string {
+            array_map(function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($properties),
             array_map(
-                function (string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
+                function(string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
                     return [
                         $fromClass->getMethod($methodName),
                         $toClass->getMethod($methodName),

Please login to merge, or discard this patch.

BackwardsCompatibility/MethodBased/MethodConcretenessChangedTest.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -36,7 +36,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(function (Change $change) : string {
+            array_map(function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($properties),
             array_map(
-                function (string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
+                function(string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
                     return [
                         $fromClass->getMethod($methodName),
                         $toClass->getMethod($methodName),

Please login to merge, or discard this patch.

BackwardsCompatibility/MethodBased/MethodVisibilityReducedTest.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -36,7 +36,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(function (Change $change) : string {
+            array_map(function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($properties),
             array_map(
-                function (string $method, array $errorMessages) use ($fromClass, $toClass) : array {
+                function(string $method, array $errorMessages) use ($fromClass, $toClass) : array {
                     return [
                         $fromClass->getMethod($method),
                         $toClass->getMethod($method),

Please login to merge, or discard this patch.

test/unit/Formatter/ReflectionPropertyNameTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -63,7 +63,7 @@
 block discarded – undo
         return array_combine(
             array_keys($properties),
             array_map(
-                function (string $expectedMessage, ReflectionProperty $property) : array {
+                function(string $expectedMessage, ReflectionProperty $property) : array {
                     return [$property, $expectedMessage];
                 },
                 array_keys($properties),

Please login to merge, or discard this patch.

		@@ -61,7 +61,7 @@
		block discarded – undo
61	61	$comparator
62	62	->expects(self::exactly(3))
63	63	->method('compare')
64		- ->willReturnCallback(function (ReflectionMethod $from, ReflectionMethod $to) : Changes {
	64	+ ->willReturnCallback(function(ReflectionMethod $from, ReflectionMethod $to) : Changes {
65	65	$methodName = $from->getName();
66	66
67	67	self::assertSame(strtolower($methodName), strtolower($to->getName()));

		@@ -33,7 +33,7 @@ discard block
		block discarded – undo
33	33
34	34	self::assertSame(
35	35	$expectedMessages,
36		- array_map(function (Change $change) : string {
	36	+ array_map(function(Change $change) : string {
37	37	return $change->__toString();
38	38	}, iterator_to_array($changes))
39	39	);
		@@ -60,7 +60,7 @@ discard block
		block discarded – undo
60	60	,
61	61	$locator
62	62	));
63		- $toReflector = new ClassReflector(new StringSourceLocator(
	63	+ $toReflector = new ClassReflector(new StringSourceLocator(
64	64	<<<'PHP'
65	65	<?php
66	66
		@@ -93,7 +93,7 @@ discard block
		block discarded – undo
93	93	return array_combine(
94	94	array_keys($classes),
95	95	array_map(
96		- function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
	96	+ function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
97	97	return [
98	98	$fromReflector->reflect($className),
99	99	$toReflector->reflect($className),

		@@ -31,7 +31,7 @@ discard block
		block discarded – undo
31	31
32	32	self::assertSame(
33	33	$expectedMessages,
34		- array_map(function (Change $change) : string {
	34	+ array_map(function(Change $change) : string {
35	35	return $change->__toString();
36	36	}, iterator_to_array($changes))
37	37	);
		@@ -53,7 +53,7 @@ discard block
		block discarded – undo
53	53	,
54	54	$locator
55	55	));
56		- $toReflector = new ClassReflector(new StringSourceLocator(
	56	+ $toReflector = new ClassReflector(new StringSourceLocator(
57	57	<<<'PHP'
58	58	<?php
59	59

		@@ -36,7 +36,7 @@ discard block
		block discarded – undo
36	36
37	37	self::assertSame(
38	38	$expectedMessages,
39		- array_map(function (Change $change) : string {
	39	+ array_map(function(Change $change) : string {
40	40	return $change->__toString();
41	41	}, iterator_to_array($changes))
42	42	);
		@@ -66,7 +66,7 @@ discard block
		block discarded – undo
66	66	,
67	67	$locator
68	68	));
69		- $toReflector = new ClassReflector(new StringSourceLocator(
	69	+ $toReflector = new ClassReflector(new StringSourceLocator(
70	70	<<<'PHP'
71	71	<?php
72	72
		@@ -105,7 +105,7 @@ discard block
		block discarded – undo
105	105	return array_combine(
106	106	array_keys($classes),
107	107	array_map(
108		- function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
	108	+ function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
109	109	return [
110	110	$fromReflector->reflect($className),
111	111	$toReflector->reflect($className),

		@@ -63,7 +63,7 @@
		block discarded – undo
63	63	return array_combine(
64	64	array_keys($properties),
65	65	array_map(
66		- function (string $expectedMessage, ReflectionProperty $property) : array {
	66	+ function(string $expectedMessage, ReflectionProperty $property) : array {
67	67	return [$property, $expectedMessage];
68	68	},
69	69	array_keys($properties),

Roave / BackwardCompatibilityCheck

Pull Request — master (#38)

Status

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch