TraitBecameClass::__invoke() - Code Metrics - Inspection of "#24 rename package to `roave/backward-compatibilit..." - Roave/BackwardCompatibilityCheck - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#50)

by Marco

created 2018-04-27 11:46 UTC

TraitBecameClass::__invoke() A

↳ Parent: TraitBecameClass

Complexity

Conditions	3
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	5
nc	2
nop	2
dl	0
loc	9
rs	9.6666
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Roave\BackwardCompatibility\DetectChanges\BCBreak\TraitBased;

use Roave\BackwardCompatibility\Change;
use Roave\BackwardCompatibility\Changes;
use Roave\BetterReflection\Reflection\ReflectionClass;
use function sprintf;

/**
 * A trait cannot change to become a class, as that forces all implementations
 * that use it to change from `use` to inheritance (if even possible)
 */
final class TraitBecameClass implements TraitBased
{
    public function __invoke(ReflectionClass $fromTrait, ReflectionClass $toTrait) : Changes
    {
        if ($this->isClass($fromTrait) || ! $this->isClass($toTrait)) {
            return Changes::empty();
        }

        return Changes::fromList(Change::changed(
            sprintf('Trait %s became a class', $fromTrait->getName()),
            true
        ));
    }

    /**
     * According to the current state of the PHP ecosystem, we only have traits, interfaces and classes
     */
    private function isClass(ReflectionClass $class) : bool
    {
        return ! ($class->isTrait() || $class->isInterface());
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Roave\BackwardCompatibility\DetectChanges\BCBreak\TraitBased;
6
7			use Roave\BackwardCompatibility\Change;
8			use Roave\BackwardCompatibility\Changes;
9			use Roave\BetterReflection\Reflection\ReflectionClass;
10			use function sprintf;
11
12			/**
13			* A trait cannot change to become a class, as that forces all implementations
14			* that use it to change from `use` to inheritance (if even possible)
15			*/
16			final class TraitBecameClass implements TraitBased
17			{
18			public function __invoke(ReflectionClass $fromTrait, ReflectionClass $toTrait) : Changes
19			{
20			if ($this->isClass($fromTrait) \|\| ! $this->isClass($toTrait)) {
21			return Changes::empty();
22			}
23
24			return Changes::fromList(Change::changed(
25			sprintf('Trait %s became a class', $fromTrait->getName()),
26			true
27			));
28			}
29
30			/**
31			* According to the current state of the PHP ecosystem, we only have traits, interfaces and classes
32			*/
33			private function isClass(ReflectionClass $class) : bool
34			{
35			return ! ($class->isTrait() \|\| $class->isInterface());
36			}
37			}
38

Roave / BackwardCompatibilityCheck

Pull Request — master (#50)

TraitBecameClass::__invoke() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like