Inspection of "#24 rename package to `roave/backward-compatibilit..." - Roave/BackwardCompatibilityCheck - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#50)

by Marco

created 2018-04-27 11:29 UTC

Status

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -31,7 +31,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(function (Change $change) : string {
+            array_map(function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -45,11 +45,11 @@  discard block
 block discarded – undo
         return [
             'RoaveTestAsset\\ClassWithPropertiesBeingRemoved' => [
                 (new ClassReflector(new SingleFileSourceLocator(
-                    __DIR__ . '/../../../../asset/api/old/ClassWithPropertiesBeingRemoved.php',
+                    __DIR__.'/../../../../asset/api/old/ClassWithPropertiesBeingRemoved.php',
                     $locator
                 )))->reflect('RoaveTestAsset\\ClassWithPropertiesBeingRemoved'),
                 (new ClassReflector(new SingleFileSourceLocator(
-                    __DIR__ . '/../../../../asset/api/new/ClassWithPropertiesBeingRemoved.php',
+                    __DIR__.'/../../../../asset/api/new/ClassWithPropertiesBeingRemoved.php',
                     $locator
                 )))->reflect('RoaveTestAsset\\ClassWithPropertiesBeingRemoved'),
                 [

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/ClassBased/MethodRemovedTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -31,7 +31,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(function (Change $change) : string {
+            array_map(function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -45,11 +45,11 @@  discard block
 block discarded – undo
         return [
             'RoaveTestAsset\\ClassWithMethodsBeingRemoved' => [
                 (new ClassReflector(new SingleFileSourceLocator(
-                    __DIR__ . '/../../../../asset/api/old/ClassWithMethodsBeingRemoved.php',
+                    __DIR__.'/../../../../asset/api/old/ClassWithMethodsBeingRemoved.php',
                     $locator
                 )))->reflect('RoaveTestAsset\\ClassWithMethodsBeingRemoved'),
                 (new ClassReflector(new SingleFileSourceLocator(
-                    __DIR__ . '/../../../../asset/api/new/ClassWithMethodsBeingRemoved.php',
+                    __DIR__.'/../../../../asset/api/new/ClassWithMethodsBeingRemoved.php',
                     $locator
                 )))->reflect('RoaveTestAsset\\ClassWithMethodsBeingRemoved'),
                 [

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/ClassBased/ConstantChangedTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -60,7 +60,7 @@
 block discarded – undo
         $comparator
             ->expects(self::exactly(2))
             ->method('__invoke')
-            ->willReturnCallback(function (ReflectionClassConstant $from, ReflectionClassConstant $to) : Changes {
+            ->willReturnCallback(function(ReflectionClassConstant $from, ReflectionClassConstant $to) : Changes {
                 $propertyName = $from->getName();
 
                 self::assertSame($propertyName, $to->getName());

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/ClassBased/PropertyChangedTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -60,7 +60,7 @@
 block discarded – undo
         $comparator
             ->expects(self::exactly(2))
             ->method('__invoke')
-            ->willReturnCallback(function (ReflectionProperty $from, ReflectionProperty $to) : Changes {
+            ->willReturnCallback(function(ReflectionProperty $from, ReflectionProperty $to) : Changes {
                 $propertyName = $from->getName();
 
                 self::assertSame($propertyName, $to->getName());

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/ClassBased/ClassBecameAbstractTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(function (Change $change) : string {
+            array_map(function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
             ,
             $locator
         ));
-        $toReflector   = new ClassReflector(new StringSourceLocator(
+        $toReflector = new ClassReflector(new StringSourceLocator(
             <<<'PHP'
 <?php
 
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($classes),
             array_map(
-                function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
+                function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
                     return [
                         $fromReflector->reflect($className),
                         $toReflector->reflect($className),

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/ClassBased/ClassBecameInterfaceTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(function (Change $change) : string {
+            array_map(function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
             ,
             $locator
         ));
-        $toReflector   = new ClassReflector(new StringSourceLocator(
+        $toReflector = new ClassReflector(new StringSourceLocator(
             <<<'PHP'
 <?php
 
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($classes),
             array_map(
-                function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
+                function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
                     return [
                         $fromReflector->reflect($className),
                         $toReflector->reflect($className),

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/ClassBased/MethodChangedTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -61,7 +61,7 @@
 block discarded – undo
         $comparator
             ->expects(self::exactly(3))
             ->method('__invoke')
-            ->willReturnCallback(function (ReflectionMethod $from, ReflectionMethod $to) : Changes {
+            ->willReturnCallback(function(ReflectionMethod $from, ReflectionMethod $to) : Changes {
                 $methodName = $from->getName();
 
                 self::assertSame(strtolower($methodName), strtolower($to->getName()));

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/ClassBased/ClassBecameTraitTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(function (Change $change) : string {
+            array_map(function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
             ,
             $locator
         ));
-        $toReflector   = new ClassReflector(new StringSourceLocator(
+        $toReflector = new ClassReflector(new StringSourceLocator(
             <<<'PHP'
 <?php
 
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($classes),
             array_map(
-                function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
+                function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
                     return [
                         $fromReflector->reflect($className),
                         $toReflector->reflect($className),

Please login to merge, or discard this patch.

BCBreak/FunctionBased/ParameterTypeContravarianceChangedTest.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -35,7 +35,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(function (Change $change) : string {
+            array_map(function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
             array_combine(
                 array_keys($functions),
                 array_map(
-                    function (string $function, array $errorMessages) use ($fromReflector, $toReflector) : array {
+                    function(string $function, array $errorMessages) use ($fromReflector, $toReflector) : array {
                         return [
                             $fromReflector->reflect($function),
                             $toReflector->reflect($function),

Please login to merge, or discard this patch.

		@@ -35,7 +35,7 @@ discard block
		block discarded – undo
35	35
36	36	self::assertSame(
37	37	$expectedMessages,
38		- array_map(function (Change $change) : string {
	38	+ array_map(function(Change $change) : string {
39	39	return $change->__toString();
40	40	}, iterator_to_array($changes))
41	41	);
		@@ -116,7 +116,7 @@ discard block
		block discarded – undo
116	116	array_combine(
117	117	array_keys($functions),
118	118	array_map(
119		- function (string $function, array $errorMessages) use ($fromReflector, $toReflector) : array {
	119	+ function(string $function, array $errorMessages) use ($fromReflector, $toReflector) : array {
120	120	return [
121	121	$fromReflector->reflect($function),
122	122	$toReflector->reflect($function),

		@@ -31,7 +31,7 @@ discard block
		block discarded – undo
31	31
32	32	self::assertSame(
33	33	$expectedMessages,
34		- array_map(function (Change $change) : string {
	34	+ array_map(function(Change $change) : string {
35	35	return $change->__toString();
36	36	}, iterator_to_array($changes))
37	37	);
		@@ -45,11 +45,11 @@ discard block
		block discarded – undo
45	45	return [
46	46	'RoaveTestAsset\\ClassWithPropertiesBeingRemoved' => [
47	47	(new ClassReflector(new SingleFileSourceLocator(
48		- __DIR__ . '/../../../../asset/api/old/ClassWithPropertiesBeingRemoved.php',
	48	+ __DIR__.'/../../../../asset/api/old/ClassWithPropertiesBeingRemoved.php',
49	49	$locator
50	50	)))->reflect('RoaveTestAsset\\ClassWithPropertiesBeingRemoved'),
51	51	(new ClassReflector(new SingleFileSourceLocator(
52		- __DIR__ . '/../../../../asset/api/new/ClassWithPropertiesBeingRemoved.php',
	52	+ __DIR__.'/../../../../asset/api/new/ClassWithPropertiesBeingRemoved.php',
53	53	$locator
54	54	)))->reflect('RoaveTestAsset\\ClassWithPropertiesBeingRemoved'),
55	55	[

		@@ -60,7 +60,7 @@
		block discarded – undo
60	60	$comparator
61	61	->expects(self::exactly(2))
62	62	->method('__invoke')
63		- ->willReturnCallback(function (ReflectionClassConstant $from, ReflectionClassConstant $to) : Changes {
	63	+ ->willReturnCallback(function(ReflectionClassConstant $from, ReflectionClassConstant $to) : Changes {
64	64	$propertyName = $from->getName();
65	65
66	66	self::assertSame($propertyName, $to->getName());

		@@ -33,7 +33,7 @@ discard block
		block discarded – undo
33	33
34	34	self::assertSame(
35	35	$expectedMessages,
36		- array_map(function (Change $change) : string {
	36	+ array_map(function(Change $change) : string {
37	37	return $change->__toString();
38	38	}, iterator_to_array($changes))
39	39	);
		@@ -63,7 +63,7 @@ discard block
		block discarded – undo
63	63	,
64	64	$locator
65	65	));
66		- $toReflector = new ClassReflector(new StringSourceLocator(
	66	+ $toReflector = new ClassReflector(new StringSourceLocator(
67	67	<<<'PHP'
68	68	<?php
69	69
		@@ -102,7 +102,7 @@ discard block
		block discarded – undo
102	102	return array_combine(
103	103	array_keys($classes),
104	104	array_map(
105		- function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
	105	+ function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
106	106	return [
107	107	$fromReflector->reflect($className),
108	108	$toReflector->reflect($className),

		@@ -61,7 +61,7 @@
		block discarded – undo
61	61	$comparator
62	62	->expects(self::exactly(3))
63	63	->method('__invoke')
64		- ->willReturnCallback(function (ReflectionMethod $from, ReflectionMethod $to) : Changes {
	64	+ ->willReturnCallback(function(ReflectionMethod $from, ReflectionMethod $to) : Changes {
65	65	$methodName = $from->getName();
66	66
67	67	self::assertSame(strtolower($methodName), strtolower($to->getName()));

Roave / BackwardCompatibilityCheck

Pull Request — master (#50)

Status

Category

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch