ClassConstantVisibilityReduced::__invoke() - Code Metrics - Inspection of "#24 rename package to `roave/backward-compatibilit..." - Roave/BackwardCompatibilityCheck - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#50)

by Marco

created 2018-04-27 11:29 UTC

ClassConstantVisibilityReduced::__invoke() A

↳ Parent: ClassConstantVisibilityReduced

Complexity

Conditions	2
Paths	2

Size

Total Lines	19
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	12
nc	2
nop	2
dl	0
loc	19
rs	9.4285
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Roave\BackwardCompatibility\DetectChanges\BCBreak\ClassConstantBased;

use Roave\BackwardCompatibility\Change;
use Roave\BackwardCompatibility\Changes;
use Roave\BetterReflection\Reflection\ReflectionClassConstant;
use function sprintf;

final class ClassConstantVisibilityReduced implements ClassConstantBased
{
    private const VISIBILITY_PRIVATE = 'private';

    private const VISIBILITY_PROTECTED = 'protected';

    private const VISIBILITY_PUBLIC = 'public';

    public function __invoke(ReflectionClassConstant $fromConstant, ReflectionClassConstant $toConstant) : Changes
    {
        $visibilityFrom = $this->propertyVisibility($fromConstant);
        $visibilityTo   = $this->propertyVisibility($toConstant);

        // Works because private, protected and public are sortable:
        if ($visibilityFrom <= $visibilityTo) {
            return Changes::empty();
        }

        return Changes::fromList(Change::changed(
            sprintf(
                'Constant %s::%s visibility reduced from %s to %s',
                $fromConstant->getDeclaringClass()->getName(),
                $fromConstant->getName(),
                $visibilityFrom,
                $visibilityTo
            ),
            true
        ));
    }

    private function propertyVisibility(ReflectionClassConstant $property) : string
    {
        if ($property->isPublic()) {
            return self::VISIBILITY_PUBLIC;
        }

        if ($property->isProtected()) {
            return self::VISIBILITY_PROTECTED;
        }

        return self::VISIBILITY_PRIVATE;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Roave\BackwardCompatibility\DetectChanges\BCBreak\ClassConstantBased;
6
7			use Roave\BackwardCompatibility\Change;
8			use Roave\BackwardCompatibility\Changes;
9			use Roave\BetterReflection\Reflection\ReflectionClassConstant;
10			use function sprintf;
11
12			final class ClassConstantVisibilityReduced implements ClassConstantBased
13			{
14			private const VISIBILITY_PRIVATE = 'private';
15
16			private const VISIBILITY_PROTECTED = 'protected';
17
18			private const VISIBILITY_PUBLIC = 'public';
19
20			public function __invoke(ReflectionClassConstant $fromConstant, ReflectionClassConstant $toConstant) : Changes
21			{
22			$visibilityFrom = $this->propertyVisibility($fromConstant);
23			$visibilityTo = $this->propertyVisibility($toConstant);
24
25			// Works because private, protected and public are sortable:
26			if ($visibilityFrom <= $visibilityTo) {
27			return Changes::empty();
28			}
29
30			return Changes::fromList(Change::changed(
31			sprintf(
32			'Constant %s::%s visibility reduced from %s to %s',
33			$fromConstant->getDeclaringClass()->getName(),
34			$fromConstant->getName(),
35			$visibilityFrom,
36			$visibilityTo
37			),
38			true
39			));
40			}
41
42			private function propertyVisibility(ReflectionClassConstant $property) : string
43			{
44			if ($property->isPublic()) {
45			return self::VISIBILITY_PUBLIC;
46			}
47
48			if ($property->isProtected()) {
49			return self::VISIBILITY_PROTECTED;
50			}
51
52			return self::VISIBILITY_PRIVATE;
53			}
54			}
55

Roave / BackwardCompatibilityCheck

Pull Request — master (#50)

ClassConstantVisibilityReduced::__invoke() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like