ConstantRemoved::__invoke() - Code Metrics - Inspection of "#24 rename package to `roave/backward-compatibilit..." - Roave/BackwardCompatibilityCheck - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#50)

by Marco

created 2018-04-27 11:29 UTC

ConstantRemoved::__invoke() A

↳ Parent: ConstantRemoved

Complexity

Conditions	1
Paths	1

Size

Total Lines	13
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	8
nc	1
nop	2
dl	0
loc	13
rs	9.4285
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Roave\BackwardCompatibility\DetectChanges\BCBreak\ClassBased;

use Roave\BackwardCompatibility\Change;
use Roave\BackwardCompatibility\Changes;
use Roave\BetterReflection\Reflection\ReflectionClass;
use Roave\BetterReflection\Reflection\ReflectionClassConstant;
use function array_diff_key;
use function array_filter;
use function array_map;
use function array_values;
use function sprintf;

final class ConstantRemoved implements ClassBased
{
    public function __invoke(ReflectionClass $fromClass, ReflectionClass $toClass) : Changes
    {
        $removedConstants = array_diff_key(
            $this->accessibleConstants($fromClass),
            $this->accessibleConstants($toClass)
        );

        return Changes::fromList(...array_values(array_map(function (ReflectionClassConstant $constant) use ($fromClass) : Change {
            return Change::removed(
                sprintf('Constant %s::%s was removed', $fromClass->getName(), $constant->getName()),
                true
            );
        }, $removedConstants)));
    }

    /** @return ReflectionClassConstant[] */
    private function accessibleConstants(ReflectionClass $class) : array
    {
        return array_filter($class->getReflectionConstants(), function (ReflectionClassConstant $constant) : bool {
            return $constant->isPublic() || $constant->isProtected();
        });
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Roave\BackwardCompatibility\DetectChanges\BCBreak\ClassBased;
6
7			use Roave\BackwardCompatibility\Change;
8			use Roave\BackwardCompatibility\Changes;
9			use Roave\BetterReflection\Reflection\ReflectionClass;
10			use Roave\BetterReflection\Reflection\ReflectionClassConstant;
11			use function array_diff_key;
12			use function array_filter;
13			use function array_map;
14			use function array_values;
15			use function sprintf;
16
17			final class ConstantRemoved implements ClassBased
18			{
19			public function __invoke(ReflectionClass $fromClass, ReflectionClass $toClass) : Changes
20			{
21			$removedConstants = array_diff_key(
22			$this->accessibleConstants($fromClass),
23			$this->accessibleConstants($toClass)
24			);
25
26			return Changes::fromList(...array_values(array_map(function (ReflectionClassConstant $constant) use ($fromClass) : Change {
27			return Change::removed(
28			sprintf('Constant %s::%s was removed', $fromClass->getName(), $constant->getName()),
29			true
30			);
31			}, $removedConstants)));
32			}
33
34			/** @return ReflectionClassConstant[] */
35			private function accessibleConstants(ReflectionClass $class) : array
36			{
37			return array_filter($class->getReflectionConstants(), function (ReflectionClassConstant $constant) : bool {
38			return $constant->isPublic() \|\| $constant->isProtected();
39			});
40			}
41			}
42

Roave / BackwardCompatibilityCheck

Pull Request — master (#50)

ConstantRemoved::__invoke() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like