ApiCompareTest::testExecuteWithDefaultRevisionsNotProvided() - Code Metrics - Inspection of "Merge pull request #25 from Roave/feature/detect-f..." - Roave/BackwardCompatibilityCheck - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( d83206...aa4419 )

by Marco
created 2018-04-14 18:38 UTC
testExecuteWithDefaultRevisionsNotProvided() A

↳ Parent: ApiCompareTest
Complexity

Conditions	1
Paths	1
Size

Total Lines	55
Code Lines	44
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
eloc	44
nc	1
nop	0
dl	0
loc	55
c	0
b	0
f	0
cc	1
rs	9.7692
How to fix Long Method

<?php
declare(strict_types=1);

namespace RoaveTest\ApiCompare\Command;

use Assert\InvalidArgumentException;
use PHPUnit\Framework\MockObject\MockObject;
use Roave\ApiCompare\Command\ApiCompare;
use PHPUnit\Framework\TestCase;
use Roave\ApiCompare\Factory\DirectoryReflectorFactory;
use Roave\ApiCompare\Git\CheckedOutRepository;
use Roave\ApiCompare\Git\GetVersionCollection;
use Roave\ApiCompare\Git\ParseRevision;
use Roave\ApiCompare\Git\PerformCheckoutOfRevision;
use Roave\ApiCompare\Git\PickVersionFromVersionCollection;
use Roave\ApiCompare\Git\Revision;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Version\Version;
use Version\VersionsCollection;

/**
 * @covers \Roave\ApiCompare\Command\ApiCompare
 */
final class ApiCompareTest extends TestCase
{
    /** @var CheckedOutRepository */
    private $sourceRepository;

    /** @var InputInterface|MockObject */
    private $input;

    /** @var OutputInterface|MockObject */
    private $output;

    /** @var PerformCheckoutOfRevision|MockObject */
    private $performCheckout;

    /** @var ParseRevision|MockObject */
    private $parseRevision;

    /** @var GetVersionCollection|MockObject */
    private $getVersions;

    /** @var PickVersionFromVersionCollection|MockObject */
    private $pickVersion;

    /** @var ApiCompare */
    private $compare;

    public function setUp() : void
    {
        $this->sourceRepository = CheckedOutRepository::fromPath(realpath(__DIR__ . '/../../../'));
        $this->input = $this->createMock(InputInterface::class);
        $this->output = $this->createMock(OutputInterface::class);
        $this->performCheckout = $this->createMock(PerformCheckoutOfRevision::class);
        $this->parseRevision = $this->createMock(ParseRevision::class);
        $this->getVersions = $this->createMock(GetVersionCollection::class);
        $this->pickVersion = $this->createMock(PickVersionFromVersionCollection::class);
        $this->compare = new ApiCompare(
            $this->performCheckout,
            new DirectoryReflectorFactory(),
            $this->parseRevision,
            $this->getVersions,
            $this->pickVersion
        );
    }

    public function testExecuteWhenRevisionsAreProvidedAsOptions() : void
    {
        $fromSha = sha1('fromRevision', false);
        $toSha = sha1('toRevision', false);

        $this->input->expects(self::any())->method('hasOption')->willReturn(true);
                      expects(self::any())->method('hasOption')->willReturn(true);
        $this->input->expects(self::any())->method('getOption')->willReturnMap([
            ['from', $fromSha],
            ['to', $toSha],
        ]);
        $this->input->expects(self::any())->method('getArgument')->willReturnMap([
            ['sources-path', 'src'],
        ]);

        $this->performCheckout->expects(self::at(0))
                                expects(self::at(0))
            ->method('checkout')
            ->with($this->sourceRepository, $fromSha)
            ->willReturn($this->sourceRepository);
        $this->performCheckout->expects(self::at(1))
            ->method('checkout')
            ->with($this->sourceRepository, $toSha)
            ->willReturn($this->sourceRepository);
        $this->performCheckout->expects(self::at(2))
            ->method('remove')
            ->with($this->sourceRepository);
        $this->performCheckout->expects(self::at(3))
            ->method('remove')
            ->with($this->sourceRepository);

        $this->parseRevision->expects(self::at(0))
                              expects(self::at(0))
            ->method('fromStringForRepository')
            ->with($fromSha)
            ->willReturn(Revision::fromSha1($fromSha));
        $this->parseRevision->expects(self::at(1))
            ->method('fromStringForRepository')
            ->with($toSha)
            ->willReturn(Revision::fromSha1($toSha));

        chdir((string)$this->sourceRepository);

        $this->compare->execute($this->input, $this->output);
    }

    public function testExecuteWithDefaultRevisionsNotProvided() : void
    {
        $fromSha = sha1('fromRevision', false);
        $toSha = sha1('toRevision', false);
        $versions = VersionsCollection::fromArray(['1.0.0', '1.0.1']);
        $pickedVersion = Version::fromString('1.0.0');

        $this->input->expects(self::any())->method('hasOption')->willReturn(false);
        $this->input->expects(self::any())->method('getOption')->willReturnMap([
            ['from', null],
            ['to', 'HEAD'],
        ]);
        $this->input->expects(self::any())->method('getArgument')->willReturnMap([
            ['sources-path', 'src'],
        ]);

        $this->performCheckout->expects(self::at(0))
            ->method('checkout')
            ->with($this->sourceRepository, $fromSha)
            ->willReturn($this->sourceRepository);
        $this->performCheckout->expects(self::at(1))
            ->method('checkout')
            ->with($this->sourceRepository, $toSha)
            ->willReturn($this->sourceRepository);
        $this->performCheckout->expects(self::at(2))
            ->method('remove')
            ->with($this->sourceRepository);
        $this->performCheckout->expects(self::at(3))
            ->method('remove')
            ->with($this->sourceRepository);

        $this->parseRevision->expects(self::at(0))
            ->method('fromStringForRepository')
            ->with((string)$pickedVersion)
            ->willReturn(Revision::fromSha1($fromSha));
        $this->parseRevision->expects(self::at(1))
            ->method('fromStringForRepository')
            ->with('HEAD')
            ->willReturn(Revision::fromSha1($toSha));

        $this->getVersions->expects(self::once())
                            expects(self::once())
            ->method('fromRepository')
            ->with(self::callback(function (CheckedOutRepository $checkedOutRepository) : bool {
                self::assertEquals($this->sourceRepository, $checkedOutRepository);
                return true;
            }))
            ->willReturn($versions);
        $this->pickVersion->expects(self::once())
                            expects(self::once())
            ->method('forVersions')
            ->with($versions)
            ->willReturn($pickedVersion);

        chdir((string)$this->sourceRepository);

        $this->compare->execute($this->input, $this->output);
    }

    public function testExecuteFailsIfCheckedOutRepositoryDoesNotExist() : void
    {
        $fromSha = sha1('fromRevision', false);
        $toSha = sha1('toRevision', false);

        $this->input->expects(self::any())->method('hasOption')->willReturn(true);
        $this->input->expects(self::any())->method('getOption')->willReturnMap([
            ['from', $fromSha],
            ['to', $toSha],
        ]);
        $this->input->expects(self::any())->method('getArgument')->willReturnMap([
            ['sources-path', uniqid('src', true)],
        ]);

        $this->performCheckout->expects(self::at(0))
            ->method('checkout')
            ->with($this->sourceRepository, $fromSha)
            ->willReturn($this->sourceRepository);
        $this->performCheckout->expects(self::at(1))
            ->method('checkout')
            ->with($this->sourceRepository, $toSha)
            ->willReturn($this->sourceRepository);
        $this->performCheckout->expects(self::at(2))
            ->method('remove')
            ->with($this->sourceRepository);
        $this->performCheckout->expects(self::at(3))
            ->method('remove')
            ->with($this->sourceRepository);

        $this->parseRevision->expects(self::at(0))
            ->method('fromStringForRepository')
            ->with($fromSha)
            ->willReturn(Revision::fromSha1($fromSha));
        $this->parseRevision->expects(self::at(1))
            ->method('fromStringForRepository')
            ->with($toSha)
            ->willReturn(Revision::fromSha1($toSha));

        chdir((string)$this->sourceRepository);

        $this->expectException(InvalidArgumentException::class);
        $this->compare->execute($this->input, $this->output);
    }
}

Roave / BackwardCompatibilityCheck

Push — master ( d83206...aa4419 )

testExecuteWithDefaultRevisionsNotProvided() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
