MethodRemoved::compare() - Code Metrics - Inspection of "Feature/#5 detected property visibility change" - Roave/BackwardCompatibilityCheck - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#30)

by Marco

created 2018-04-14 20:31 UTC

MethodRemoved::compare() A

↳ Parent: MethodRemoved

Complexity

Conditions	1
Paths	1

Size

Total Lines	15
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	15
c	0
b	0
f	0
rs	9.4285
cc	1
eloc	9
nc	1
nop	2

<?php

declare(strict_types=1);

namespace Roave\ApiCompare\Comparator\BackwardsCompatibility\ClassBased;

use Assert\Assert;
use Roave\ApiCompare\Change;
use Roave\ApiCompare\Changes;
use Roave\BetterReflection\Reflection\ReflectionClass;
use Roave\BetterReflection\Reflection\ReflectionMethod;

final class MethodRemoved implements ClassBased
{
    public function compare(ReflectionClass $fromClass, ReflectionClass $toClass) : Changes
    {
        Assert::that($fromClass->getName())->same($toClass->getName());

        $removedMethods = array_diff_key(
            array_change_key_case($this->accessibleMethods($fromClass), \CASE_UPPER),
            array_change_key_case($this->accessibleMethods($toClass), \CASE_UPPER)
        );

        return Changes::fromArray(array_values(array_map(function (ReflectionMethod $method) use ($fromClass) : Change {
            return Change::removed(
                sprintf('Method %s#%s() was removed', $fromClass->getName(), $method->getName()),
                true
            );
        }, $removedMethods)));
    }

    /** @return ReflectionMethod[] */
    private function accessibleMethods(ReflectionClass $class) : array
    {
        $methods = array_filter($class->getMethods(), function (ReflectionMethod $method) : bool {
            return $method->isPublic() || $method->isProtected();
        });

        return array_combine(
            array_map(function (ReflectionMethod $method) : string {
                return $method->getName();
            }, $methods),
            $methods
        );
    }
}

1			<?php
2
3			declare(strict_types=1);
4
5			namespace Roave\ApiCompare\Comparator\BackwardsCompatibility\ClassBased;
6
7			use Assert\Assert;
8			use Roave\ApiCompare\Change;
9			use Roave\ApiCompare\Changes;
10			use Roave\BetterReflection\Reflection\ReflectionClass;
11			use Roave\BetterReflection\Reflection\ReflectionMethod;
12
13			final class MethodRemoved implements ClassBased
14			{
15			public function compare(ReflectionClass $fromClass, ReflectionClass $toClass) : Changes
16			{
17			Assert::that($fromClass->getName())->same($toClass->getName());
18
19			$removedMethods = array_diff_key(
20			array_change_key_case($this->accessibleMethods($fromClass), \CASE_UPPER),
21			array_change_key_case($this->accessibleMethods($toClass), \CASE_UPPER)
22			);
23
24			return Changes::fromArray(array_values(array_map(function (ReflectionMethod $method) use ($fromClass) : Change {
25			return Change::removed(
26			sprintf('Method %s#%s() was removed', $fromClass->getName(), $method->getName()),
27			true
28			);
29			}, $removedMethods)));
30			}
31
32			/** @return ReflectionMethod[] */
33			private function accessibleMethods(ReflectionClass $class) : array
34			{
35			$methods = array_filter($class->getMethods(), function (ReflectionMethod $method) : bool {
36			return $method->isPublic() \|\| $method->isProtected();
37			});
38
39			return array_combine(
40			array_map(function (ReflectionMethod $method) : string {
41			return $method->getName();
42			}, $methods),
43			$methods
44			);
45			}
46			}

Roave / BackwardCompatibilityCheck

Pull Request — master (#30)

MethodRemoved::compare() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like