Conditions | 1 |
Paths | 1 |
Total Lines | 165 |
Code Lines | 122 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
38 | public function checkedTypes() : array |
||
39 | { |
||
40 | $reflector = new ClassReflector(new StringSourceLocator( |
||
41 | <<<'PHP' |
||
42 | <?php |
||
43 | |||
44 | interface Traversable {} |
||
45 | interface Iterator extends Traversable {} |
||
46 | interface AnInterface {} |
||
47 | interface AnotherInterface {} |
||
48 | class AnotherClass implements AnInterface {} |
||
49 | class AnotherClassWithMultipleInterfaces implements AnInterface, AnotherInterface {} |
||
50 | class AClass {} |
||
51 | class BClass extends AClass {} |
||
52 | class CClass extends BClass {} |
||
53 | PHP |
||
54 | , |
||
55 | (new BetterReflection())->astLocator() |
||
56 | )); |
||
57 | |||
58 | return [ |
||
59 | 'no type to no type is contravariant with itself' => [ |
||
60 | null, |
||
61 | null, |
||
62 | true, |
||
63 | ], |
||
64 | 'no type to void type is not contravariant' => [ |
||
65 | null, |
||
66 | ReflectionType::createFromTypeAndReflector('void', false, $reflector), |
||
67 | false, |
||
68 | ], |
||
69 | 'void type to no type is contravariant' => [ |
||
70 | ReflectionType::createFromTypeAndReflector('void', false, $reflector), |
||
71 | null, |
||
72 | true, |
||
73 | ], |
||
74 | 'void type to scalar type is contravariant' => [ |
||
75 | ReflectionType::createFromTypeAndReflector('void', false, $reflector), |
||
76 | ReflectionType::createFromTypeAndReflector('string', false, $reflector), |
||
77 | true, |
||
78 | ], |
||
79 | 'void type to class type is contravariant' => [ |
||
80 | ReflectionType::createFromTypeAndReflector('void', false, $reflector), |
||
81 | ReflectionType::createFromTypeAndReflector('AClass', false, $reflector), |
||
82 | true, |
||
83 | ], |
||
84 | 'scalar type to no type is contravariant' => [ |
||
85 | ReflectionType::createFromTypeAndReflector('string', false, $reflector), |
||
86 | null, |
||
87 | true, |
||
88 | ], |
||
89 | 'no type to scalar type is not contravariant' => [ |
||
90 | null, |
||
91 | ReflectionType::createFromTypeAndReflector('string', false, $reflector), |
||
92 | false, |
||
93 | ], |
||
94 | 'class type to no type is contravariant' => [ |
||
95 | ReflectionType::createFromTypeAndReflector('AClass', false, $reflector), |
||
96 | null, |
||
97 | true, |
||
98 | ], |
||
99 | 'no type to class type is not contravariant' => [ |
||
100 | ReflectionType::createFromTypeAndReflector('AClass', false, $reflector), |
||
101 | null, |
||
102 | true, |
||
103 | ], |
||
104 | 'iterable to array is not contravariant' => [ |
||
105 | ReflectionType::createFromTypeAndReflector('iterable', false, $reflector), |
||
106 | ReflectionType::createFromTypeAndReflector('array', false, $reflector), |
||
107 | false, |
||
108 | ], |
||
109 | 'array to iterable is contravariant' => [ |
||
110 | ReflectionType::createFromTypeAndReflector('array', false, $reflector), |
||
111 | ReflectionType::createFromTypeAndReflector('iterable', false, $reflector), |
||
112 | true, |
||
113 | ], |
||
114 | 'iterable to non-iterable class type is not contravariant' => [ |
||
115 | ReflectionType::createFromTypeAndReflector('iterable', false, $reflector), |
||
116 | ReflectionType::createFromTypeAndReflector('AnotherClassWithMultipleInterfaces', false, $reflector), |
||
117 | false, |
||
118 | ], |
||
119 | 'iterable to iterable class type is not contravariant' => [ |
||
120 | ReflectionType::createFromTypeAndReflector('iterable', false, $reflector), |
||
121 | ReflectionType::createFromTypeAndReflector('Iterator', false, $reflector), |
||
122 | false, |
||
123 | ], |
||
124 | 'non-iterable class to iterable type is not contravariant' => [ |
||
125 | ReflectionType::createFromTypeAndReflector('iterable', false, $reflector), |
||
126 | ReflectionType::createFromTypeAndReflector('AnotherClassWithMultipleInterfaces', false, $reflector), |
||
127 | false, |
||
128 | ], |
||
129 | 'iterable class type to iterable is not contravariant' => [ |
||
130 | ReflectionType::createFromTypeAndReflector('Iterator', false, $reflector), |
||
131 | ReflectionType::createFromTypeAndReflector('iterable', false, $reflector), |
||
132 | false, |
||
133 | ], |
||
134 | 'object to class type is not contravariant' => [ |
||
135 | ReflectionType::createFromTypeAndReflector('object', false, $reflector), |
||
136 | ReflectionType::createFromTypeAndReflector('AClass', false, $reflector), |
||
137 | false, |
||
138 | ], |
||
139 | 'class type to object is contravariant' => [ |
||
140 | ReflectionType::createFromTypeAndReflector('AClass', false, $reflector), |
||
141 | ReflectionType::createFromTypeAndReflector('object', false, $reflector), |
||
142 | true, |
||
143 | ], |
||
144 | 'class type to scalar type is not contravariant' => [ |
||
145 | ReflectionType::createFromTypeAndReflector('AClass', false, $reflector), |
||
146 | ReflectionType::createFromTypeAndReflector('string', false, $reflector), |
||
147 | false, |
||
148 | ], |
||
149 | 'scalar type to class type is not contravariant' => [ |
||
150 | ReflectionType::createFromTypeAndReflector('string', false, $reflector), |
||
151 | ReflectionType::createFromTypeAndReflector('AClass', false, $reflector), |
||
152 | false, |
||
153 | ], |
||
154 | 'scalar type (string) to different scalar type (int) is not contravariant' => [ |
||
155 | ReflectionType::createFromTypeAndReflector('string', false, $reflector), |
||
156 | ReflectionType::createFromTypeAndReflector('int', false, $reflector), |
||
157 | false, |
||
158 | ], |
||
159 | 'scalar type (int) to different scalar type (float) is not contravariant' => [ |
||
160 | ReflectionType::createFromTypeAndReflector('int', false, $reflector), |
||
161 | ReflectionType::createFromTypeAndReflector('float', false, $reflector), |
||
162 | false, |
||
163 | ], |
||
164 | 'object type to scalar type is not contravariant' => [ |
||
165 | ReflectionType::createFromTypeAndReflector('object', false, $reflector), |
||
166 | ReflectionType::createFromTypeAndReflector('string', false, $reflector), |
||
167 | false, |
||
168 | ], |
||
169 | 'scalar type to object type is not contravariant' => [ |
||
170 | ReflectionType::createFromTypeAndReflector('string', false, $reflector), |
||
171 | ReflectionType::createFromTypeAndReflector('object', false, $reflector), |
||
172 | false, |
||
173 | ], |
||
174 | 'class to superclass is contravariant' => [ |
||
175 | ReflectionType::createFromTypeAndReflector('BClass', false, $reflector), |
||
176 | ReflectionType::createFromTypeAndReflector('AClass', false, $reflector), |
||
177 | true, |
||
178 | ], |
||
179 | 'class to subclass is not contravariant' => [ |
||
180 | ReflectionType::createFromTypeAndReflector('BClass', false, $reflector), |
||
181 | ReflectionType::createFromTypeAndReflector('CClass', false, $reflector), |
||
182 | false, |
||
183 | ], |
||
184 | 'class to implemented interface is contravariant' => [ |
||
185 | ReflectionType::createFromTypeAndReflector('AnotherClassWithMultipleInterfaces', false, $reflector), |
||
186 | ReflectionType::createFromTypeAndReflector('AnInterface', false, $reflector), |
||
187 | true, |
||
188 | ], |
||
189 | 'class to not implemented interface is not contravariant' => [ |
||
190 | ReflectionType::createFromTypeAndReflector('AnotherClassWithMultipleInterfaces', false, $reflector), |
||
191 | ReflectionType::createFromTypeAndReflector('Traversable', false, $reflector), |
||
192 | false, |
||
193 | ], |
||
194 | 'interface to parent interface is contravariant' => [ |
||
195 | ReflectionType::createFromTypeAndReflector('Iterator', false, $reflector), |
||
196 | ReflectionType::createFromTypeAndReflector('Traversable', false, $reflector), |
||
197 | true, |
||
198 | ], |
||
199 | 'interface to child interface is contravariant' => [ |
||
200 | ReflectionType::createFromTypeAndReflector('Traversable', false, $reflector), |
||
201 | ReflectionType::createFromTypeAndReflector('Iterator', false, $reflector), |
||
202 | false, |
||
203 | ], |
||
296 |