MethodBecameFinalTest::propertiesToBeTested() - Code Metrics - Roave/BackwardCompatibilityCheck - Measure and Improve Code Quality continuously with Scrutinizer

MethodBecameFinalTest::propertiesToBeTested() A
last analyzed 2020-06-22 08:59 UTC

↳ Parent: MethodBecameFinalTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	89
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	38
c	0
b	0
f	0
nc	1
nop	0
dl	0
loc	89
rs	9.312

How to fix Long Method

<?php

declare(strict_types=1);

namespace RoaveTest\BackwardCompatibility\DetectChanges\BCBreak\MethodBased;

use PHPUnit\Framework\TestCase;
use Roave\BackwardCompatibility\Change;
use Roave\BackwardCompatibility\DetectChanges\BCBreak\MethodBased\MethodBecameFinal;
use Roave\BetterReflection\BetterReflection;
use Roave\BetterReflection\Reflection\ReflectionMethod;
use Roave\BetterReflection\Reflector\ClassReflector;
use Roave\BetterReflection\SourceLocator\Type\StringSourceLocator;
use RoaveTest\BackwardCompatibility\TypeRestriction;
use function array_combine;
use function array_keys;
use function array_map;
use function iterator_to_array;

/**
 * @covers \Roave\BackwardCompatibility\DetectChanges\BCBreak\MethodBased\MethodBecameFinal
 */
final class MethodBecameFinalTest extends TestCase
{
    /**
     * @param string[] $expectedMessages
     *
     * @dataProvider propertiesToBeTested
     */
    public function testDiffs(
        ReflectionMethod $fromMethod,
        ReflectionMethod $toMethod,
        array $expectedMessages
    ) : void {
        $changes = (new MethodBecameFinal())
            ->__invoke($fromMethod, $toMethod);

        self::assertSame(
            $expectedMessages,
            array_map(static function (Change $change) : string {
                return $change->__toString();
            }, iterator_to_array($changes))
        );
    }

    /**
     * @return array<string, array<int, ReflectionMethod|array<int, string>>>
     *
     * @psalm-return array<string, array{0: ReflectionMethod, 1: ReflectionMethod, 2: list<string>}>
     */
    public function propertiesToBeTested() : array
    {
        $astLocator = (new BetterReflection())->astLocator();

        $fromLocator = new StringSourceLocator(
            <<<'PHP'
<?php

abstract class TheClass {
    public function publicOverrideableToFinal() {}
    public final function publicFinalToOverrideable() {}
    public function publicOverrideableToOverrideable() {}
    public final function publicFinalToFinal() {}
    
    protected function protectedOverrideableToFinal() {}
    protected final function protectedFinalToOverrideable() {}
    protected function protectedOverrideableToOverrideable() {}
    protected final function protectedFinalToFinal() {}
    
    private function privateOverrideableToFinal() {}
    private final function privateFinalToOverrideable() {}
    private function privateOverrideableToOverrideable() {}
    private final function privateFinalToFinal() {}
}
PHP
            ,
            $astLocator
        );

        $toLocator = new StringSourceLocator(
            <<<'PHP'
<?php

abstract class TheClass {
    public final function publicOverrideableToFinal() {}
    public function publicFinalToOverrideable() {}
    public function publicOverrideableToOverrideable() {}
    public final function publicFinalToFinal() {}
    
    protected final function protectedOverrideableToFinal() {}
    protected function protectedFinalToOverrideable() {}
    protected function protectedOverrideableToOverrideable() {}
    protected final function protectedFinalToFinal() {}
    
    private final function privateOverrideableToFinal() {}
    private function privateFinalToOverrideable() {}
    private function privateOverrideableToOverrideable() {}
    private final function privateFinalToFinal() {}
}
PHP
            ,
            $astLocator
        );

        $fromClassReflector = new ClassReflector($fromLocator);
        $toClassReflector   = new ClassReflector($toLocator);
        $fromClass          = $fromClassReflector->reflect('TheClass');
        $toClass            = $toClassReflector->reflect('TheClass');

        $properties = [
            'publicOverrideableToFinal' => ['[BC] CHANGED: Method publicOverrideableToFinal() of class TheClass became final'],
            'publicFinalToOverrideable' => [],
            'publicOverrideableToOverrideable' => [],
            'publicFinalToFinal' => [],

            'protectedOverrideableToFinal' => ['[BC] CHANGED: Method protectedOverrideableToFinal() of class TheClass became final'],
            'protectedFinalToOverrideable' => [],
            'protectedOverrideableToOverrideable' => [],
            'protectedFinalToFinal' => [],

            'privateOverrideableToFinal' => ['[BC] CHANGED: Method privateOverrideableToFinal() of class TheClass became final'],
            'privateFinalToOverrideable' => [],
            'privateOverrideableToOverrideable' => [],
            'privateFinalToFinal' => [],
        ];

        return TypeRestriction::array(array_combine(
            array_keys($properties),
            array_map(
                /** @psalm-param list<string> $errorMessages https://github.com/vimeo/psalm/issues/2772 */
                static function (string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
                    return [
                        $fromClass->getMethod($methodName),
                        $toClass->getMethod($methodName),
                        $errorMessages,
                    ];
                },
                array_keys($properties),
                $properties
            )
        ));
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace RoaveTest\BackwardCompatibility\DetectChanges\BCBreak\MethodBased;
6
7			use PHPUnit\Framework\TestCase;
8			use Roave\BackwardCompatibility\Change;
9			use Roave\BackwardCompatibility\DetectChanges\BCBreak\MethodBased\MethodBecameFinal;
10			use Roave\BetterReflection\BetterReflection;
11			use Roave\BetterReflection\Reflection\ReflectionMethod;
12			use Roave\BetterReflection\Reflector\ClassReflector;
13			use Roave\BetterReflection\SourceLocator\Type\StringSourceLocator;
14			use RoaveTest\BackwardCompatibility\TypeRestriction;
15			use function array_combine;
16			use function array_keys;
17			use function array_map;
18			use function iterator_to_array;
19
20			/**
21			* @covers \Roave\BackwardCompatibility\DetectChanges\BCBreak\MethodBased\MethodBecameFinal
22			*/
23			final class MethodBecameFinalTest extends TestCase
24			{
25			/**
26			* @param string[] $expectedMessages
27			*
28			* @dataProvider propertiesToBeTested
29			*/
30			public function testDiffs(
31			ReflectionMethod $fromMethod,
32			ReflectionMethod $toMethod,
33			array $expectedMessages
34			) : void {
35			$changes = (new MethodBecameFinal())
36			->__invoke($fromMethod, $toMethod);
37
38			self::assertSame(
39			$expectedMessages,
40			array_map(static function (Change $change) : string {
41			return $change->__toString();
42			}, iterator_to_array($changes))
43			);
44			}
45
46			/**
47			* @return array<string, array<int, ReflectionMethod\|array<int, string>>>
48			*
49			* @psalm-return array<string, array{0: ReflectionMethod, 1: ReflectionMethod, 2: list<string>}>
50			*/
51			public function propertiesToBeTested() : array
52			{
53			$astLocator = (new BetterReflection())->astLocator();
54
55			$fromLocator = new StringSourceLocator(
56			<<<'PHP'
57			<?php
58
59			abstract class TheClass {
60			public function publicOverrideableToFinal() {}
61			public final function publicFinalToOverrideable() {}
62			public function publicOverrideableToOverrideable() {}
63			public final function publicFinalToFinal() {}
64
65			protected function protectedOverrideableToFinal() {}
66			protected final function protectedFinalToOverrideable() {}
67			protected function protectedOverrideableToOverrideable() {}
68			protected final function protectedFinalToFinal() {}
69
70			private function privateOverrideableToFinal() {}
71			private final function privateFinalToOverrideable() {}
72			private function privateOverrideableToOverrideable() {}
73			private final function privateFinalToFinal() {}
74			}
75			PHP
76			,
77			$astLocator
78			);
79
80			$toLocator = new StringSourceLocator(
81			<<<'PHP'
82			<?php
83
84			abstract class TheClass {
85			public final function publicOverrideableToFinal() {}
86			public function publicFinalToOverrideable() {}
87			public function publicOverrideableToOverrideable() {}
88			public final function publicFinalToFinal() {}
89
90			protected final function protectedOverrideableToFinal() {}
91			protected function protectedFinalToOverrideable() {}
92			protected function protectedOverrideableToOverrideable() {}
93			protected final function protectedFinalToFinal() {}
94
95			private final function privateOverrideableToFinal() {}
96			private function privateFinalToOverrideable() {}
97			private function privateOverrideableToOverrideable() {}
98			private final function privateFinalToFinal() {}
99			}
100			PHP
101			,
102			$astLocator
103			);
104
105			$fromClassReflector = new ClassReflector($fromLocator);
106			$toClassReflector = new ClassReflector($toLocator);
107			$fromClass = $fromClassReflector->reflect('TheClass');
108			$toClass = $toClassReflector->reflect('TheClass');
109
110			$properties = [
111			'publicOverrideableToFinal' => ['[BC] CHANGED: Method publicOverrideableToFinal() of class TheClass became final'],
112			'publicFinalToOverrideable' => [],
113			'publicOverrideableToOverrideable' => [],
114			'publicFinalToFinal' => [],
115
116			'protectedOverrideableToFinal' => ['[BC] CHANGED: Method protectedOverrideableToFinal() of class TheClass became final'],
117			'protectedFinalToOverrideable' => [],
118			'protectedOverrideableToOverrideable' => [],
119			'protectedFinalToFinal' => [],
120
121			'privateOverrideableToFinal' => ['[BC] CHANGED: Method privateOverrideableToFinal() of class TheClass became final'],
122			'privateFinalToOverrideable' => [],
123			'privateOverrideableToOverrideable' => [],
124			'privateFinalToFinal' => [],
125			];
126
127			return TypeRestriction::array(array_combine(
128			array_keys($properties),
129			array_map(
130			/** @psalm-param list<string> $errorMessages https://github.com/vimeo/psalm/issues/2772 */
131			static function (string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
132			return [
133			$fromClass->getMethod($methodName),
134			$toClass->getMethod($methodName),
135			$errorMessages,
136			];
137			},
138			array_keys($properties),
139			$properties
140			)
141			));
142			}
143			}
144

Roave / BackwardCompatibilityCheck

MethodBecameFinalTest::propertiesToBeTested() A last analyzed 2020-06-22 08:59 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

MethodBecameFinalTest::propertiesToBeTested() A
last analyzed 2020-06-22 08:59 UTC