PropertyDocumentedTypeChanged::__invoke() - Code Metrics - Roave/BackwardCompatibilityCheck - Measure and Improve Code Quality continuously with Scrutinizer

PropertyDocumentedTypeChanged::__invoke() A
last analyzed 2020-06-22 08:59 UTC

↳ Parent: PropertyDocumentedTypeChanged

Complexity

Conditions	5
Paths	3

Size

Total Lines	24
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	5
eloc	15
c	2
b	0
f	0
nc	3
nop	2
dl	0
loc	24
rs	9.4555

<?php

declare(strict_types=1);

namespace Roave\BackwardCompatibility\DetectChanges\BCBreak\PropertyBased;

use Roave\BackwardCompatibility\Change;
use Roave\BackwardCompatibility\Changes;
use Roave\BackwardCompatibility\Formatter\ReflectionPropertyName;
use Roave\BetterReflection\Reflection\ReflectionProperty;
use function implode;
use function Safe\sort;
use function Safe\sprintf;

/**
 * Type declarations for properties are invariant: you can't restrict the type because the consumer may
 * write invalid values to it, and you cannot widen the type because the consumer may expect a specific
 * type when reading.
 */
final class PropertyDocumentedTypeChanged implements PropertyBased
{
    /** @var ReflectionPropertyName */
    private $formatProperty;

    public function __construct()
    {
        $this->formatProperty = new ReflectionPropertyName();
    }

    public function __invoke(ReflectionProperty $fromProperty, ReflectionProperty $toProperty) : Changes
    {
        if ($fromProperty->getDocComment() === '') {
            return Changes::empty();
        }

        $fromTypes = $fromProperty->getDocBlockTypeStrings();
        $toTypes   = $toProperty->getDocBlockTypeStrings();

        sort($fromTypes);
        sort($toTypes);

        if ($fromTypes === $toTypes) {
            return Changes::empty();
        }

        return Changes::fromList(Change::changed(
            sprintf(
                'Type documentation for property %s changed from %s to %s',
                $this->formatProperty->__invoke($fromProperty),
                implode('|', $fromTypes) ?: 'having no type',
                implode('|', $toTypes) ?: 'having no type'
            ),
            true
        ));
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Roave\BackwardCompatibility\DetectChanges\BCBreak\PropertyBased;
6
7			use Roave\BackwardCompatibility\Change;
8			use Roave\BackwardCompatibility\Changes;
9			use Roave\BackwardCompatibility\Formatter\ReflectionPropertyName;
10			use Roave\BetterReflection\Reflection\ReflectionProperty;
11			use function implode;
12			use function Safe\sort;
13			use function Safe\sprintf;
14
15			/**
16			* Type declarations for properties are invariant: you can't restrict the type because the consumer may
17			* write invalid values to it, and you cannot widen the type because the consumer may expect a specific
18			* type when reading.
19			*/
20			final class PropertyDocumentedTypeChanged implements PropertyBased
21			{
22			/** @var ReflectionPropertyName */
23			private $formatProperty;
24
25			public function __construct()
26			{
27			$this->formatProperty = new ReflectionPropertyName();
28			}
29
30			public function __invoke(ReflectionProperty $fromProperty, ReflectionProperty $toProperty) : Changes
31			{
32			if ($fromProperty->getDocComment() === '') {
33			return Changes::empty();
34			}
35
36			$fromTypes = $fromProperty->getDocBlockTypeStrings();
37			$toTypes = $toProperty->getDocBlockTypeStrings();
38
39			sort($fromTypes);
40			sort($toTypes);
41
42			if ($fromTypes === $toTypes) {
43			return Changes::empty();
44			}
45
46			return Changes::fromList(Change::changed(
47			sprintf(
48			'Type documentation for property %s changed from %s to %s',
49			$this->formatProperty->__invoke($fromProperty),
50			implode('\|', $fromTypes) ?: 'having no type',
51			implode('\|', $toTypes) ?: 'having no type'
52			),
53			true
54			));
55			}
56			}
57

Roave / BackwardCompatibilityCheck

PropertyDocumentedTypeChanged::__invoke() A last analyzed 2020-06-22 08:59 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

PropertyDocumentedTypeChanged::__invoke() A
last analyzed 2020-06-22 08:59 UTC