MethodVisibilityReduced::methodVisibility() - Code Metrics - Roave/BackwardCompatibilityCheck - Measure and Improve Code Quality continuously with Scrutinizer

MethodVisibilityReduced::methodVisibility() A
last analyzed 2020-06-22 08:59 UTC

↳ Parent: MethodVisibilityReduced

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	5
nc	3
nop	1
dl	0
loc	11
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Roave\BackwardCompatibility\DetectChanges\BCBreak\MethodBased;

use Roave\BackwardCompatibility\Change;
use Roave\BackwardCompatibility\Changes;
use Roave\BetterReflection\Reflection\ReflectionMethod;
use function Safe\sprintf;

final class MethodVisibilityReduced implements MethodBased
{
    private const VISIBILITY_PRIVATE = 'private';

    private const VISIBILITY_PROTECTED = 'protected';

    private const VISIBILITY_PUBLIC = 'public';

    public function __invoke(ReflectionMethod $fromMethod, ReflectionMethod $toMethod) : Changes
    {
        $visibilityFrom = $this->methodVisibility($fromMethod);
        $visibilityTo   = $this->methodVisibility($toMethod);

        // Works because private, protected and public are sortable:
        if ($visibilityFrom <= $visibilityTo) {
            return Changes::empty();
        }

        return Changes::fromList(Change::changed(
            sprintf(
                'Method %s() of class %s visibility reduced from %s to %s',
                $fromMethod->getName(),
                $fromMethod->getDeclaringClass()->getName(),
                $visibilityFrom,
                $visibilityTo
            ),
            true
        ));
    }

    private function methodVisibility(ReflectionMethod $method) : string
    {
        if ($method->isPublic()) {
            return self::VISIBILITY_PUBLIC;
        }

        if ($method->isProtected()) {
            return self::VISIBILITY_PROTECTED;
        }

        return self::VISIBILITY_PRIVATE;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Roave\BackwardCompatibility\DetectChanges\BCBreak\MethodBased;
6
7			use Roave\BackwardCompatibility\Change;
8			use Roave\BackwardCompatibility\Changes;
9			use Roave\BetterReflection\Reflection\ReflectionMethod;
10			use function Safe\sprintf;
11
12			final class MethodVisibilityReduced implements MethodBased
13			{
14			private const VISIBILITY_PRIVATE = 'private';
15
16			private const VISIBILITY_PROTECTED = 'protected';
17
18			private const VISIBILITY_PUBLIC = 'public';
19
20			public function __invoke(ReflectionMethod $fromMethod, ReflectionMethod $toMethod) : Changes
21			{
22			$visibilityFrom = $this->methodVisibility($fromMethod);
23			$visibilityTo = $this->methodVisibility($toMethod);
24
25			// Works because private, protected and public are sortable:
26			if ($visibilityFrom <= $visibilityTo) {
27			return Changes::empty();
28			}
29
30			return Changes::fromList(Change::changed(
31			sprintf(
32			'Method %s() of class %s visibility reduced from %s to %s',
33			$fromMethod->getName(),
34			$fromMethod->getDeclaringClass()->getName(),
35			$visibilityFrom,
36			$visibilityTo
37			),
38			true
39			));
40			}
41
42			private function methodVisibility(ReflectionMethod $method) : string
43			{
44			if ($method->isPublic()) {
45			return self::VISIBILITY_PUBLIC;
46			}
47
48			if ($method->isProtected()) {
49			return self::VISIBILITY_PROTECTED;
50			}
51
52			return self::VISIBILITY_PRIVATE;
53			}
54			}
55

Roave / BackwardCompatibilityCheck

MethodVisibilityReduced::methodVisibility() A last analyzed 2020-06-22 08:59 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

MethodVisibilityReduced::methodVisibility() A
last analyzed 2020-06-22 08:59 UTC