Conditions | 38 |
Paths | 34 |
Total Lines | 129 |
Code Lines | 72 |
Lines | 40 |
Ratio | 31.01 % |
Changes | 6 | ||
Bugs | 3 | Features | 4 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
152 | public static function callProviderMethod( $operation, array $option = [ ] ) |
||
153 | { |
||
154 | // プロバイダのインスタンスを取得し、認証ロジックをコール |
||
155 | $call_provider = self::getProvider(); |
||
156 | $provider = new $call_provider; |
||
157 | |||
158 | switch ($operation) { |
||
159 | // 初期化 |
||
160 | case 'init': |
||
161 | /** @noinspection PhpUndefinedMethodInspection */ |
||
162 | $retval = $provider->init(); |
||
163 | break; |
||
164 | |||
165 | // 認証 |
||
166 | case 'doAuth': |
||
167 | /** @noinspection PhpUndefinedMethodInspection */ |
||
168 | if (isset( $option[ 'userid' ] ) and isset( $option[ 'password' ] )) { |
||
169 | // メソッドをコール |
||
170 | /** @noinspection PhpUndefinedMethodInspection */ |
||
171 | $retval = $provider->doAuth( $option[ 'userid' ], $option[ 'password' ], $option ); |
||
172 | } else { |
||
173 | $retval = false; |
||
174 | } |
||
175 | break; |
||
176 | |||
177 | // ユーザ追加/変更 |
||
178 | case 'addUser': // FALL THRU |
||
179 | View Code Duplication | case 'modUser': |
|
|
|||
180 | // パラメタのチェック |
||
181 | if (isset( $option[ 'userid' ] ) and isset( $option[ 'username' ] ) and isset( $option[ 'password' ] ) and isset( $option[ 'groupno' ] )) { |
||
182 | // パスワードをハッシュ化したのちメソッドをコール |
||
183 | $option[ 'password' ] = self::getEncPass( $option[ 'password' ] ); |
||
184 | /** @noinspection PhpUndefinedMethodInspection */ |
||
185 | $retval = $provider->doOperation( $operation, $option ); |
||
186 | } else { |
||
187 | $retval = false; |
||
188 | } |
||
189 | break; |
||
190 | |||
191 | |||
192 | // ユーザ変更(No使用) |
||
193 | View Code Duplication | case 'modUserByNo': |
|
194 | // パラメタのチェック |
||
195 | if (isset( $option[ 'no' ] ) and isset( $option[ 'userid' ] ) and isset( $option[ 'username' ] ) and isset( $option[ 'password' ] ) and isset( $option[ 'groupno' ] )) { |
||
196 | // パスワードをハッシュ化したのちメソッドをコール |
||
197 | $option[ 'password' ] = self::getEncPass( $option[ 'password' ] ); |
||
198 | /** @noinspection PhpUndefinedMethodInspection */ |
||
199 | $retval = $provider->doOperation( $operation, $option ); |
||
200 | } else { |
||
201 | $retval = false; |
||
202 | } |
||
203 | break; |
||
204 | |||
205 | // グループ追加/変更 |
||
206 | case 'addGroup': // FALL THRU |
||
207 | View Code Duplication | case 'modGroup': |
|
208 | // パラメタのチェック |
||
209 | if (isset( $option[ 'groupid' ] ) and isset( $option[ 'groupname' ] )) { |
||
210 | /** @noinspection PhpUndefinedMethodInspection */ |
||
211 | $retval = $provider->doOperation( $operation, $option ); |
||
212 | } else { |
||
213 | $retval = false; |
||
214 | } |
||
215 | break; |
||
216 | |||
217 | // グループ変更(No使用) |
||
218 | View Code Duplication | case 'modGroupByNo': |
|
219 | // パラメタのチェック |
||
220 | if (isset( $option[ 'no' ] ) and isset( $option[ 'groupid' ] ) and isset( $option[ 'groupname' ] )) { |
||
221 | /** @noinspection PhpUndefinedMethodInspection */ |
||
222 | $retval = $provider->doOperation( $operation, $option ); |
||
223 | } else { |
||
224 | $retval = false; |
||
225 | } |
||
226 | break; |
||
227 | |||
228 | // ユーザ削除/情報表示 |
||
229 | case 'delUser': // FALL THRU |
||
230 | case 'showUser': |
||
231 | // パラメタのチェック |
||
232 | if (isset( $option[ 'userid' ] )) { |
||
233 | /** @noinspection PhpUndefinedMethodInspection */ |
||
234 | $retval = $provider->doOperation( $operation, $option ); |
||
235 | } else { |
||
236 | $retval = false; |
||
237 | } |
||
238 | break; |
||
239 | |||
240 | // グループ削除/情報表示 |
||
241 | case 'delGroup': // FALL THRU |
||
242 | case 'showGroup': |
||
243 | // パラメタのチェック |
||
244 | if (isset( $option[ 'groupid' ] )) { |
||
245 | /** @noinspection PhpUndefinedMethodInspection */ |
||
246 | $retval = $provider->doOperation( $operation, $option ); |
||
247 | } else { |
||
248 | $retval = false; |
||
249 | } |
||
250 | break; |
||
251 | |||
252 | // ユーザ/グループNo削除/表示 |
||
253 | case 'delUserByNo': |
||
254 | case 'delGroupByNo': |
||
255 | case 'showUserByNo': |
||
256 | case 'showGroupByNo': |
||
257 | // パラメタのチェック |
||
258 | if (isset( $option[ 'no' ] )) { |
||
259 | /** @noinspection PhpUndefinedMethodInspection */ |
||
260 | $retval = $provider->doOperation( $operation, $option ); |
||
261 | } else { |
||
262 | $retval = false; |
||
263 | } |
||
264 | break; |
||
265 | |||
266 | // ユーザ/グループ情報全件表示 |
||
267 | case 'showUserAll': // FALL THRU |
||
268 | case 'showGroupAll': |
||
269 | /** @noinspection PhpUndefinedMethodInspection */ |
||
270 | $retval = $provider->doOperation( $operation, [ ] ); |
||
271 | break; |
||
272 | |||
273 | // 未定義の場合はfalseを返す |
||
274 | default: |
||
275 | $retval = false; |
||
276 | break; |
||
277 | } |
||
278 | |||
279 | return $retval; |
||
280 | } |
||
281 | } |
||
282 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.