ModPreload - Code Metrics - Risoluto/Risoluto-Core - Measure and Improve Code Quality continuously with Scrutinizer

ModPreload A
last analyzed 2016-08-30 07:00 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	53
Duplicated Lines	20.75 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes	2
Bugs	1	Features	2

Metric	Value
wmc	3
c	2
b	1
f	2
lcom	0
cbo	5
dl	11
loc	53
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
B	play()	11	38	3

How to fix Duplicated Code

<?php
/**
 * ModPreload
 *
 * ユーザ情報変更処理を実現するためのクラス
 *
 * @package           risoluto
 * @author            Risoluto Developers
 * @license           http://opensource.org/licenses/bsd-license.php new BSD license
 * @copyright     (C) 2008-2015 Risoluto Developers / All Rights Reserved.
 */

//------------------------------------------------------//
// 名前空間の定義
//------------------------------------------------------//
namespace RisolutoApps\Admin\UserMng;

//------------------------------------------------------//
// クラス定義
//------------------------------------------------------//
class ModPreload extends \Risoluto\RisolutoControllerBase implements \Risoluto\RisolutoControllerInterface
{
    /**
     * play()
     *
     * 主処理を行う
     *
     * @access    public
     *
     * @param     void
     *
     * @return    void    なし
     * @throws    \Exception 必須な情報が渡されていないか情報が取得できない場合はThrow
     */
    public function play()
    {
        // セッションをスタート
        $sess = new \Risoluto\Session();
        $sess->start();

        // 共通処理クラスを呼び出し
        $common = new \RisolutoApps\Admin\AdminCommon;
        /** @noinspection PhpUnusedLocalVariableInspection */
        $detail = $common->loginCheck( $sess, true );
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $param = $this->getParam();
        if (is_numeric( $param[ 0 ] )) {

            // 引数値がセットされていれば、それを元に登録情報を呼び出す
            $target = \Risoluto\Auth::callProviderMethod( 'showUserByNo', [ 'no' => $param[ 0 ] ] );
            if (empty( $target )) {
                // 情報が取得できなかった場合も例外をThrow
                Throw new \Exception( 'Cannot load user data' );
            }
        } else {
            // 指定されていなければ例外をThrowする
            Throw new \Exception( 'Require args not found' );
        }

        // 情報が取得できたら整形してセッションに保存、入力画面へ遷移する
        $getVals[ 'entered' ] = [
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            'no' => $target[ 0 ][ 'no' ],
            'userid' => $target[ 0 ][ 'userid' ],
            'username' => $target[ 0 ][ 'username' ],
            'password' => '',
            'password_confirm' => '',
            'groupno' => $target[ 0 ][ 'groupno' ],
            'status' => $target[ 0 ][ 'status' ]
        ];
        $sess->store( 'form', $getVals );
        \Risoluto\Url::redirectTo( 'Admin_UserMng_ModEntry' );
        exit;
    }
}

1		<?php
2		/**
3		* ModPreload
4		*
5		* ユーザ情報変更処理を実現するためのクラス
6		*
7		* @package risoluto
8		* @author Risoluto Developers
9		* @license http://opensource.org/licenses/bsd-license.php new BSD license
10		* @copyright (C) 2008-2015 Risoluto Developers / All Rights Reserved.
11		*/
12
13		//------------------------------------------------------//
14		// 名前空間の定義
15		//------------------------------------------------------//
16		namespace RisolutoApps\Admin\UserMng;
17
18		//------------------------------------------------------//
19		// クラス定義
20		//------------------------------------------------------//
21		class ModPreload extends \Risoluto\RisolutoControllerBase implements \Risoluto\RisolutoControllerInterface
22		{
23		/**
24		* play()
25		*
26		* 主処理を行う
27		*
28		* @access public
29		*
30		* @param void
31		*
32		* @return void なし
33		* @throws \Exception 必須な情報が渡されていないか情報が取得できない場合はThrow
34		*/
35		public function play()
36		{
37		// セッションをスタート
38		$sess = new \Risoluto\Session();
39		$sess->start();
40
41		// 共通処理クラスを呼び出し
42		$common = new \RisolutoApps\Admin\AdminCommon;
43		/** @noinspection PhpUnusedLocalVariableInspection */
44		$detail = $common->loginCheck( $sess, true );
		0 ignored issues – show Unused Code introduced 2016-01-12 23:50 UTC by Report Bug Copy Issue Report `$detail` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
45
46		$param = $this->getParam();
47	View Code Duplication	if (is_numeric( $param[ 0 ] )) {
		0 ignored issues – show Duplication introduced 2016-01-12 23:50 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
48		// 引数値がセットされていれば、それを元に登録情報を呼び出す
49		$target = \Risoluto\Auth::callProviderMethod( 'showUserByNo', [ 'no' => $param[ 0 ] ] );
50		if (empty( $target )) {
51		// 情報が取得できなかった場合も例外をThrow
52		Throw new \Exception( 'Cannot load user data' );
53		}
54		} else {
55		// 指定されていなければ例外をThrowする
56		Throw new \Exception( 'Require args not found' );
57		}
58
59		// 情報が取得できたら整形してセッションに保存、入力画面へ遷移する
60		$getVals[ 'entered' ] = [
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-01-12 23:50 UTC by Report Bug Copy Issue Report `$getVals` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$getVals = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
61		'no' => $target[ 0 ][ 'no' ],
62		'userid' => $target[ 0 ][ 'userid' ],
63		'username' => $target[ 0 ][ 'username' ],
64		'password' => '',
65		'password_confirm' => '',
66		'groupno' => $target[ 0 ][ 'groupno' ],
67		'status' => $target[ 0 ][ 'status' ]
68		];
69		$sess->store( 'form', $getVals );
70		\Risoluto\Url::redirectTo( 'Admin_UserMng_ModEntry' );
71		exit;
72		}
73		}

Risoluto / Risoluto-Core

ModPreload A last analyzed 2016-08-30 07:00 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

ModPreload A
last analyzed 2016-08-30 07:00 UTC