Issues in UriTest.php (master) - Issues in master - RickyNRoses87/almendra-psr7 - Measure and Improve Code Quality continuously with Scrutinizer

Issues (42)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/UriTest.php (4 issues)

Labels

Severity

Major 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Test;

use Almendra\Http\Psr\Messages\Uri;
use Test\DummyObject;

class UriTest extends \PHPUnit_Framework_TestCase
{
    protected $uri;

    public function __construct()
    {
        $this->uri = new Uri;
    }

    /**
     * @test
     *
     * Test that it gets the scheme properly
     */
    public function it_gets_the_proper_scheme()
    {
        $this -> assertEquals($this -> uri -> withScheme('this is a sample scheme') -> getScheme(),
            'this is a sample scheme');
    }

    /**
     * @test
     *
     * Test that it returns the Uri as a string
     */
    public function it_returns_the_uri_as_a_string()
    {
        $uriStr = 'test uri';
        $newUri = new Uri($uriStr);

        $this -> assertEquals($newUri, $uriStr);
    }

    /**
     * @test
     *
     * Test that it returns a new instance of the Uri with the specified fragment
     */
    public function it_returns_the_specified_uri_fragment()
    {
        $fragment = 'some test fragment here';
        $newUri = $this -> uri -> withFragment($fragment);

        // fails
        $this -> assertFalse($this -> uri -> getFragment() === $fragment);

        // passes
        $this -> assertTrue($newUri -> getFragment() === $fragment);

        // passes --diff instance
        $this -> assertEquals($this -> uri === $newUri, false);
    }

    /**
     * @test
     *
     * Test that it returns the specified query string
     */
    public function it_returns_the_specified_query_string()
    {
        $query = 'some test query string here';
        $newUri = $this -> uri -> withQuery($query);

        // fails
        $this -> assertFalse($this -> uri -> getQuery() === $query);

        // passes
        $this -> assertTrue($newUri -> getQuery() === $query);

        // passes --diff instance
        $this -> assertEquals($this -> uri === $newUri, false);
    }

    /**
     * @test
     *
     * Test that it validates the query string
     */
    public function it_validates_the_query_string()
    {
        $query = 2323; // throws \InvalidArgumentException

        try {
            $newUri = $this -> uri -> withQuery($query);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } catch (\InvalidArgumentException $e) {
            $result = true;
        }

        $this -> assertTrue($result);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

        // implements __toString() --throws no exception
        $queryObject = new DummyObject($query);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        try {
            $newUri = $this -> uri -> withQuery($query);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } catch (\InvalidArgumentException $e) {
            $result = false;
        }

        $this -> assertFalse($result);
    }


    // path validity
    // withpath()
    // withHost()
    // withPort()
    //
}


1			<?php
2
3			namespace Test;
4
5			use Almendra\Http\Psr\Messages\Uri;
6			use Test\DummyObject;
7
8			class UriTest extends \PHPUnit_Framework_TestCase
9			{
10			protected $uri;
11
12			public function __construct()
13			{
14			$this->uri = new Uri;
15			}
16
17			/**
18			* @test
19			*
20			* Test that it gets the scheme properly
21			*/
22			public function it_gets_the_proper_scheme()
23			{
24			$this -> assertEquals($this -> uri -> withScheme('this is a sample scheme') -> getScheme(),
25			'this is a sample scheme');
26			}
27
28			/**
29			* @test
30			*
31			* Test that it returns the Uri as a string
32			*/
33			public function it_returns_the_uri_as_a_string()
34			{
35			$uriStr = 'test uri';
36			$newUri = new Uri($uriStr);
37
38			$this -> assertEquals($newUri, $uriStr);
39			}
40
41			/**
42			* @test
43			*
44			* Test that it returns a new instance of the Uri with the specified fragment
45			*/
46			public function it_returns_the_specified_uri_fragment()
47			{
48			$fragment = 'some test fragment here';
49			$newUri = $this -> uri -> withFragment($fragment);
50
51			// fails
52			$this -> assertFalse($this -> uri -> getFragment() === $fragment);
53
54			// passes
55			$this -> assertTrue($newUri -> getFragment() === $fragment);
56
57			// passes --diff instance
58			$this -> assertEquals($this -> uri === $newUri, false);
59			}
60
61			/**
62			* @test
63			*
64			* Test that it returns the specified query string
65			*/
66			public function it_returns_the_specified_query_string()
67			{
68			$query = 'some test query string here';
69			$newUri = $this -> uri -> withQuery($query);
70
71			// fails
72			$this -> assertFalse($this -> uri -> getQuery() === $query);
73
74			// passes
75			$this -> assertTrue($newUri -> getQuery() === $query);
76
77			// passes --diff instance
78			$this -> assertEquals($this -> uri === $newUri, false);
79			}
80
81			/**
82			* @test
83			*
84			* Test that it validates the query string
85			*/
86			public function it_validates_the_query_string()
87			{
88			$query = 2323; // throws \InvalidArgumentException
89
90			try {
91			$newUri = $this -> uri -> withQuery($query);
			0 ignored issues – show Unused Code introduced 2016-10-15 03:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$newUri` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
92			} catch (\InvalidArgumentException $e) {
93			$result = true;
94			}
95
96			$this -> assertTrue($result);
			0 ignored issues – show Bug introduced 2016-10-12 02:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$result` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
97
98			// implements __toString() --throws no exception
99			$queryObject = new DummyObject($query);
			0 ignored issues – show Unused Code introduced 2016-10-12 02:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$queryObject` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
100			try {
101			$newUri = $this -> uri -> withQuery($query);
			0 ignored issues – show Unused Code introduced 2016-10-12 02:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$newUri` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
102			} catch (\InvalidArgumentException $e) {
103			$result = false;
104			}
105
106			$this -> assertFalse($result);
107			}
108
109
110			// path validity
111			// withpath()
112			// withHost()
113			// withPort()
114			//
115			}
116

RickyNRoses87 / almendra-psr7

Issues (42)

Security Analysis not enabled

tests/UriTest.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like