Server::getValues() - Code Metrics - Inspection of "Stream --init" - RickyNRoses87/almendra-psr7 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bc72c5...1b234b )

by richard

created 2016-10-15 03:28 UTC

Server::getValues() A

↳ Parent: Server

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
c	0
b	0
f	0
rs	10
cc	1
eloc	1
nc	1
nop	0

<?php

namespace Almendra\Http;

use Almendra\Http\Interfaces\ServerInterface;

class Server implements ServerInterface
{
    /**
     * Retrieves a value defined in the superglobal $_SERVER.
     *
     * @param string $value 		The key's name.
     * @return string|mixed
     */
    public static function getValue($value, $default = '')
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (array_key_exists($value, $_SERVER)) {
            return $_SERVER[$value];
        }

        return $default;
    }

    /**
     * Retrieves all values defined in the superglobal $_SERVER.
     *
     * @param string $value         The key's name.
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return string|mixed
     */
    public static function getValues()
    {
        //
    }


    public function get()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $this -> _fields = $_GET;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        return $this;
    }

    public function post()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $this -> _fields = $_POST;
        return $this;
    }

    public function files()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $this -> _fields = $_FILES;
        return $this;
    }

    public function all()
    {
        return $this -> _fields;
    }
}


1			<?php
2
3			namespace Almendra\Http;
4
5			use Almendra\Http\Interfaces\ServerInterface;
6
7			class Server implements ServerInterface
8			{
9			/**
10			* Retrieves a value defined in the superglobal $_SERVER.
11			*
12			* @param string $value The key's name.
13			* @return string\|mixed
14			*/
15			public static function getValue($value, $default = '')
			0 ignored issues – show Coding Style introduced 2016-10-12 02:53 UTC by Report Bug Copy Issue Report `getValue` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
16			{
17			if (array_key_exists($value, $_SERVER)) {
18			return $_SERVER[$value];
19			}
20
21			return $default;
22			}
23
24			/**
25			* Retrieves all values defined in the superglobal $_SERVER.
26			*
27			* @param string $value The key's name.
			0 ignored issues – show Bug introduced 2016-10-15 03:31 UTC by Report Bug Copy Issue Report There is no parameter named `$value`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
28			* @return string\|mixed
29			*/
30			public static function getValues()
31			{
32			//
33			}
34
35
36			public function get()
			0 ignored issues – show Coding Style introduced 2016-10-12 02:53 UTC by Report Bug Copy Issue Report `get` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
37			{
38			$this -> _fields = $_GET;
			0 ignored issues – show Bug introduced 2016-10-12 02:53 UTC by Report Bug Copy Issue Report The property `_fields` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
39			return $this;
40			}
41
42			public function post()
			0 ignored issues – show Coding Style introduced 2016-10-12 02:53 UTC by Report Bug Copy Issue Report `post` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
43			{
44			$this -> _fields = $_POST;
45			return $this;
46			}
47
48			public function files()
			0 ignored issues – show Coding Style introduced 2016-10-12 02:53 UTC by Report Bug Copy Issue Report `files` uses the super-global variable `$_FILES` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
49			{
50			$this -> _fields = $_FILES;
51			return $this;
52			}
53
54			public function all()
55			{
56			return $this -> _fields;
57			}
58			}
59

RickyNRoses87 / almendra-psr7

Push — master ( bc72c5...1b234b )

Server::getValues() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like