Server - Code Metrics - Inspection of "completed Server class" - RickyNRoses87/almendra-psr7 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ffc015...ec0266 )

by richard

created 2016-11-01 08:46 UTC

Server A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	140
Duplicated Lines	27.86 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

Metric	Value
dl	39
loc	140
c	0
b	0
f	0
wmc	24
lcom	0
cbo	0
rs	10

8 Methods

Rating	Name	Duplication	Size	Complexity
A	getValue()	0	8	2
A	getValues()	0	4	1
A	get()	0	8	2
B	gets()	13	13	5
A	post()	0	8	2
B	posts()	13	13	5
A	file()	0	8	2
B	files()	13	13	5

How to fix Duplicated Code

<?php

namespace Almendra\Http;

use Almendra\Http\Interfaces\ServerInterface;

/**
 * A wrapper for the superglobals $_SERVER, $_GET and $_POST.
 *
 * @package Almendra\PSR7    
 * @author     Richard Trujillo Torres     <[email protected]>
 */
class Server implements ServerInterface
{
    /**
     * Retrieves a value defined in the superglobal $_SERVER.
     *
     * @param string $value 		The key's name.
     * @return string|mixed
     */
    public static function getValue($value, $default = '')
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (array_key_exists($value, $_SERVER)) {
            return $_SERVER[$value];
        }

        return $default;
    }

    /**
     * Retrieves all values defined in the superglobal $_SERVER.
     *
     * @return string|mixed
     */
    public static function getValues()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        return $_SERVER;
    }


    /**
     * Returns a value from the $_GET superglobal.
     * Null if none exists.
     *
     * @param string $name         The value's name
     * @return mixed                 
     */
    public static function get($name)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (isset($_GET[$name])) {
            return $_GET[$name];
        }

        return null;
    }

    /**
     * Returns all values from the $_GET superglobal.
     * Null if none exists.
     *
     * @param string $name         
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return mixed                 
     */
    public static function gets(array $values = null)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $fields = [];
        if (isset($values) && null !== $values) {
            foreach ($values as $name) {
                $fields[] = self::get($name);
            }

            return $fields;
        } 

        return isset($_GET) ? $_GET : null;
    }

    /**
     * Returns a value from the $_POST superglobal.
     * Null if none exists.
     *
     * @param string $name         The value's name
     * @return mixed                 
     */
    public static function post($name)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (isset($_POST[$name])) {
            return $_POST[$name];
        }

        return null;
    }

    /**
     * Returns all values from the $_POST superglobal.
     * Null if none exists.
     *
     * @param string $name         
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return mixed                 
     */
    public static function posts(array $values = null)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $fields = [];
        if (isset($values) && null !== $values) {
            foreach ($values as $name) {
                $fields[] = self::post($name);
            }

            return $fields;
        } 

        return isset($_POST) ? $_POST : null;
    }

    /**
     * Returns a value from the $_FILES superglobal.
     * Null if none exists.
     *
     * @param string $name         The value's name
     * @return mixed                 
     */
    public static function file($name)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (isset($_FILES[$name])) {
            return $_FILES[$name];
        }

        return null;
    }

    /**
     * Returns all values from the $_FILES superglobal.
     * Null if none exists.
     *
     * @param string $name         
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return mixed                 
     */
    public static function files(array $values = null)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $fields = [];
        if (isset($values) && null !== $values) {
            foreach ($values as $name) {
                $fields[] = self::file($name);
            }

            return $fields;
        } 

        return isset($_FILES) ? $_FILES : null;
    }

}


1		<?php
2
3		namespace Almendra\Http;
4
5		use Almendra\Http\Interfaces\ServerInterface;
6
7		/**
8		* A wrapper for the superglobals $_SERVER, $_GET and $_POST.
9		*
10		* @package Almendra\PSR7
11		* @author Richard Trujillo Torres <[email protected]>
12		*/
13		class Server implements ServerInterface
14		{
15		/**
16		* Retrieves a value defined in the superglobal $_SERVER.
17		*
18		* @param string $value The key's name.
19		* @return string\|mixed
20		*/
21		public static function getValue($value, $default = '')
		0 ignored issues – show Coding Style introduced 2016-10-12 02:53 UTC by Report Bug Copy Issue Report `getValue` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
22		{
23		if (array_key_exists($value, $_SERVER)) {
24		return $_SERVER[$value];
25		}
26
27		return $default;
28		}
29
30		/**
31		* Retrieves all values defined in the superglobal $_SERVER.
32		*
33		* @return string\|mixed
34		*/
35		public static function getValues()
		0 ignored issues – show Coding Style introduced 2016-11-01 08:48 UTC by Report Bug Copy Issue Report `getValues` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
36		{
37		return $_SERVER;
38		}
39
40
41		/**
42		* Returns a value from the $_GET superglobal.
43		* Null if none exists.
44		*
45		* @param string $name The value's name
46		* @return mixed
47		*/
48		public static function get($name)
		0 ignored issues – show Coding Style introduced 2016-11-01 08:48 UTC by Report Bug Copy Issue Report `get` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
49		{
50		if (isset($_GET[$name])) {
51		return $_GET[$name];
52		}
53
54		return null;
55		}
56
57		/**
58		* Returns all values from the $_GET superglobal.
59		* Null if none exists.
60		*
61		* @param string $name
		0 ignored issues – show Bug introduced 2016-11-01 08:48 UTC by Report Bug Copy Issue Report There is no parameter named `$name`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
62		* @return mixed
63		*/
64	View Code Duplication	public static function gets(array $values = null)
		0 ignored issues – show Duplication introduced 2016-11-01 08:48 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style introduced 2016-11-01 08:48 UTC by Report Bug Copy Issue Report `gets` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
65		{
66		$fields = [];
67		if (isset($values) && null !== $values) {
68		foreach ($values as $name) {
69		$fields[] = self::get($name);
70		}
71
72		return $fields;
73		}
74
75		return isset($_GET) ? $_GET : null;
76		}
77
78		/**
79		* Returns a value from the $_POST superglobal.
80		* Null if none exists.
81		*
82		* @param string $name The value's name
83		* @return mixed
84		*/
85		public static function post($name)
		0 ignored issues – show Coding Style introduced 2016-11-01 08:48 UTC by Report Bug Copy Issue Report `post` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
86		{
87		if (isset($_POST[$name])) {
88		return $_POST[$name];
89		}
90
91		return null;
92		}
93
94		/**
95		* Returns all values from the $_POST superglobal.
96		* Null if none exists.
97		*
98		* @param string $name
		0 ignored issues – show Bug introduced 2016-11-01 08:48 UTC by Report Bug Copy Issue Report There is no parameter named `$name`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
99		* @return mixed
100		*/
101	View Code Duplication	public static function posts(array $values = null)
		0 ignored issues – show Duplication introduced 2016-11-01 08:48 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style introduced 2016-11-01 08:48 UTC by Report Bug Copy Issue Report `posts` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
102		{
103		$fields = [];
104		if (isset($values) && null !== $values) {
105		foreach ($values as $name) {
106		$fields[] = self::post($name);
107		}
108
109		return $fields;
110		}
111
112		return isset($_POST) ? $_POST : null;
113		}
114
115		/**
116		* Returns a value from the $_FILES superglobal.
117		* Null if none exists.
118		*
119		* @param string $name The value's name
120		* @return mixed
121		*/
122		public static function file($name)
		0 ignored issues – show Coding Style introduced 2016-11-01 08:48 UTC by Report Bug Copy Issue Report `file` uses the super-global variable `$_FILES` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
123		{
124		if (isset($_FILES[$name])) {
125		return $_FILES[$name];
126		}
127
128		return null;
129		}
130
131		/**
132		* Returns all values from the $_FILES superglobal.
133		* Null if none exists.
134		*
135		* @param string $name
		0 ignored issues – show Bug introduced 2016-11-01 08:48 UTC by Report Bug Copy Issue Report There is no parameter named `$name`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
136		* @return mixed
137		*/
138	View Code Duplication	public static function files(array $values = null)
		0 ignored issues – show Duplication introduced 2016-11-01 08:48 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style introduced 2016-11-01 08:48 UTC by Report Bug Copy Issue Report `files` uses the super-global variable `$_FILES` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
139		{
140		$fields = [];
141		if (isset($values) && null !== $values) {
142		foreach ($values as $name) {
143		$fields[] = self::file($name);
144		}
145
146		return $fields;
147		}
148
149		return isset($_FILES) ? $_FILES : null;
150		}
151
152		}
153

RickyNRoses87 / almendra-psr7

Push — master ( ffc015...ec0266 )

Server A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

8 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like