Richtermeister / symfony-shopify-bundle

src/Api/Endpoint/CollectEndpoint.php

<?php
namespace CodeCloud\Bundle\ShopifyBundle\Api\Endpoint;

use CodeCloud\Bundle\ShopifyBundle\Api\Request\DeleteParams;
use CodeCloud\Bundle\ShopifyBundle\Api\Request\GetJson;
use CodeCloud\Bundle\ShopifyBundle\Api\Request\PostJson;
use CodeCloud\Bundle\ShopifyBundle\Api\GenericResource;

class CollectEndpoint extends AbstractEndpoint
{
    /**
     * @param array $query
     * @return array|GenericResource[]
     */
    public function findAll(array $query = array())
    {
        $request = new GetJson('/admin/collects.json', $query);
        $response = $this->sendPaged($request, 'collects');
        return $this->createCollection($response);
    }

    /**
     * @param array $query
     * @return int
     */
    public function countAll(array $query = array())
    {
        $request = new GetJson('/admin/collects/count.json', $query);
        $response = $this->send($request);
        return $response->get('count');

The expression return $response->get('count') also could return the type string which is incompatible with the documented return type integer.

    }

    /**
     * @param int $collectId
     * @return GenericResource
     */
    public function findOne($collectId)
    {
        $request = new GetJson('/admin/collects/' . $collectId . '.json');
        $response = $this->send($request);
        return $this->createEntity($response->get('collect'));

It seems like $response->get('collect') can also be of type string; however, parameter $data of CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\AbstractEndpoint::createEntity() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param GenericResource $collect
     * @return GenericResource
     */
    public function create(GenericResource $collect)
    {
        $request = new PostJson('/admin/collects.json', array('collect' => $collect->toArray()));
        $response = $this->send($request);
        return $this->createEntity($response->get('collect'));

It seems like $response->get('collect') can also be of type string; however, parameter $data of CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\AbstractEndpoint::createEntity() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param int $collectId
     */
    public function delete($collectId)
    {
        $request = new DeleteParams('/admin/collects/' . $collectId . '.json');
        $this->send($request);
    }
}