Richtermeister / symfony-shopify-bundle

src/Api/Endpoint/AssetEndpoint.php

<?php
namespace CodeCloud\Bundle\ShopifyBundle\Api\Endpoint;

use CodeCloud\Bundle\ShopifyBundle\Api\Request\DeleteParams;
use CodeCloud\Bundle\ShopifyBundle\Api\Request\GetJson;
use CodeCloud\Bundle\ShopifyBundle\Api\Request\PutJson;

class AssetEndpoint extends AbstractEndpoint
{
    public function findByTheme($themeId, array $fields = array())
    {
        $params = array();

        if ($fields) {

The expression $fields of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $params['fields'] = implode(',', $fields);
        }

        $request = new GetJson('/admin/themes/' . $themeId . '/assets.json', $params);
        $response = $this->send($request);
        return $response->get('assets');
    }

    /**
     * @param int $themeId
     * @param string $assetPath
     * @return GenericEntity

The type CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\GenericEntity was not found. Maybe you did not declare it correctly or list all dependencies?

     */
    public function findOne($themeId, $assetPath)
    {
        $params = array(
            'asset[key]' => $assetPath,
            'theme_id'   => $themeId
        );

        $request = new GetJson('/admin/themes/' . $themeId . '/assets.json', $params);
        $response = $this->send($request);
        return $this->createEntity($response->get('asset'));

The expression return $this->createEntity($response->get('asset')) returns the type CodeCloud\Bundle\ShopifyBundle\Api\GenericResource which is incompatible with the documented return type CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\GenericEntity.

It seems like $response->get('asset') can also be of type string; however, parameter $data of CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\AbstractEndpoint::createEntity() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param int $themeId
     * @param string $assetPath
     * @param string $templateContent
     * @return GenericEntity
     */
    public function uploadTemplate($themeId, $assetPath, $templateContent)
    {
        $params = array(
            'asset' => array(
                'key'   => $assetPath,
                'value' => $templateContent
            )
        );

        $request = new PutJson('/admin/themes/' . $themeId . '/assets.json', $params);
        $response = $this->send($request);
        return $this->createEntity($response->get('asset'));

The expression return $this->createEntity($response->get('asset')) returns the type CodeCloud\Bundle\ShopifyBundle\Api\GenericResource which is incompatible with the documented return type CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\GenericEntity.

It seems like $response->get('asset') can also be of type string; however, parameter $data of CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\AbstractEndpoint::createEntity() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param int $themeId
     * @param string $assetPath
     * @param string $binary
     * @return GenericEntity
     */
    public function uploadBinaryFile($themeId, $assetPath, $binary)
    {
        $params = array(
            'asset' => array(
                'key'   => $assetPath,
                'attachment' => base64_encode($binary)
            )
        );

        $request = new PutJson('/admin/themes/' . $themeId . '/assets.json', $params);
        $response = $this->send($request);
        return $this->createEntity($response->get('asset'));

The expression return $this->createEntity($response->get('asset')) returns the type CodeCloud\Bundle\ShopifyBundle\Api\GenericResource which is incompatible with the documented return type CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\GenericEntity.

It seems like $response->get('asset') can also be of type string; however, parameter $data of CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\AbstractEndpoint::createEntity() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param int $themeId
     * @param string $assetPath
     * @param string $remoteFileUrl
     * @return GenericEntity
     */
    public function uploadRemoteFile($themeId, $assetPath, $remoteFileUrl)
    {
        $params = array(
            'asset' => array(
                'key' => $assetPath,
                'src' => $remoteFileUrl
            )
        );

        $request = new PutJson('/admin/themes/' . $themeId . '/assets.json', $params);
        $response = $this->send($request);
        return $this->createEntity($response->get('asset'));

The expression return $this->createEntity($response->get('asset')) returns the type CodeCloud\Bundle\ShopifyBundle\Api\GenericResource which is incompatible with the documented return type CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\GenericEntity.

It seems like $response->get('asset') can also be of type string; however, parameter $data of CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\AbstractEndpoint::createEntity() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param int $themeId
     * @param string $assetPath
     * @param string $copySourcePath
     * @return GenericEntity
     */
    public function copy($themeId, $assetPath, $copySourcePath)
    {
        $params = array(
            'asset' => array(
                'key'        => $assetPath,
                'source_key' => $copySourcePath
            )
        );

        $request = new PutJson('/admin/themes/' . $themeId . '/assets.json', $params);
        $response = $this->send($request);
        return $this->createEntity($response->get('asset'));

The expression return $this->createEntity($response->get('asset')) returns the type CodeCloud\Bundle\ShopifyBundle\Api\GenericResource which is incompatible with the documented return type CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\GenericEntity.

It seems like $response->get('asset') can also be of type string; however, parameter $data of CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\AbstractEndpoint::createEntity() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param int $themeId
     * @param string $assetPath
     */
    public function delete($themeId, $assetPath)
    {
        $params = array(
            'asset[key]' => $assetPath,
            'theme_id'   => $themeId
        );

        $request = new DeleteParams('/admin/themes/' . $themeId . '/assets.json', $params);
        $this->send($request);
    }
}