Richtermeister / symfony-shopify-bundle

src/Api/Endpoint/ApplicationChargeEndpoint.php

<?php
namespace CodeCloud\Bundle\ShopifyBundle\Api\Endpoint;

use CodeCloud\Bundle\ShopifyBundle\Api\Request\GetJson;
use CodeCloud\Bundle\ShopifyBundle\Api\Request\PostJson;
use CodeCloud\Bundle\ShopifyBundle\Api\GenericResource;

class ApplicationChargeEndpoint extends AbstractEndpoint
{
    /**
     * @param array $query
     * @return GenericResource[]
     */
    public function findAll(array $query = array())
    {
        $request = new GetJson('/admin/application_charges.json', $query);
        $response = $this->send($request);
        return $this->createCollection($response->get('application_charges'));

It seems like $response->get('application_charges') can also be of type string; however, parameter $items of CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\AbstractEndpoint::createCollection() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param int $applicationChargeId
     * @return GenericResource
     */
    public function findOne($applicationChargeId)
    {
        $request = new GetJson('/admin/application_charges/' . $applicationChargeId . '.json');
        $response = $this->send($request);
        return $this->createEntity($response->get('application_charge'));

It seems like $response->get('application_charge') can also be of type string; however, parameter $data of CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\AbstractEndpoint::createEntity() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param GenericResource $applicationCharge
     * @return GenericResource
     */
    public function create(GenericResource $applicationCharge)
    {
        $request = new PostJson('/admin/application_charges.json', array('application_charge' => $applicationCharge->toArray()));
        $response = $this->send($request);
        return $this->createEntity($response->get('application_charge'));

It seems like $response->get('application_charge') can also be of type string; however, parameter $data of CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\AbstractEndpoint::createEntity() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param int $applicationChargeId
     */
    public function activate($applicationChargeId)
    {
        $request = new PostJson('/admin/application_charges/' . $applicationChargeId . '/activate.json', null);
        $this->send($request);
    }
}