WebhookCreatorEventBridge::createWebhooks() - Code Metrics - Inspection of "Upgrade to Symfony 5" - Richtermeister/symfony-shopify-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#9)

by Daniel

created 2020-12-30 06:24 UTC

WebhookCreatorEventBridge::createWebhooks() A

↳ Parent: WebhookCreatorEventBridge

Complexity

Conditions	4
Paths	4

Size

Total Lines	19
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	4
eloc	12
c	1
b	0
f	1
nc	4
nop	2
dl	0
loc	19
rs	9.8666

<?php

namespace CodeCloud\Bundle\ShopifyBundle\Service;

use CodeCloud\Bundle\ShopifyBundle\Api\GenericResource;
use CodeCloud\Bundle\ShopifyBundle\Api\ShopifyApiFactory;
use GuzzleHttp\Exception\ClientException;
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;

/**
 * Creates EventBridge Webhooks.
 */
class WebhookCreatorEventBridge implements WebhookCreatorInterface
{
    /**
     * @var ShopifyApiFactory
     */
    private $apis;

    /**
     * @var string
     */
    private $eventBridgeArn;

    public function __construct(ShopifyApiFactory $apis, string $eventBridgeArn)
    {
        $this->apis = $apis;
        $this->eventBridgeArn = $eventBridgeArn;
    }

    /**
     * {@inheritdoc}
     */
    public function createWebhooks(string $storeName, array $topics)
    {
        $api = $this->apis->getForStore($storeName);

        foreach ($topics as $topic) {
            $webhook = GenericResource::create([
                'topic' => $topic,
                'address' => $this->eventBridgeArn,
                'format' => 'json',
            ]);

            try {
                $api->Webhook->create($webhook);
            } catch (ClientException $e) {
                if ($e->getResponse()->getStatusCode() == 422) {
                    continue;
                }

                throw $e;
            }
        }
    }

    /**
     * {@inheritdoc}
     */
    public function listWebhooks(string $storeName)
    {
        $api = $this->apis->getForStore($storeName);

        return $api->Webhook->findAll();
    }

    /**
     * {@inheritdoc}
     */
    public function deleteAllWebhooks(string $storeName)
    {
        $api = $this->apis->getForStore($storeName);

        foreach ($api->Webhook->findAll() as $webhook) {
            $api->Webhook->delete($webhook['id']);
        }
    }
}


1			<?php
2
3			namespace CodeCloud\Bundle\ShopifyBundle\Service;
4
5			use CodeCloud\Bundle\ShopifyBundle\Api\GenericResource;
6			use CodeCloud\Bundle\ShopifyBundle\Api\ShopifyApiFactory;
7			use GuzzleHttp\Exception\ClientException;
8			use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
9
10			/**
11			* Creates EventBridge Webhooks.
12			*/
13			class WebhookCreatorEventBridge implements WebhookCreatorInterface
14			{
15			/**
16			* @var ShopifyApiFactory
17			*/
18			private $apis;
19
20			/**
21			* @var string
22			*/
23			private $eventBridgeArn;
24
25			public function __construct(ShopifyApiFactory $apis, string $eventBridgeArn)
26			{
27			$this->apis = $apis;
28			$this->eventBridgeArn = $eventBridgeArn;
29			}
30
31			/**
32			* {@inheritdoc}
33			*/
34			public function createWebhooks(string $storeName, array $topics)
35			{
36			$api = $this->apis->getForStore($storeName);
37
38			foreach ($topics as $topic) {
39			$webhook = GenericResource::create([
40			'topic' => $topic,
41			'address' => $this->eventBridgeArn,
42			'format' => 'json',
43			]);
44
45			try {
46			$api->Webhook->create($webhook);
47			} catch (ClientException $e) {
48			if ($e->getResponse()->getStatusCode() == 422) {
49			continue;
50			}
51
52			throw $e;
53			}
54			}
55			}
56
57			/**
58			* {@inheritdoc}
59			*/
60			public function listWebhooks(string $storeName)
61			{
62			$api = $this->apis->getForStore($storeName);
63
64			return $api->Webhook->findAll();
65			}
66
67			/**
68			* {@inheritdoc}
69			*/
70			public function deleteAllWebhooks(string $storeName)
71			{
72			$api = $this->apis->getForStore($storeName);
73
74			foreach ($api->Webhook->findAll() as $webhook) {
75			$api->Webhook->delete($webhook['id']);
76			}
77			}
78			}
79

Richtermeister / symfony-shopify-bundle

Pull Request — master (#9)

WebhookCreatorEventBridge::createWebhooks() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like