WebhookCreatorLocal::createWebhooks() - Code Metrics - Inspection of "Upgrade to Symfony 5" - Richtermeister/symfony-shopify-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#9)

by Daniel

created 2021-03-06 21:49 UTC

WebhookCreatorLocal::createWebhooks() A

↳ Parent: WebhookCreatorLocal

Complexity

Conditions	2
Paths	2

Size

Total Lines	20
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	12
nc	2
nop	2
dl	0
loc	20
rs	9.8666
c	0
b	0
f	0

<?php

namespace CodeCloud\Bundle\ShopifyBundle\Service;

use CodeCloud\Bundle\ShopifyBundle\Api\GenericResource;
use CodeCloud\Bundle\ShopifyBundle\Api\ShopifyApiFactory;
use GuzzleHttp\Exception\ClientException;
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;

/**
 * Creates Webhooks to be received by this application.
 */
class WebhookCreatorLocal extends AbstractWebhookCreator
{
    /**
     * @var UrlGeneratorInterface
     */
    private $router;

    /**
     * @param ShopifyApiFactory $apis
     * @param UrlGeneratorInterface $router
     */
    public function __construct(ShopifyApiFactory $apis, UrlGeneratorInterface $router)
    {
        $this->router = $router;

        parent::__construct($apis);
    }

    /**
     * {@inheritdoc}
     */
    public function createWebhooks(string $storeName, array $topics)
    {
        $api = $this->apis->getForStore($storeName);

        foreach ($topics as $topic) {
            $endpoint = $this->router->generate('codecloud_shopify_webhooks', [
                'store' => $storeName,
                'topic' => $topic,
            ], UrlGeneratorInterface::ABSOLUTE_URL);

            // endpoint HAS to be https
            $endpoint = str_replace("http://", "https://", $endpoint);

            $webhook = GenericResource::create([
                'topic' => $topic,
                'address' => $endpoint,
                'format' => 'json',
            ]);

            $api->Webhook->create($webhook);
        }
    }
}


1			<?php
2
3			namespace CodeCloud\Bundle\ShopifyBundle\Service;
4
5			use CodeCloud\Bundle\ShopifyBundle\Api\GenericResource;
6			use CodeCloud\Bundle\ShopifyBundle\Api\ShopifyApiFactory;
7			use GuzzleHttp\Exception\ClientException;
8			use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
9
10			/**
11			* Creates Webhooks to be received by this application.
12			*/
13			class WebhookCreatorLocal extends AbstractWebhookCreator
14			{
15			/**
16			* @var UrlGeneratorInterface
17			*/
18			private $router;
19
20			/**
21			* @param ShopifyApiFactory $apis
22			* @param UrlGeneratorInterface $router
23			*/
24			public function __construct(ShopifyApiFactory $apis, UrlGeneratorInterface $router)
25			{
26			$this->router = $router;
27
28			parent::__construct($apis);
29			}
30
31			/**
32			* {@inheritdoc}
33			*/
34			public function createWebhooks(string $storeName, array $topics)
35			{
36			$api = $this->apis->getForStore($storeName);
37
38			foreach ($topics as $topic) {
39			$endpoint = $this->router->generate('codecloud_shopify_webhooks', [
40			'store' => $storeName,
41			'topic' => $topic,
42			], UrlGeneratorInterface::ABSOLUTE_URL);
43
44			// endpoint HAS to be https
45			$endpoint = str_replace("http://", "https://", $endpoint);
46
47			$webhook = GenericResource::create([
48			'topic' => $topic,
49			'address' => $endpoint,
50			'format' => 'json',
51			]);
52
53			$api->Webhook->create($webhook);
54			}
55			}
56			}
57

Richtermeister / symfony-shopify-bundle

Pull Request — master (#9)

WebhookCreatorLocal::createWebhooks() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like