CodeCloud\Bundle\ShopifyBundle\Api\HttpClientFactory::createHttpClient()

Complexity

Conditions	6
Paths	3

Size

Total Lines	48
Code Lines	27

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function createHttpClient($storeName, $credentials)
    {
        $handlers = HandlerStack::create();
        $handlers->push(Middleware::retry(
            function ($retries, RequestInterface $request, ResponseInterface $response = null, \Exception $error = null) {

The parameter $error is not used and could be removed.

                // todo rate limit by this
                //$response->getHeaderLine('X-Shopify-Shop-Api-Call-Limit');
                if ($response && $response->getStatusCode() == Response::HTTP_TOO_MANY_REQUESTS) {
                    return true;
                }

                return false;
            },
            function ($retries, ResponseInterface $response) {
                if (!$response->hasHeader('Retry-After')) {
                    return 1000;
                }

                dump((float) $response->getHeaderLine('Retry-After') * 1000);

The function dump was not found. Maybe you did not declare it correctly or list all dependencies?

                die();

Using exit here is not recommended.

                return (float) $response->getHeaderLine('Retry-After') * 1000;

return (double)$response->getHeaderLine('Retry-After') * 1000 is not reachable.

            }
        ));

        $options = [
            'base_uri' => 'https://' . $storeName,
            //'handler' => $handlers,
        ];

        switch (true) {
            case  $credentials instanceof PublicAppCredentials:
                $options['headers'] = [
                    'X-Shopify-Access-Token' => $credentials->getAccessToken(),
                ];
                break;
            case $credentials instanceof PrivateAppCredentials:
                $options['auth'] = [
                    $credentials->getApiKey(),
                    $credentials->getPassword(),
                ];
                break;
            default:
                throw new \RuntimeException('Invalid credentials given');
        }

        return new Client($options);
    }