CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\RefundEndpoint::findOne()

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function findOne($orderId, $refundId, array $fields = array())
    {
        $params = $fields ? array('fields' => implode(',', $fields)) : array();
        $request = new GetJson('/admin/orders/' . $orderId . '/refunds/' . $refundId . '.json', $params);
        $response = $this->send($request);
        return $this->createEntity($response->get('refund'));

The expression return $this->createEntity($response->get('refund')) returns the type CodeCloud\Bundle\ShopifyBundle\Api\GenericResource which is incompatible with the documented return type CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\GenericEntity.

It seems like $response->get('refund') can also be of type string; however, parameter $data of CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\AbstractEndpoint::createEntity() does only seem to accept array, maybe add an additional type check?

    }