CodeCloud\Bundle\ShopifyBundle\Api\Response\JsonResponse

Complexity

Total Complexity

12

Size/Duplication

Total Lines	81
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getHttpResponse()	0	3	1
A	get()	0	21	6
A	getDecodedJson()	0	13	3
A	__construct()	0	3	1
A	successful()	0	3	1

<?php
namespace CodeCloud\Bundle\ShopifyBundle\Api\Response;

use Psr\Http\Message\ResponseInterface as PsrResponse;

class JsonResponse implements ResponseInterface
{
    /**
     * @var array
     */
    private $decoded;

    /**
     * @var PsrResponse
     */
    private $response;

    /**
     * @param PsrResponse $response
     */
    public function __construct(PsrResponse $response)
    {
        $this->response = $response;
    }

    /**
     * @return PsrResponse
     */
    public function getHttpResponse()
    {
        return $this->response;
    }

    /**
     * Access elements of the JSON response using dot notation
     * @param null $item

Are you sure the doc-type for parameter $item is correct as it would always require null to be passed?

     * @param null $default

Are you sure the doc-type for parameter $default is correct as it would always require null to be passed?

     * @return mixed
     */
    public function get($item = null, $default = null)
    {
        if (is_null($item)) {

The condition is_null($item) is always true.

            return $default;
        }

        $decoded = $this->getDecodedJson();

        if (array_key_exists($item, $decoded)) {
            return $decoded[$item];
        }

        foreach (explode('.', $item) as $segment) {
            if (! is_array($decoded) || ! array_key_exists($segment, $decoded)) {
                return $default;
            }

            $decoded = $decoded[$segment];
        }

        return $decoded;
    }

    /**
     * @return bool
     */
    public function successful()
    {
        return preg_match('/^2[\d]{2,}/', $this->getHttpResponse()->getStatusCode());

The expression return preg_match('/^2[\d]{2,}/', $this->getHttpResponse()->getStatusCode()) returns the type integer which is incompatible with the documented return type boolean.

    }

    /**
     * @return array
     */
    private function getDecodedJson()
    {
        if (!is_null($this->decoded)) {

The condition is_null($this->decoded) is always false.

            return $this->decoded;
        }

        try {
            return $this->decoded = \GuzzleHttp\json_decode(
                (string) $this->getHttpResponse()->getBody(),
                true
            );
        } catch (\InvalidArgumentException $e) {
            return $this->decoded = array();
        }
    }
}