CodeCloud\Bundle\ShopifyBundle\Api\Response\HtmlResponse

Complexity

Total Complexity

4

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	get()	0	3	1
A	__construct()	0	3	1
A	getHttpResponse()	0	3	1
A	successful()	0	3	1

<?php
namespace CodeCloud\Bundle\ShopifyBundle\Api\Response;

use Psr\Http\Message\ResponseInterface as PsrResponse;

class HtmlResponse implements ResponseInterface
{
    /**
     * @var PsrResponse
     */
    private $response;

    /**
     * @param PsrResponse $response
     */
    public function __construct(PsrResponse $response)
    {
        $this->response = $response;
    }

    /**
     * @return PsrResponse
     */
    public function getHttpResponse()
    {
        return $this->response;
    }

    /**
     * @param null $item

Are you sure the doc-type for parameter $item is correct as it would always require null to be passed?

     * @param null $default

Are you sure the doc-type for parameter $default is correct as it would always require null to be passed?

     * @return mixed
     */
    public function get($item = null, $default = null)
    {
        return $this->response->getBody()->getContents();
    }

    /**
     * @return bool
     */
    public function successful()
    {
        return preg_match('/^2[\d]{2,}/', $this->getHttpResponse()->getStatusCode());

The expression return preg_match('/^2[\d]{2,}/', $this->getHttpResponse()->getStatusCode()) returns the type integer which is incompatible with the documented return type boolean.

    }
}