CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\UserEndpoint

Complexity

Total Complexity

2

Size/Duplication

Total Lines	21
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	findOne()	0	5	1
A	findAll()	0	5	1

<?php
namespace CodeCloud\Bundle\ShopifyBundle\Api\Endpoint;

use CodeCloud\Bundle\ShopifyBundle\Api\Request\GetJson;

class UserEndpoint extends AbstractEndpoint
{
    /**
     * @return array|GenericEntity[]
     */
    public function findAll()
    {
        $request = new GetJson('/admin/users.json');
        $response = $this->send($request);
        return $this->createCollection($response->get('users'));

It seems like $response->get('users') can also be of type string; however, parameter $items of CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\AbstractEndpoint::createCollection() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param int $userId
     * @return GenericEntity

The type CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\GenericEntity was not found. Maybe you did not declare it correctly or list all dependencies?

     */
    public function findOne($userId)
    {
        $request = new GetJson('/admin/users/' . $userId . '.json');
        $response = $this->send($request);
        return $this->createEntity($response->get('user'));

The expression return $this->createEntity($response->get('user')) returns the type CodeCloud\Bundle\ShopifyBundle\Api\GenericResource which is incompatible with the documented return type CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\GenericEntity.

It seems like $response->get('user') can also be of type string; however, parameter $data of CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\AbstractEndpoint::createEntity() does only seem to accept array, maybe add an additional type check?

    }
}