CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\TransactionEndpoint

Complexity

Total Complexity

6

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	countByOrder()	0	5	1
A	capture()	0	10	2
A	findOne()	0	6	2
A	findByOrder()	0	5	1

<?php
namespace CodeCloud\Bundle\ShopifyBundle\Api\Endpoint;

use CodeCloud\Bundle\ShopifyBundle\Api\Request\GetJson;
use CodeCloud\Bundle\ShopifyBundle\Api\Request\PostJson;

class TransactionEndpoint extends AbstractEndpoint
{
    /**
     * @param int $orderId
     * @param array $query
     * @return array|GenericEntity

The type CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\GenericEntity was not found. Maybe you did not declare it correctly or list all dependencies?

     */
    public function findByOrder($orderId, array $query = array())
    {
        $request = new GetJson('/admin/orders/' . $orderId . '/transactions.json', $query);
        $response = $this->send($request);
        return $this->createCollection($response->get('transactions'));

It seems like $response->get('transactions') can also be of type string; however, parameter $items of CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\AbstractEndpoint::createCollection() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param int $orderId
     * @return int
     */
    public function countByOrder($orderId)
    {
        $request = new GetJson('/admin/orders/' . $orderId . '/transactions/count.json');
        $response = $this->send($request);
        return $response->get('count');

The expression return $response->get('count') also could return the type string which is incompatible with the documented return type integer.

    }

    /**
     * @param int $orderId
     * @param int $transactionId
     * @param array $fields
     * @return GenericEntity
     */
    public function findOne($orderId, $transactionId, array $fields = array())
    {
        $params = $fields ? array('fields' => implode(',', $fields)) : array();
        $request = new GetJson('/admin/orders/' . $orderId . '/transactions/' . $transactionId . '.json', $params);
        $response = $this->send($request);
        return $this->createEntity($response->get('transaction'));

The expression return $this->createEntity($response->get('transaction')) returns the type CodeCloud\Bundle\ShopifyBundle\Api\GenericResource which is incompatible with the documented return type CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\GenericEntity.

It seems like $response->get('transaction') can also be of type string; however, parameter $data of CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\AbstractEndpoint::createEntity() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param int $orderId
     * @param float|null $amount
     */
    public function capture($orderId, $amount = null)
    {
        $params = array('kind' => 'capture');

        if ($amount) {
            $params['amount'] = (float)$amount;
        }

        $request = new PostJson('/admin/orders/' . $orderId . '/transactions.json', array('transaction' => $params));
        $this->send($request);
    }
}