CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\ThemeEndpoint

Complexity

Total Complexity

7

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	delete()	0	4	1
A	create()	0	5	1
A	findOne()	0	6	2
A	update()	0	5	1
A	findAll()	0	6	2

<?php
namespace CodeCloud\Bundle\ShopifyBundle\Api\Endpoint;

use CodeCloud\Bundle\ShopifyBundle\Api\Request\DeleteParams;
use CodeCloud\Bundle\ShopifyBundle\Api\Request\GetJson;
use CodeCloud\Bundle\ShopifyBundle\Api\Request\PostJson;
use CodeCloud\Bundle\ShopifyBundle\Api\Request\PutJson;
use CodeCloud\Bundle\ShopifyBundle\Api\GenericResource;

class ThemeEndpoint extends AbstractEndpoint
{
    /**
     * @param array $fields
     * @return array|GenericResource[]
     */
    public function findAll(array $fields = array())
    {
        $params = $fields ? array('fields' => implode(',', $fields)) : array();
        $request = new GetJson('/admin/themes.json', $params);
        $response = $this->send($request);
        return $this->createCollection($response->get('themes'));

It seems like $response->get('themes') can also be of type string; however, parameter $items of CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\AbstractEndpoint::createCollection() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param int $themeId
     * @param array $fields
     * @return GenericResource
     */
    public function findOne($themeId, array $fields = array())
    {
        $params = $fields ? array('fields' => implode(',', $fields)) : array();
        $request = new GetJson('/admin/themes/' . $themeId . '.json', $params);
        $response = $this->send($request);
        return $this->createEntity($response->get('theme'));

It seems like $response->get('theme') can also be of type string; however, parameter $data of CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\AbstractEndpoint::createEntity() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param GenericResource $theme
     * @return \CodeCloud\Bundle\ShopifyBundle\Api\GenericResource
     */
    public function create(GenericResource $theme)
    {
        $request = new PostJson('/admin/themes.json', array('theme' => $theme->toArray()));
        $response = $this->send($request);
        return $this->create($response->get('theme'));

It seems like $response->get('theme') can also be of type null and string; however, parameter $theme of CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\ThemeEndpoint::create() does only seem to accept CodeCloud\Bundle\ShopifyBundle\Api\GenericResource, maybe add an additional type check?

    }

    /**
     * @param int $themeId
     * @param GenericResource $theme
     * @return GenericResource
     */
    public function update($themeId, $theme)
    {
        $request = new PutJson('/admin/themes/' . $themeId . '.json', array('theme' => $theme->toArray()));
        $response = $this->send($request);
        return $this->create($response->get('theme'));

It seems like $response->get('theme') can also be of type null and string; however, parameter $theme of CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\ThemeEndpoint::create() does only seem to accept CodeCloud\Bundle\ShopifyBundle\Api\GenericResource, maybe add an additional type check?

    }

    /**
     * @param int $themeId
     */
    public function delete($themeId)
    {
        $request = new DeleteParams('/admin/themes/' . $themeId . '.json');
        $this->send($request);
    }
}