CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\FulfillmentServiceEndpoint

Complexity

Total Complexity

5

Size/Duplication

Total Lines	54
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	findOne()	0	5	1
A	update()	0	5	1
A	delete()	0	4	1
A	create()	0	5	1
A	findAll()	0	5	1

<?php
namespace CodeCloud\Bundle\ShopifyBundle\Api\Endpoint;

use CodeCloud\Bundle\ShopifyBundle\Api\Request\DeleteParams;
use CodeCloud\Bundle\ShopifyBundle\Api\Request\GetJson;
use CodeCloud\Bundle\ShopifyBundle\Api\Request\PostJson;
use CodeCloud\Bundle\ShopifyBundle\Api\Request\PutJson;
use CodeCloud\Bundle\ShopifyBundle\Api\GenericResource;

class FulfillmentServiceEndpoint extends AbstractEndpoint
{
    /**
     * @param array $query
     * @return array|GenericResource[]
     */
    public function findAll(array $query = array('scope' => 'all'))
    {
        $request = new GetJson('/admin/fulfillment_services.json', $query);
        $response = $this->send($request);
        return $this->createCollection($response->get('fulfillment_services'));

It seems like $response->get('fulfillment_services') can also be of type string; however, parameter $items of CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\AbstractEndpoint::createCollection() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param int $fulfillmentServiceId
     * @return GenericResource
     */
    public function findOne($fulfillmentServiceId)
    {
        $request = new GetJson('/admin/fulfillment_services/' . $fulfillmentServiceId . '.json');
        $response = $this->send($request);
        return $this->createEntity($response->get('fulfillment_service'));

It seems like $response->get('fulfillment_service') can also be of type string; however, parameter $data of CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\AbstractEndpoint::createEntity() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param GenericResource $fulfillmentService
     * @return GenericResource
     */
    public function create(GenericResource $fulfillmentService)
    {
        $request = new PostJson('/admin/fulfillment_services.json', array('fulfillment_service' => $fulfillmentService->toArray()));
        $response = $this->send($request);
        return $this->createEntity($response->get('fulfillment_service'));

It seems like $response->get('fulfillment_service') can also be of type string; however, parameter $data of CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\AbstractEndpoint::createEntity() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param int $fulfillmentServiceId
     * @param GenericResource $fulfillmentService
     * @return GenericResource
     */
    public function update($fulfillmentServiceId, GenericResource $fulfillmentService)
    {
        $request = new PutJson('/admin/fulfillment_services/' . $fulfillmentServiceId . '.json', array('fulfillment_service' => $fulfillmentService->toArray()));
        $response = $this->send($request);
        return $this->createEntity($response->get('fulfillment_service'));

It seems like $response->get('fulfillment_service') can also be of type string; however, parameter $data of CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\AbstractEndpoint::createEntity() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param int $fulfillmentServiceId
     */
    public function delete($fulfillmentServiceId)
    {
        $request = new DeleteParams('/admin/fulfillment_services/' . $fulfillmentServiceId . '.json');
        $this->send($request);
    }
}