CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\FulFillmentEndpoint

Complexity

Total Complexity

8

Size/Duplication

Total Lines	83
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	complete()	0	4	1
A	cancel()	0	4	1
A	create()	0	5	1
A	countByOrder()	0	5	1
A	update()	0	5	1
A	findOne()	0	6	2
A	findByOrder()	0	5	1

<?php
namespace CodeCloud\Bundle\ShopifyBundle\Api\Endpoint;

use CodeCloud\Bundle\ShopifyBundle\Api\Request\GetJson;
use CodeCloud\Bundle\ShopifyBundle\Api\Request\PostJson;
use CodeCloud\Bundle\ShopifyBundle\Api\Request\PutJson;
use CodeCloud\Bundle\ShopifyBundle\Api\GenericResource;

class FulFillmentEndpoint extends AbstractEndpoint
{
    /**
     * @param int $orderId
     * @param array $query
     * @return array|\CodeCloud\Bundle\ShopifyBundle\Api\GenericResource[]
     */
    public function findByOrder($orderId, array $query = array())
    {
        $request = new GetJson('/admin/orders/' . $orderId . '/fulfillments.json', $query);
        $response = $this->sendPaged($request, 'fulfillments');
        return $this->createCollection($response);
    }

    /**
     * @param int $orderId
     * @param array $query
     * @return int
     */
    public function countByOrder($orderId, array $query = array())
    {
        $request = new GetJson('/admin/orders/' . $orderId . '/fulfillments/count.json', $query);
        $response = $this->send($request);
        return $response->get('count');

The expression return $response->get('count') also could return the type string which is incompatible with the documented return type integer.

    }

    /**
     * @param int $orderId
     * @param int $fulfillmentId
     * @param array $fields
     * @return GenericResource
     */
    public function findOne($orderId, $fulfillmentId, array $fields = array())
    {
        $params = $fields ? array('fields' => $fields) : array();
        $request = new GetJson('/admin/orders/' . $orderId . '/fulfillments/' . $fulfillmentId . '.json', $params);
        $response = $this->send($request);
        return $this->createEntity($response->get('fulfillment'));

It seems like $response->get('fulfillment') can also be of type string; however, parameter $data of CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\AbstractEndpoint::createEntity() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param int $orderId
     * @param \CodeCloud\Bundle\ShopifyBundle\Api\GenericResource $fulfillment
     * @return GenericResource
     */
    public function create($orderId, GenericResource $fulfillment)
    {
        $request = new PostJson('/admin/orders/' . $orderId . '/fulfillments.json', array('fulfillment' => $fulfillment->toArray()));
        $response = $this->send($request);
        return $this->createEntity($response->get('fulfillment'));

It seems like $response->get('fulfillment') can also be of type string; however, parameter $data of CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\AbstractEndpoint::createEntity() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param int $orderId
     * @param int $fulfillmentId
     * @param GenericResource $fulfillment
     * @return GenericResource
     */
    public function update($orderId, $fulfillmentId, GenericResource $fulfillment)
    {
        $request = new PutJson('/admin/orders/' . $orderId . '/fulfillments/' . $fulfillmentId . '.json', array('fulfillment' => $fulfillment->toArray()));
        $response = $this->send($request);
        return $this->createEntity($response->get('fulfillment'));

It seems like $response->get('fulfillment') can also be of type string; however, parameter $data of CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\AbstractEndpoint::createEntity() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param int $orderId
     * @param int $fulfillmentId
     */
    public function complete($orderId, $fulfillmentId)
    {
        $request = new PostJson('/admin/orders/' . $orderId . '/fulfillments/' . $fulfillmentId . '/complete.json');
        $this->send($request);
    }

    /**
     * @param int $orderId
     * @param int $fulfillmentId
     */
    public function cancel($orderId, $fulfillmentId)
    {
        $request = new PostJson('/admin/orders/' . $orderId . '/fulfillments/' . $fulfillmentId . '/cancel.json');
        $this->send($request);
    }
}