CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\EventEndpoint

Complexity

Total Complexity

3

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	countAll()	0	5	1
A	findOne()	0	5	1
A	findAll()	0	5	1

<?php
namespace CodeCloud\Bundle\ShopifyBundle\Api\Endpoint;

use CodeCloud\Bundle\ShopifyBundle\Api\Request\GetJson;

class EventEndpoint extends AbstractEndpoint
{
    /**
     * @param array $query
     * @return array|GenericEntity[]
     */
    public function findAll(array $query = array())
    {
        $request = new GetJson('/admin/events.json', $query);
        $response = $this->sendPaged($request, 'events');
        return $this->createCollection($response);
    }

    /**
     * @param array $query
     * @return int
     */
    public function countAll(array $query = array())
    {
        $request = new GetJson('/admin/events/count.json', $query);
        $response = $this->send($request);
        return $response->get('count');

The expression return $response->get('count') also could return the type string which is incompatible with the documented return type integer.

    }

    /**
     * @param int $eventId
     * @return GenericEntity

The type CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\GenericEntity was not found. Maybe you did not declare it correctly or list all dependencies?

     */
    public function findOne($eventId)
    {
        $request = new GetJson('/admin/events/' . $eventId . '.json');
        $response = $this->send($request);
        return $this->createEntity($response->get('event'));

The expression return $this->createEntity($response->get('event')) returns the type CodeCloud\Bundle\ShopifyBundle\Api\GenericResource which is incompatible with the documented return type CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\GenericEntity.

It seems like $response->get('event') can also be of type string; however, parameter $data of CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\AbstractEndpoint::createEntity() does only seem to accept array, maybe add an additional type check?

    }
}