CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\CustomerEndpoint

Complexity

Total Complexity

9

Size/Duplication

Total Lines	88
Duplicated Lines	0 %

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	delete()	0	4	1
A	findAll()	0	5	1
A	search()	0	5	1
A	findOrdersForCustomer()	0	6	2
A	findOne()	0	5	1
A	update()	0	5	1
A	create()	0	5	1
A	countAll()	0	5	1

<?php
namespace CodeCloud\Bundle\ShopifyBundle\Api\Endpoint;

use CodeCloud\Bundle\ShopifyBundle\Api\Request\DeleteParams;
use CodeCloud\Bundle\ShopifyBundle\Api\Request\GetJson;
use CodeCloud\Bundle\ShopifyBundle\Api\Request\PostJson;
use CodeCloud\Bundle\ShopifyBundle\Api\GenericResource;
use CodeCloud\Bundle\ShopifyBundle\Api\Request\PutJson;

class CustomerEndpoint extends AbstractEndpoint
{
    /**
     * @param array $query
     * @return array|\CodeCloud\Bundle\ShopifyBundle\Api\GenericResource[]
     */
    public function findAll(array $query = array())
    {
        $request = new GetJson('/admin/customers.json', $query);
        $response = $this->sendPaged($request, 'customers');
        return $this->createCollection($response);
    }

    /**
     * @param int $customerId
     * @param array $fields
     * @return array|GenericResource[]
     */
    public function findOrdersForCustomer($customerId, array $fields = array())
    {
        $params = $fields ? array('fields' => implode(',', $fields)) : array();
        $request = new GetJson('/admin/customers/' . $customerId . '.json', $params);
        $response = $this->sendPaged($request, 'customers');
        return $this->createCollection($response);
    }

    /**
     * @param array $query
     * @return array|\CodeCloud\Bundle\ShopifyBundle\Api\GenericResource[]
     */
    public function search(array $query = array())
    {
        $request = new GetJson('/admin/customers/search.json', $query);
        $response = $this->sendPaged($request, 'customers');
        return $this->createCollection($response);
    }

    /**
     * @return int
     */
    public function countAll()
    {
        $request = new GetJson('/admin/customers/count.json');
        $response = $this->send($request);
        return $response->get('count');

The expression return $response->get('count') also could return the type string which is incompatible with the documented return type integer.

    }

    /**
     * @param int $customerId
     * @return \CodeCloud\Bundle\ShopifyBundle\Api\GenericResource
     */
    public function findOne($customerId)
    {
        $request = new GetJson('/admin/customers/' . $customerId . '.json');
        $response = $this->send($request);
        return $this->createEntity($response->get('customer'));

It seems like $response->get('customer') can also be of type string; however, parameter $data of CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\AbstractEndpoint::createEntity() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param \CodeCloud\Bundle\ShopifyBundle\Api\GenericResource $customer
     * @return \CodeCloud\Bundle\ShopifyBundle\Api\GenericResource
     */
    public function create(GenericResource $customer)
    {
        $request = new PostJson('/admin/customers.json', array('customer' => $customer->toArray()));
        $response = $this->send($request);
        return $this->createEntity($response->get('customer'));

It seems like $response->get('customer') can also be of type string; however, parameter $data of CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\AbstractEndpoint::createEntity() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param int $customerId
     * @param \CodeCloud\Bundle\ShopifyBundle\Api\GenericResource $customer
     * @return \CodeCloud\Bundle\ShopifyBundle\Api\GenericResource
     */
    public function update($customerId, GenericResource $customer)
    {
        $request = new PutJson('/admin/customers/' . $customerId . '.json', array('customer' => $customer->toArray()));
        $response = $this->send($request);
        return $this->createEntity($response->get('customer'));

It seems like $response->get('customer') can also be of type string; however, parameter $data of CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\AbstractEndpoint::createEntity() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param int $customerId
     */
    public function delete($customerId)
    {
        $request = new DeleteParams('/admin/customers/' . $customerId . '.json');
        $this->send($request);
    }
}