CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\CustomCollectionEndpoint

Complexity

Total Complexity

6

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	create()	0	5	1
A	findOne()	0	5	1
A	countAll()	0	5	1
A	update()	0	5	1
A	delete()	0	4	1
A	findAll()	0	5	1

<?php
namespace CodeCloud\Bundle\ShopifyBundle\Api\Endpoint;

use CodeCloud\Bundle\ShopifyBundle\Api\Request\DeleteParams;
use CodeCloud\Bundle\ShopifyBundle\Api\Request\GetJson;
use CodeCloud\Bundle\ShopifyBundle\Api\Request\PostJson;
use CodeCloud\Bundle\ShopifyBundle\Api\Request\PutJson;
use CodeCloud\Bundle\ShopifyBundle\Api\GenericResource;

class CustomCollectionEndpoint extends AbstractEndpoint
{
    /**
     * @param array $query
     * @return array|GenericResource[]
     */
    public function findAll(array $query = array())
    {
        $request = new GetJson('/admin/custom_collections.json', $query);
        $response = $this->sendPaged($request, 'custom_collections');
        return $this->createCollection($response);
    }

    /**
     * @param array $query
     * @return int
     */
    public function countAll(array $query = array())
    {
        $request = new GetJson('/admin/custom_collections/count.json', $query);
        $response = $this->send($request);
        return $response->get('count');

The expression return $response->get('count') also could return the type string which is incompatible with the documented return type integer.

    }

    /**
     * @param int $customCollectionId
     * @return \CodeCloud\Bundle\ShopifyBundle\Api\GenericResource
     */
    public function findOne($customCollectionId)
    {
        $request = new GetJson('/admin/custom_collections/' . $customCollectionId . '.json');
        $response = $this->send($request);
        return $this->createEntity($response->get('custom_collection'));

It seems like $response->get('custom_collection') can also be of type string; however, parameter $data of CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\AbstractEndpoint::createEntity() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param GenericResource $customCollection
     * @return \CodeCloud\Bundle\ShopifyBundle\Api\GenericResource
     */
    public function create(GenericResource $customCollection)
    {
        $request = new PostJson('/admin/custom_collections.json', array('custom_collection' => $customCollection->toArray()));
        $response = $this->send($request);
        return $this->createEntity($response->get('custom_collection'));

It seems like $response->get('custom_collection') can also be of type string; however, parameter $data of CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\AbstractEndpoint::createEntity() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param int $customCollectionId
     * @param \CodeCloud\Bundle\ShopifyBundle\Api\GenericResource $customCollection
     * @return GenericResource
     */
    public function update($customCollectionId, GenericResource $customCollection)
    {
        $request = new PutJson('/admin/custom_collections/' . $customCollectionId . '.json', array('custom_collection' => $customCollection->toArray()));
        $response = $this->send($request);
        return $this->createEntity($response->get('custom_collection'));

It seems like $response->get('custom_collection') can also be of type string; however, parameter $data of CodeCloud\Bundle\ShopifyBundle\Api\Endpoint\AbstractEndpoint::createEntity() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param int $customCollectionId
     */
    public function delete($customCollectionId)
    {
        $request = new DeleteParams('/admin/custom_collections/' . $customCollectionId . '.json');
        $this->send($request);
    }
}