RicLeP / laravel-storyblok

src/Traits/SchemaOrg.php

<?php


namespace Riclep\Storyblok\Traits;


use Riclep\Storyblok\Page;

trait SchemaOrg
{
	/**
	 * Automatically called to add a schema to the Page
	 */
	protected function initSchemaOrg(): void
	{
		if (method_exists($this, 'schemaOrg')) {
			if ($this instanceof Page) {
				$page = $this;
			} else {
				$page = $this->page();

It seems like page() must be provided by classes using this trait. How about adding it as abstract method to this trait?

			}

			if ($page) {
				$this->add($page);
			}
		}

	}

	/**
	 * Returns the JavaScript JSON-LD string
	 *
	 * @return string
	 */
	public function schemaOrgScript(): string
	{
		$schemaJson = '';

		foreach ($this->meta()['schema_org'] as $schema) {

It seems like meta() must be provided by classes using this trait. How about adding it as abstract method to this trait?

			$schemaJson .= $schema->toScript();
		}

		return $schemaJson;
	}

	/**
	 * Adds the schema to the meta of the current page
	 *
	 * @param $page
	 */
	private function add($page): void
	{
		$currentSchemaOrg = $page->meta('schema_org');

		$currentSchemaOrg[] = $this->schemaOrg();

The method schemaOrg() does not exist on Riclep\Storyblok\Traits\SchemaOrg. Did you maybe mean schemaOrgScript()?

		$page->replaceMeta('schema_org', $currentSchemaOrg ?? []);
	}
}