Riclep\Storyblok\Traits\Renderable

Complexity

Total Complexity

6

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	view()	0	7	3
A	render()	0	6	1
A	views()	0	19	2

<?php


namespace Riclep\Storyblok\Traits;

trait Renderable
{
	protected function views() {
		$views[] = 'storyblok.blocks.uuid.' . $this->_uid;

$views was never initialized. Although not strictly required by PHP, it is generally a good practice to add $views = array(); before regardless.

		$segments = explode('/', rtrim(app()->make('Page')->slug(), '/'));
		// creates an array of dot paths for each path segment
		// site.com/this/that/them becomes:
		// this.that.them
		// this.that
		// this
		$views[] = 'storyblok.blocks.' . implode('.', $segments) . '.=' . $this->component;
		$views[] = 'storyblok.blocks.' . implode('.', $segments) . '.' . $this->component;
		while (count($segments) > 1) {
			array_pop($segments);
			$views[] = 'storyblok.blocks.' . implode('.', $segments) . '.' . $this->component;
		}

		$views[] = 'storyblok.blocks.' . $this->component;
		$views[] = 'storyblok.blocks.default';

		return $views;
	}

	/**
	 * Returns the first matching view
	 *
	 * @return bool|mixed
	 */
	public function view() {
		foreach ($this->views() as $view) {
			$view = view()->exists($view) ? $view : false;
			break;
		}

		return $view;

The variable $view does not seem to be defined for all execution paths leading up to this point.

	}

	/**
	 * Finds the view used to display this block’s content
	 * it will always fall back to a default view.
	 *
	 */
	public function render()
	{
		return view()->first(
			$this->views(),
			[
				'block' => $this
			]
		);
	}
}