Riclep\Storyblok\Console\ImportStoryCommand

Complexity

Total Complexity

3

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	handle()	0	23	2

<?php

namespace Riclep\Storyblok\Console;

use Illuminate\Console\Command;
use Illuminate\Support\Facades\Storage;
use Storyblok\ManagementClient;

class ImportStoryCommand extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'ls:import {filename} {slug}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Import a story from JSON - it will be created in your space’s root';

	/**
	 * Create a new command instance.
	 *
	 * @return void
	 */
	public function __construct()
	{
		$this->client = new ManagementClient(config('storyblok.oauth_token'));

The property client does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

		parent::__construct();
	}

    /**
     * Execute the console command.
     *
     * @return int
     */
    public function handle()
    {
	    $storyExists = $this->client->get('spaces/' . config('storyblok.space_id') . '/stories/', [
			'with_slug' => $this->argument('slug')
	    ])->getBody()['stories'];

The method getBody() does not exist on stdClass.

		if (!$storyExists) {
			$source = json_decode(Storage::get($this->argument('filename')), true);

It seems like $this->argument('filename') can also be of type array; however, parameter $path of Illuminate\Support\Facades\Storage::get() does only seem to accept string, maybe add an additional type check?

			$story = [
				"story" =>  [
					"name" => $source['story']['name'] . ' (Imported)',
					"slug" => $this->argument('slug'),
					"content" => $source['story']['content'],
				],
				"publish" =>  1
			];

			$importedStory = $this->client->post('spaces/' . config('storyblok.space_id') . '/stories/', $story)->getBody()['story'];

			$this->info('Imported into Storyblok: ' . $importedStory['name']);
		} else {
			$this->warn('Story already exists for: ' . $this->argument('slug'));
		}
    }
}