ConditionallyRequired::__invoke() - Code Metrics - Inspection of "WIP Note" - RicLeP/laravel-storyblok-forms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 4e7190...14b77f )

by Richard

created 2022-09-23 09:35 UTC

ConditionallyRequired::__invoke() B

↳ Parent: ConditionallyRequired

Complexity

Conditions	11
Paths	18

Size

Total Lines	29
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	22
c	1
b	0
f	0
dl	0
loc	29
rs	7.3166
cc	11
nc	18
nop	3

How to fix Complexity

<?php

namespace Riclep\StoryblokForms\Rules;

use Illuminate\Contracts\Validation\DataAwareRule;
use Illuminate\Contracts\Validation\InvokableRule;

class ConditionallyRequired implements DataAwareRule, InvokableRule
{

	protected $conditional;

	public function __construct($conditional) {
		$this->conditional = $conditional;
	}

    /**
     * Run the validation rule.
     *
     * @param  string  $attribute
     * @param  mixed  $value
     * @param  \Closure(string): \Illuminate\Translation\PotentiallyTranslatedString  $fail
     * @return void
     */
    public function __invoke($attribute, $value, $fail)
    {
	    $causationFieldValue = data_get($this->data, $this->conditional['field']);

		$condition = $this->conditional['condition'];
		$operator = $this->conditional['operator'];

		$fieldIsRequired = false;

	    if ($operator === '>') {
		    $fieldIsRequired = $causationFieldValue > $condition;
	    } else if ($operator === '<') {
		    $fieldIsRequired = $causationFieldValue < $condition;
	    } else if ($operator === '==') {
		    $fieldIsRequired = $causationFieldValue == $condition;
	    }  else if ($operator === '===') {
		    $fieldIsRequired = $causationFieldValue === $condition;
	    } else if ($operator === '!=') {
		    $fieldIsRequired = $causationFieldValue != $condition;
	    }  else if ($operator === '!==') {
		    $fieldIsRequired = $causationFieldValue !== $condition;
	    } else if ($operator === '>=') {
		    $fieldIsRequired = $causationFieldValue >= $condition;
	    } else if ($operator === '<=') {
		    $fieldIsRequired = $causationFieldValue <= $condition;
	    }

	    if ($fieldIsRequired && !$value) {
		    $fail('This field is required.');
	    }
    }

	/**
	 * Outputs the HTML version of the validation
	 *
	 * @return string
	 */
	public function __toString()
	{
		return '';
	}

	/**
	 * Set the data under validation.
	 *
	 * @param array $data
	 * @return $this
	 */
	public function setData($data)
	{
		$this->data = $data;


		return $this;
	}
}


1			<?php
2
3			namespace Riclep\StoryblokForms\Rules;
4
5			use Illuminate\Contracts\Validation\DataAwareRule;
6			use Illuminate\Contracts\Validation\InvokableRule;
7
8			class ConditionallyRequired implements DataAwareRule, InvokableRule
9			{
10
11			protected $conditional;
12
13			public function __construct($conditional) {
14			$this->conditional = $conditional;
15			}
16
17			/**
18			* Run the validation rule.
19			*
20			* @param string $attribute
21			* @param mixed $value
22			* @param \Closure(string): \Illuminate\Translation\PotentiallyTranslatedString $fail
23			* @return void
24			*/
25			public function __invoke($attribute, $value, $fail)
26			{
27			$causationFieldValue = data_get($this->data, $this->conditional['field']);
28
29			$condition = $this->conditional['condition'];
30			$operator = $this->conditional['operator'];
31
32			$fieldIsRequired = false;
33
34			if ($operator === '>') {
35			$fieldIsRequired = $causationFieldValue > $condition;
36			} else if ($operator === '<') {
37			$fieldIsRequired = $causationFieldValue < $condition;
38			} else if ($operator === '==') {
39			$fieldIsRequired = $causationFieldValue == $condition;
40			} else if ($operator === '===') {
41			$fieldIsRequired = $causationFieldValue === $condition;
42			} else if ($operator === '!=') {
43			$fieldIsRequired = $causationFieldValue != $condition;
44			} else if ($operator === '!==') {
45			$fieldIsRequired = $causationFieldValue !== $condition;
46			} else if ($operator === '>=') {
47			$fieldIsRequired = $causationFieldValue >= $condition;
48			} else if ($operator === '<=') {
49			$fieldIsRequired = $causationFieldValue <= $condition;
50			}
51
52			if ($fieldIsRequired && !$value) {
53			$fail('This field is required.');
54			}
55			}
56
57			/**
58			* Outputs the HTML version of the validation
59			*
60			* @return string
61			*/
62			public function __toString()
63			{
64			return '';
65			}
66
67			/**
68			* Set the data under validation.
69			*
70			* @param array $data
71			* @return $this
72			*/
73			public function setData($data)
74			{
75			$this->data = $data;
			0 ignored issues – show Bug Best Practice introduced 2022-09-23 09:49 UTC by Report Bug Copy Issue Report The property `data` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
76
77			return $this;
78			}
79			}
80

RicLeP / laravel-storyblok-forms

Push — develop ( 4e7190...14b77f )

ConditionallyRequired::__invoke() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like