Fibonacci::validate() - Code Metrics - Inspection of "new Fibonacci number rule" - Respect/Validation - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#637)

by Samuel

created 2016-01-23 10:50 UTC

Fibonacci::validate() A

↳ Parent: Fibonacci

Complexity

Conditions	3
Paths	4

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	12
ccs	9
cts	9
cp	1
rs	9.4285
cc	3
eloc	8
nc	4
nop	1
crap	3

<?php

/*
 * This file is part of Respect/Validation.
 *
 * (c) Alexandre Gomes Gaigalas <[email protected]>
 *
 * For the full copyright and license information, please view the "LICENSE.md"
 * file that was distributed with this source code.
 */

namespace Respect\Validation\Rules;

/**
 * @author Samuel Heinzmann <[email protected]>
 */
class Fibonacci extends AbstractRule
{
    /**
     * {@inheritdoc}
     */
    public function validate($input)
    {
        $fib[0] = 0;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $fib[1] = 1;
        $n = 1;
        while ($input > $fib[$n]) {
            $n++;
            $fib[$n] = $fib[$n - 1] + $fib[$n - 2];
        }

        return $fib[$n] === (int)$input && is_numeric($input);
    }
}

1		<?php
2
3		/*
4		* This file is part of Respect/Validation.
5		*
6		* (c) Alexandre Gomes Gaigalas <[email protected]>
7		*
8		* For the full copyright and license information, please view the "LICENSE.md"
9		* file that was distributed with this source code.
10		*/
11
12		namespace Respect\Validation\Rules;
13
14		/**
15		* @author Samuel Heinzmann <[email protected]>
16		*/
17		class Fibonacci extends AbstractRule
18		{
19		/**
20		* {@inheritdoc}
21		*/
22	24	public function validate($input)
23		{
24	24	$fib[0] = 0;
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-01-23 10:54 UTC by Report Bug Copy Issue Report `$fib` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$fib = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
25	24	$fib[1] = 1;
26	24	$n = 1;
27	24	while ($input > $fib[$n]) {
28	14	$n++;
29	14	$fib[$n] = $fib[$n - 1] + $fib[$n - 2];
30	14	}
31
32	24	return $fib[$n] === (int)$input && is_numeric($input);
33		}
34		}

Respect / Validation

Scrutinizer GitHub App not installed

Pull Request — master (#637)

Fibonacci::validate() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like