ResultIterator::rewind() - Code Metrics - Inspection of "New Concrete API" - Respect/Validation - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#678)

by Henrique

created 2017-11-12 18:43 UTC

ResultIterator::rewind() A

↳ Parent: ResultIterator

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
c	0
b	0
f	0
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php


namespace Respect\Validation;

use Countable;
use RecursiveIterator;

final class ResultIterator implements RecursiveIterator, Countable
{
    /**
     * @var Result[]
     */
    private $children;

    public function __construct(Result $result)
    {
        $this->children = $result->getChildren();
    }

    public function current()
    {
        return current($this->children);
    }

    public function next()
    {
        return next($this->children);
    }

    public function key()
    {
        $current = current($this->children);

        return $current->getProperties()['reference'] ?? key($this->children);
    }

    public function valid(): bool
    {
        $key = key($this->children);

        return ($key !== null && $key !== false);
    }

    public function rewind()
    {
        reset($this->children);
    }

    public function hasChildren(): bool
    {
        $children = $this->current()->getChildren();

        return count($children) > 0;
    }

    public function getChildren(): ResultIterator
    {
        return new self($this->current());

    }

    public function count(): int
    {
        return count($this->children);
    }
}


1			<?php
2
3
4			namespace Respect\Validation;
5
6			use Countable;
7			use RecursiveIterator;
8
9			final class ResultIterator implements RecursiveIterator, Countable
10			{
11			/**
12			* @var Result[]
13			*/
14			private $children;
15
16			public function __construct(Result $result)
17			{
18			$this->children = $result->getChildren();
19			}
20
21			public function current()
22			{
23			return current($this->children);
24			}
25
26			public function next()
27			{
28			return next($this->children);
29			}
30
31			public function key()
32			{
33			$current = current($this->children);
34
35			return $current->getProperties()['reference'] ?? key($this->children);
36			}
37
38			public function valid(): bool
39			{
40			$key = key($this->children);
41
42			return ($key !== null && $key !== false);
43			}
44
45			public function rewind()
46			{
47			reset($this->children);
48			}
49
50			public function hasChildren(): bool
51			{
52			$children = $this->current()->getChildren();
53
54			return count($children) > 0;
55			}
56
57			public function getChildren(): ResultIterator
58			{
59			return new self($this->current());
			0 ignored issues – show Security Bug introduced 2017-11-12 18:46 UTC by Report Bug Copy Issue Report It seems like `$this->current()` targeting `Respect\Validation\ResultIterator::current()` can also be of type `false`; however, `Respect\Validation\ResultIterator::__construct()` does only seem to accept `object<Respect\Validation\Result>`, did you maybe forget to handle an error condition? Loading history...
60			}
61
62			public function count(): int
63			{
64			return count($this->children);
65			}
66			}
67

Respect / Validation

Scrutinizer GitHub App not installed

Pull Request — master (#678)

ResultIterator::rewind() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like