We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
Conditions | 11 |
Paths | 8 |
Total Lines | 31 |
Code Lines | 15 |
Lines | 0 |
Ratio | 0 % |
Tests | 14 |
CRAP Score | 11.2363 |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
16 | 99 | public function validate($input) |
|
17 | { |
||
18 | 99 | if (!is_scalar($input)) { |
|
19 | 2 | return false; |
|
20 | } |
||
21 | |||
22 | // Canonicalize input |
||
23 | 97 | $input = preg_replace('{\D}', '', (string) $input); |
|
24 | |||
25 | // Validate length and invalid numbers |
||
26 | 97 | if ((strlen($input) != 11) || (intval($input) == 0)) { |
|
27 | 73 | return false; |
|
28 | } |
||
29 | |||
30 | // Validate check digits using a modulus 11 algorithm |
||
31 | 24 | for ($c = $s1 = $s2 = 0, $p = 9; $c < 9; $c++, $p--) { |
|
32 | 24 | $s1 += intval($input[$c]) * $p; |
|
33 | 24 | $s2 += intval($input[$c]) * (10 - $p); |
|
34 | 24 | } |
|
35 | |||
36 | 24 | if ($input[9] != (($dv1 = $s1 % 11) > 9) ? 0 : $dv1) { |
|
37 | return false; |
||
38 | } |
||
39 | |||
40 | 24 | if ($input[10] != (((($dv2 = ($s2 % 11) - (($dv1 > 9) ? 2 : 0)) < 0) |
|
41 | 24 | ? $dv2 + 11 : $dv2) > 9) ? 0 : $dv2) { |
|
42 | return false; |
||
43 | } |
||
44 | |||
45 | 24 | return true; |
|
46 | } |
||
47 | } |
||
48 |