We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
Complex classes like NestedValidationException often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use NestedValidationException, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
18 | class NestedValidationException extends ValidationException implements IteratorAggregate |
||
19 | { |
||
20 | /** |
||
21 | * @var SplObjectStorage |
||
22 | */ |
||
23 | private $exceptions = []; |
||
24 | |||
25 | /** |
||
26 | * @param ValidationException $exception |
||
27 | * |
||
28 | * @return self |
||
29 | */ |
||
30 | 3 | public function addRelated(ValidationException $exception) |
|
36 | |||
37 | /** |
||
38 | * @param string $path |
||
39 | * @param ValidationException $exception |
||
40 | * |
||
41 | * @return ValidationException |
||
42 | */ |
||
43 | private function getExceptionForPath($path, ValidationException $exception) |
||
59 | |||
60 | /** |
||
61 | * @param array $paths |
||
62 | * |
||
63 | * @return self |
||
64 | */ |
||
65 | public function findMessages(array $paths) |
||
94 | |||
95 | /** |
||
96 | * @return Exception |
||
97 | */ |
||
98 | 1 | public function findRelated($path) |
|
110 | |||
111 | /** |
||
112 | * @return RecursiveIteratorIterator |
||
113 | */ |
||
114 | 1 | private function getRecursiveIterator() |
|
124 | |||
125 | /** |
||
126 | * @return SplObjectStorage |
||
127 | */ |
||
128 | public function getIterator() |
||
175 | |||
176 | /** |
||
177 | * @return array |
||
178 | */ |
||
179 | public function getMessages() |
||
192 | |||
193 | /** |
||
194 | * @return string |
||
195 | */ |
||
196 | public function getFullMessage() |
||
214 | |||
215 | /** |
||
216 | * @return SplObjectStorage |
||
217 | */ |
||
218 | 3 | public function getRelated() |
|
226 | |||
227 | /** |
||
228 | * @param string $name |
||
229 | * @param mixed $value |
||
230 | * |
||
231 | * @return self |
||
232 | */ |
||
233 | public function setParam($name, $value) |
||
245 | |||
246 | /** |
||
247 | * @return bool |
||
248 | */ |
||
249 | 1 | private function isRelated($name, ValidationException $exception) |
|
253 | |||
254 | /** |
||
255 | * @return ValidationException |
||
256 | */ |
||
257 | 1 | public function getRelatedByName($name) |
|
269 | |||
270 | /** |
||
271 | * @param array $exceptions |
||
272 | * |
||
273 | * @return self |
||
274 | */ |
||
275 | public function setRelated(array $exceptions) |
||
283 | } |
||
284 |