Result - Code Metrics - Inspection of "New Concrete API" - Respect/Validation - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#678)

by Henrique

created 2017-02-01 18:11 UTC

Result A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	125
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	8
lcom	2
cbo	0
dl	0
loc	125
ccs	25
cts	25
cp	1
rs	10
c	0
b	0
f	0

8 Methods

Rating	Name	Size	Complexity
A	__construct()	8	1
A	isValid()	4	1
A	getInput()	4	1
A	getRule()	4	1
A	getChildren()	4	1
A	getProperties()	4	1
A	mergeProperties()	7	1
A	invert()	7	1

<?php

/*
 * This file is part of Respect/Validation.
 *
 * (c) Alexandre Gomes Gaigalas <[email protected]>
 *
 * For the full copyright and license information, please view the "LICENSE.md"
 * file that was distributed with this source code.
 */

namespace Respect\Validation;

/**
 * Handles validation's results.
 *
 * @author Henrique Moody <[email protected]>
 *
 * @since 2.0.0
 */
final class Result
{
    /**
     * @var bool
     */
    private $isValid;

    /**
     * @var mixed
     */
    private $input;

    /**
     * @var Rule
     */
    private $rule;

    /**
     * @var Rule[]
     */
    private $children;

    /**
     * @var array
     */
    private $properties;

    /**
     * Initializes the object.
     *
     * @param bool  $isValid
     * @param mixed $input
     * @param Rule  $rule
     * @param array $properties
     * @param Result ...$children
     */
    public function __construct(bool $isValid, $input, Rule $rule, array $properties = [], Result ...$children)
    {
        $this->isValid = $isValid;
        $this->input = $input;
        $this->rule = $rule;
        $this->properties = $properties;
        $this->children = $children;

    }

    /**
     * Returns whether the result is valid or not.
     *
     * @return bool
     */
    public function isValid(): bool
    {
        return $this->isValid;
    }

    /**
     * Returns the input that was used on the validation.
     *
     * @return mixed
     */
    public function getInput()
    {
        return $this->input;
    }

    /**
     * Returns the rule that performed the validation.
     *
     * @return Rule
     */
    public function getRule(): Rule
    {
        return $this->rule;
    }

    /**
     * Returns the children of the result.
     *
     * @return Result[]
     */
    public function getChildren(): array
    {
        return $this->children;
    }

    /**
     * Returns the properties of the result.
     *
     * @return array
     */
    public function getProperties(): array
    {
        return $this->properties;
    }

    /**
     * Creates a new object with the defined properties.
     *
     * @param array $properties
     *
     * @return Result
     */
    public function mergeProperties(array $properties): Result
    {
        $result = clone $this;
        $result->properties = $properties + $this->getProperties();

        return $result;
    }

    /**
     * Creates a new object with the inverted validation.
     *
     * @param array $properties
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return Result
     */
    public function invert(): Result
    {
        $result = clone $this;
        $result->isValid = !$result->isValid;

        return $result;
    }
}


1		<?php
2
3		/*
4		* This file is part of Respect/Validation.
5		*
6		* (c) Alexandre Gomes Gaigalas <[email protected]>
7		*
8		* For the full copyright and license information, please view the "LICENSE.md"
9		* file that was distributed with this source code.
10		*/
11
12		namespace Respect\Validation;
13
14		/**
15		* Handles validation's results.
16		*
17		* @author Henrique Moody <[email protected]>
18		*
19		* @since 2.0.0
20		*/
21		final class Result
22		{
23		/**
24		* @var bool
25		*/
26		private $isValid;
27
28		/**
29		* @var mixed
30		*/
31		private $input;
32
33		/**
34		* @var Rule
35		*/
36		private $rule;
37
38		/**
39		* @var Rule[]
40		*/
41		private $children;
42
43		/**
44		* @var array
45		*/
46		private $properties;
47
48		/**
49		* Initializes the object.
50		*
51		* @param bool $isValid
52		* @param mixed $input
53		* @param Rule $rule
54		* @param array $properties
55		* @param Result ...$children
56		*/
57	15	public function __construct(bool $isValid, $input, Rule $rule, array $properties = [], Result ...$children)
58		{
59	15	$this->isValid = $isValid;
60	15	$this->input = $input;
61	15	$this->rule = $rule;
62	15	$this->properties = $properties;
63	15	$this->children = $children;
		0 ignored issues – show Documentation Bug introduced 2017-01-29 17:35 UTC by Report Bug Copy Issue Report It seems like `$children` of type `array<integer,object<Respect\Validation\Result>>` is incompatible with the declared type `array<integer,object<Respect\Validation\Rule>>` of property `$children`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
64	15	}
65
66		/**
67		* Returns whether the result is valid or not.
68		*
69		* @return bool
70		*/
71	3	public function isValid(): bool
72		{
73	3	return $this->isValid;
74		}
75
76		/**
77		* Returns the input that was used on the validation.
78		*
79		* @return mixed
80		*/
81	3	public function getInput()
82		{
83	3	return $this->input;
84		}
85
86		/**
87		* Returns the rule that performed the validation.
88		*
89		* @return Rule
90		*/
91	3	public function getRule(): Rule
92		{
93	3	return $this->rule;
94		}
95
96		/**
97		* Returns the children of the result.
98		*
99		* @return Result[]
100		*/
101	3	public function getChildren(): array
102		{
103	3	return $this->children;
104		}
105
106		/**
107		* Returns the properties of the result.
108		*
109		* @return array
110		*/
111	8	public function getProperties(): array
112		{
113	8	return $this->properties;
114		}
115
116		/**
117		* Creates a new object with the defined properties.
118		*
119		* @param array $properties
120		*
121		* @return Result
122		*/
123	6	public function mergeProperties(array $properties): Result
124		{
125	6	$result = clone $this;
126	6	$result->properties = $properties + $this->getProperties();
127
128	6	return $result;
129		}
130
131		/**
132		* Creates a new object with the inverted validation.
133		*
134		* @param array $properties
		0 ignored issues – show Bug introduced 2017-02-01 18:17 UTC by Report Bug Copy Issue Report There is no parameter named `$properties`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
135		*
136		* @return Result
137		*/
138	6	public function invert(): Result
139		{
140	6	$result = clone $this;
141	6	$result->isValid = !$result->isValid;
142
143	6	return $result;
144		}
145		}
146

Respect / Validation

Scrutinizer GitHub App not installed

Pull Request — master (#678)

Result A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

8 Methods

Duplication Side-by-Side

Filter issues like