KeyValue - Code Metrics - Inspection of "Refactor "OneOf" rule" - Respect/Validation - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 2.0 ( e6a123 )

by Henrique

created 2017-02-03 15:26 UTC

KeyValue A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	86
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	14
lcom	1
cbo	3
dl	0
loc	86
ccs	0
cts	40
cp	0
rs	10
c	0
b	0
f	0

6 Methods

Rating	Name	Size	Complexity
A	overwriteExceptionParams()	15	3
A	__construct()	6	1
A	getRule()	19	4
A	assert()	12	2
A	check()	12	2
A	validate()	10	2

<?php

/*
 * This file is part of Respect/Validation.
 *
 * (c) Alexandre Gomes Gaigalas <[email protected]>
 *
 * For the full copyright and license information, please view the "LICENSE.md"
 * file that was distributed with this source code.
 */

namespace Respect\Validation\Rules;

use Respect\Validation\Exceptions\ComponentException;
use Respect\Validation\Exceptions\ValidationException;
use Respect\Validation\Validator;

class KeyValue extends AbstractRule
{
    public $comparedKey;
    public $ruleName;
    public $baseKey;

    public function __construct($comparedKey, $ruleName, $baseKey)
    {
        $this->comparedKey = $comparedKey;
        $this->ruleName = $ruleName;
        $this->baseKey = $baseKey;
    }

    private function getRule($input)
    {
        if (!isset($input[$this->comparedKey])) {
            throw $this->reportError($this->comparedKey);
        }

        if (!isset($input[$this->baseKey])) {
            throw $this->reportError($this->baseKey);
        }

        try {
            $rule = Validator::__callStatic($this->ruleName, [$input[$this->baseKey]]);
            $rule->setName($this->comparedKey);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        } catch (ComponentException $exception) {
            throw $this->reportError($input, ['component' => true]);
        }

        return $rule;
    }

    private function overwriteExceptionParams(ValidationException $exception)
    {
        $params = [];
        foreach ($exception->getParams() as $key => $value) {
            if (in_array($key, ['template', 'translator'])) {
                continue;
            }

            $params[$key] = $this->baseKey;
        }

        $exception->configure($this->comparedKey, $params);

        return $exception;
    }

    public function assert($input)
    {
        $rule = $this->getRule($input);

        try {
            $rule->assert($input[$this->comparedKey]);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        } catch (ValidationException $exception) {
            throw $this->overwriteExceptionParams($exception);
        }

        return true;
    }

    public function check($input)
    {
        $rule = $this->getRule($input);

        try {
            $rule->check($input[$this->comparedKey]);
        } catch (ValidationException $exception) {
            throw $this->overwriteExceptionParams($exception);
        }

        return true;
    }

    public function validate($input)
    {
        try {
            $rule = $this->getRule($input);
        } catch (ValidationException $e) {
            return false;
        }

        return $rule->validate($input[$this->comparedKey]);
    }
}


1			<?php
2
3			/*
4			* This file is part of Respect/Validation.
5			*
6			* (c) Alexandre Gomes Gaigalas <[email protected]>
7			*
8			* For the full copyright and license information, please view the "LICENSE.md"
9			* file that was distributed with this source code.
10			*/
11
12			namespace Respect\Validation\Rules;
13
14			use Respect\Validation\Exceptions\ComponentException;
15			use Respect\Validation\Exceptions\ValidationException;
16			use Respect\Validation\Validator;
17
18			class KeyValue extends AbstractRule
19			{
20			public $comparedKey;
21			public $ruleName;
22			public $baseKey;
23
24			public function __construct($comparedKey, $ruleName, $baseKey)
25			{
26			$this->comparedKey = $comparedKey;
27			$this->ruleName = $ruleName;
28			$this->baseKey = $baseKey;
29			}
30
31			private function getRule($input)
32			{
33			if (!isset($input[$this->comparedKey])) {
34			throw $this->reportError($this->comparedKey);
35			}
36
37			if (!isset($input[$this->baseKey])) {
38			throw $this->reportError($this->baseKey);
39			}
40
41			try {
42			$rule = Validator::__callStatic($this->ruleName, [$input[$this->baseKey]]);
43			$rule->setName($this->comparedKey);
			0 ignored issues – show Documentation Bug introduced 2017-02-03 10:52 UTC by Report Bug Copy Issue Report The method `setName` does not exist on `object<Respect\Validation\Validator>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
44			} catch (ComponentException $exception) {
45			throw $this->reportError($input, ['component' => true]);
46			}
47
48			return $rule;
49			}
50
51			private function overwriteExceptionParams(ValidationException $exception)
52			{
53			$params = [];
54			foreach ($exception->getParams() as $key => $value) {
55			if (in_array($key, ['template', 'translator'])) {
56			continue;
57			}
58
59			$params[$key] = $this->baseKey;
60			}
61
62			$exception->configure($this->comparedKey, $params);
63
64			return $exception;
65			}
66
67			public function assert($input)
68			{
69			$rule = $this->getRule($input);
70
71			try {
72			$rule->assert($input[$this->comparedKey]);
			0 ignored issues – show Documentation Bug introduced 2017-02-03 10:52 UTC by Report Bug Copy Issue Report The method `assert` does not exist on `object<Respect\Validation\Validator>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
73			} catch (ValidationException $exception) {
74			throw $this->overwriteExceptionParams($exception);
75			}
76
77			return true;
78			}
79
80			public function check($input)
81			{
82			$rule = $this->getRule($input);
83
84			try {
85			$rule->check($input[$this->comparedKey]);
86			} catch (ValidationException $exception) {
87			throw $this->overwriteExceptionParams($exception);
88			}
89
90			return true;
91			}
92
93			public function validate($input)
94			{
95			try {
96			$rule = $this->getRule($input);
97			} catch (ValidationException $e) {
98			return false;
99			}
100
101			return $rule->validate($input[$this->comparedKey]);
102			}
103			}
104

Respect / Validation

Scrutinizer GitHub App not installed

Push — 2.0 ( e6a123 )

KeyValue A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

6 Methods

Duplication Side-by-Side

Filter issues like